From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A682822F392; Wed, 15 Jan 2025 06:56:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=93.104.207.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736924173; cv=none; b=VG47gEGUiwUvj6v+yWkWSGBnOlzrhH3mxpqLJwB2i6sSSvGeNmzKKnPnJil6xM6OJzCUQ2A6+24ELwHa6YeDtLd5FbHKNO5HH1kT1NjTB4+O7Lw5h3xtpF4yZZ0FmZxkBrG0px0T6/tvgjviYxC47of8rmkSdx1BKn89J6GrB1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736924173; c=relaxed/simple; bh=uplevQf1DBuL/p+VfT9NuX2d3lq3vkW1oymExHJLGkY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=f+98qFUde8V549SvbqdYuy15LVrpKBy4wGD5qgbLVAwxPy8h74pl4z4VyubJFzTkq9xxFzWg2JaNWaWMnTEIzfn59ACsH/PTg1ue45JEyhhYx1QpzhV7aXdyxsVh9bTQ6gwQI60MhGPbdyGPHGN5Us/rVUfaGgE62IQPJ3Rhero= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com; spf=pass smtp.mailfrom=ew.tq-group.com; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b=hqtqwnR5; dkim=fail (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b=rRaUt3r4 reason="key not found in DNS"; arc=none smtp.client-ip=93.104.207.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b="hqtqwnR5"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="rRaUt3r4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1736924171; x=1768460171; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=NZWScfnhG5GpViQRhxbdTtAg65z7x4RzTUF+ZyOs9oE=; b=hqtqwnR5mgUD9Miho3/QOJTC1LlO7hs9+ksy8DuypfGR0toWQ20jaxeN sygGs3lPv65H+aicTYihqtfP4AX5TAh612Zn3/U0eBKk/CUkEVvjm8BVO supmc4c91rT109MdCflctSOQ8KSmKQMOsmwziyM9ZetsDQTvvJ+r/NfPD bp7tPJOyLWLWM4RKzFTCsRfcsjHN8VG3lxOVxRwr+ohTcR6tVxYJ1zhBe YIK3qECOWuSnit21yQlJR0ojkA9p4Mmd7SXJAWSpHyNbSXBFBSwxQQtdA jwnAI1r5N4wwQU7XkLWGQH0NuRzVQauWK/3llPaF0qzcoRcX+l8H3JyYB w==; X-CSE-ConnectionGUID: gsu/clicSM+xgQm8P2XkNw== X-CSE-MsgGUID: /xlyy+hpQRu21QT+U+Ca/g== X-IronPort-AV: E=Sophos;i="6.12,316,1728943200"; d="scan'208";a="41055623" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 15 Jan 2025 07:56:08 +0100 X-CheckPoint: {67875C08-2A-3C670366-E45AD810} X-MAIL-CPID: 4DCA0B359B8F2B8B5BAA414B640255C3_4 X-Control-Analysis: str=0001.0A682F28.67875C08.009C,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id DE05516A656; Wed, 15 Jan 2025 07:56:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1736924164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NZWScfnhG5GpViQRhxbdTtAg65z7x4RzTUF+ZyOs9oE=; b=rRaUt3r4mq0n3eb7lakp4IuWL8VHI5lLgQFtofeKLZDIi1fAcaaTZ8JIyAlDw5Us6wSQ0M xYYjkvmdGBCha/mkYW6snO2AY0f8xOYD0d4lNGon0ALqk+YPaCmXl+XWUEmP4Wp5xgS5TC XbYPn/PJGbavKZbz7kEp0oiJpEt3sAmegaDAZmydMLBH+AjMi3VOtpjk/ju5gB8ICgOT4k inRn5+MkpDdUx/JGMj5VSnuD4aIobLqC89rzX+rydW1EH4rB9/8Pnk04kW5AtmUmurtIMQ AyER144bIk1+4EKeu0xef4TWFv/uY+Jf8WONTsc+odM0AM1u9iJ9RbhdY9GmYw== From: Alexander Stein To: "Peng Fan (OSS)" , Peng Fan Cc: Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "imx@lists.linux.dev" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v5 2/2] nvmem: imx-ocotp-ele: Support accessing controller for i.MX9 Date: Wed, 15 Jan 2025 07:56:03 +0100 Message-ID: <6018578.MhkbZ0Pkbq@steina-w> Organization: TQ-Systems GmbH In-Reply-To: References: <20250108-imx-ocotp-v5-0-a6d90e18ebe9@nxp.com> <4956524.GXAFRqVoOG@steina-w> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Last-TLS-Session-Version: TLSv1.3 Hi, Am Dienstag, 14. Januar 2025, 09:35:41 CET schrieb Peng Fan: > > Subject: Re: [PATCH v5 2/2] nvmem: imx-ocotp-ele: Support accessing > > controller for i.MX9 > >=20 > > Hi, > >=20 > > Am Samstag, 11. Januar 2025, 13:41:58 CET schrieb Peng Fan: > > > > Subject: Re: [PATCH v5 2/2] nvmem: imx-ocotp-ele: Support > > accessing > > > > controller for i.MX9 > > > > > > > > Hi, > > > > > > > > Am Donnerstag, 9. Januar 2025, 04:34:18 CET schrieb Peng Fan: > > > > > On Wed, Jan 08, 2025 at 11:15:40AM +0100, Alexander Stein > > wrote: > > > > > >Hi Peng, > > > > > > > > > > > >Am Mittwoch, 8. Januar 2025, 08:00:18 CET schrieb Peng Fan > > (OSS): > > > > > >> From: Peng Fan > > > > > >> > > > > > >> i.MX9 OCOTP supports a specific peripheral or function being > > > > fused > > > > > >> which means disabled, so > > > > > >> - Introduce ocotp_access_gates to be container of efuse gate > > > > > >> info > > > > > >> - Iterate all nodes to check accessing permission. If not > > > > > >> allowed to be accessed, detach the node > > > > > >> > > > > > >> Signed-off-by: Peng Fan > > > > > >> --- > > > > > >> drivers/nvmem/imx-ocotp-ele.c | 172 > > > > > >> +++++++++++++++++++++++++++++++++++++++++- > > > > > >> 1 file changed, 171 insertions(+), 1 deletion(-) > > > > > >> > > > > > [....] > > > > > >> + > > > > > >> + return imx_ele_ocotp_access_control(priv); > > > > > > > > > > > >In [1] you mentioned devlink should solve the probe order. How > > > > does > > > > > >this play when the driver is compiled in (e.g. ethernet for NFS > > > > > >boot) but this OCOTP driver is just a module? > > > > > > > > > > OCOTP needs to built in for using devlink. Or the users needs to > > > > > be built as module. > > > > > > > > I don't like this kind of assumption. Would it make more sense to > > > > make CONFIG_NVMEM_IMX_OCOTP_ELE as bool instead of tristate? > > > > > > No. Users could setup their own system with this driver build in or > > > built related drivers as modules. > >=20 > > Sure, but if the kernel locks/fails/panics while accessing peripherals = just > > because of the kernel config seems at east very unfortunate to me. > > How is someone supposed to analyze/debug this? > >=20 > > > At least for Android GKI, this driver needs to be as module. > >=20 > > Any particular reason this needs to be a module? >=20 > Android has a minimal kernel which is controlled by Google. > Vendors could only built modules based on Google's Image. >=20 > Updating this to y in upstream, means we need to change > it back to m in NXP downstream android kernel. Ok, that's an Android thing. > If you need it built in, you could modify your downstream > config, right? I'm not saying I need a built-in. My concern is that a wrong Kconfig will result in silent errors/lockups. Best regards, Alexander =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/