From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 752F2EE49AB for ; Tue, 22 Aug 2023 19:40:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229889AbjHVTkZ (ORCPT ); Tue, 22 Aug 2023 15:40:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbjHVTkZ (ORCPT ); Tue, 22 Aug 2023 15:40:25 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E9601BE for ; Tue, 22 Aug 2023 12:40:22 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-52a250aa012so78763a12.3 for ; Tue, 22 Aug 2023 12:40:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692733221; x=1693338021; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oncWTlQk8VDq0hStA9yIW5pShLFRqkLO/45VKHfvDbY=; b=iqKxwUnpJsfPKGpODtNN+Pd+GT5zpruOKowDyFgFmDZDqT1p9lopCmC0R6vbFjeTgS We3rj1I7cVPaPUnsiBDw3wHk37aqPZ6lnIVc8U3j2iBgRLzZWzvZcnLwG5uwhtrm5pa1 IqY8WL4o04kXjVF8EFsdlZwMgCWQTTmkl6A3Ke+o9gcKpbEy4ocWBtfAOCnrdbTl33MK 6vdUkZxibv/ypQt6Ejt7AK0+UWwmqfIUDGL9/EOKqPmfdMOtIocjo3Ozf89y/UwHCw7r kDBkcewLbnIViDiJ9iTeTcDuTKnfZd97PAXVj3VadTky68vFIsRQcOcZEay+QITXL/Y4 S/3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692733221; x=1693338021; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oncWTlQk8VDq0hStA9yIW5pShLFRqkLO/45VKHfvDbY=; b=i9geXpJkD2XN0CBfbZajIrfb1VA6OZ+PWk0P7NedpLHm7PslTzBtLHMeDXSno3Cycs o4FKu1DQELk7GAs5R7XSy4Jrc5rQ0iQtwnfemjNQoQdtXluIemcNhBPbvQeE20/M1HFk LXRUdMPQl4Ej/7j4WmOdUhPyPgWKt0MKqnRdFr9t68W5vYlglA0+KzQu1ZC39fiJ4vLF s4oSTEm6rsvOAP6s8LXDbYp1ieEM4bm1oFv+24fL8dplB3KYI5BPSpp/n8F9FX+WAtkE N0cY4pPB0tKhqOfiU821dEV+2lABRRzC7pRyYeaUqPHc552dsQqtMRuqMSqlMHWEdU/5 FMzg== X-Gm-Message-State: AOJu0Yz4BL+ueJUfEAlTHA/Gj6QyqBhc5ksxstCvXPmvkCQVetg/37N8 TbfWYYQQy8I2AGBxMEdcRrxYNA== X-Google-Smtp-Source: AGHT+IEfWoVEpmQaJIzd2SVcJ8YfHw3JakiI1hknfuAmtQIy7qr8RlSu+3Xqc3F6rEIuTgoAgzS9oQ== X-Received: by 2002:a17:907:a041:b0:99d:e3d3:15a9 with SMTP id gz1-20020a170907a04100b0099de3d315a9mr8513551ejc.10.1692733220987; Tue, 22 Aug 2023 12:40:20 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.198]) by smtp.gmail.com with ESMTPSA id e16-20020a170906045000b0098dfec235ccsm8621380eja.47.2023.08.22.12.40.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Aug 2023 12:40:20 -0700 (PDT) Message-ID: <60221aab-d8da-9f0b-057b-e8a28840849f@linaro.org> Date: Tue, 22 Aug 2023 21:40:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2 05/11] regulator: dt-bindings: mediatek: Add MT6366 PMIC Content-Language: en-US From: Krzysztof Kozlowski To: Chen-Yu Tsai , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Mark Brown Cc: Zhiyong Tao , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230822084520.564937-1-wenst@chromium.org> <20230822084520.564937-6-wenst@chromium.org> <337f20d5-4dfe-90ef-16b9-c10b14060b97@linaro.org> In-Reply-To: <337f20d5-4dfe-90ef-16b9-c10b14060b97@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22/08/2023 21:39, Krzysztof Kozlowski wrote: > On 22/08/2023 10:45, Chen-Yu Tsai wrote: >> From: Zhiyong Tao >> >> The MediaTek MT6366 PMIC is similar to the MT6358 PMIC. It is designed >> to be paired with the MediaTek MT8186 SoC. It has 9 buck regulators and >> 29 LDO regulators, not counting ones that feed internally and basically >> have no controls. The regulators are named after their intended usage >> for the SoC and system design, thus not named generically as ldoX or >> dcdcX, but as vcn33 or vgpu. >> >> Add a binding document describing all the regulators and their supplies. >> >> Signed-off-by: Zhiyong Tao >> [wens@chromium.org: major rework and added commit message] >> Signed-off-by: Chen-Yu Tsai >> --- >> Changes since v1: >> - Replaced underscores in supply names to hyphens >> - Merged with MT6358 regulator binding >> - Added MT6358 fallback compatible to MT6366 regulator >> >> Changes since Zhiyong's last version (v4) [1]: >> - simplified regulator names >> - added descriptions to regulators >> - removed bogus regulators (*_sshub) >> - merged vcn33-wifi and vcn33-bt as vcn33 >> - added missing regulators (vm18, vmddr, vsram-core) >> - cut down examples to a handful of cases and made them complete >> - expanded commit message a lot >> >> [1] https://lore.kernel.org/linux-arm-kernel/20220823123745.14061-1-zhiyong.tao@mediatek.com/ >> .../regulator/mediatek,mt6358-regulator.yaml | 227 +++++++++++++----- >> 1 file changed, 168 insertions(+), 59 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt6358-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt6358-regulator.yaml >> index 82328fe17680..b350181f33ff 100644 >> --- a/Documentation/devicetree/bindings/regulator/mediatek,mt6358-regulator.yaml >> +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6358-regulator.yaml >> @@ -16,14 +16,18 @@ description: | >> >> properties: >> compatible: >> - const: mediatek,mt6358-regulator >> + oneOf: >> + - const: mediatek,mt6358-regulator >> + - items: >> + - const: mediatek,mt6366-regulator >> + - const: mediatek,mt6358-regulator >> >> vsys-ldo1-supply: >> description: Supply for LDOs vfe28, vxo22, vcn28, vaux18, vaud28, vsim1, vusb, vbif28 >> vsys-ldo2-supply: >> - description: Supply for LDOs vldo28, vio28, vmc, vmch, vsim2 >> + description: Supply for LDOs vldo28 (MT6358 only), vio28, vmc, vmch, vsim2 >> vsys-ldo3-supply: >> - description: Supply for LDOs vcn33, vcama1, vcama2, vemc, vibr >> + description: Supply for LDOs vcn33, vcama[12] (MT6358 only), vemc, vibr >> vsys-vcore-supply: >> description: Supply for buck regulator vcore >> vsys-vdram1-supply: >> @@ -43,75 +47,138 @@ properties: >> vsys-vs2-supply: >> description: Supply for buck regulator vs2 >> vs1-ldo1-supply: >> - description: Supply for LDOs vrf18, vefuse, vcn18, vcamio, vio18 >> + description: Supply for LDOs vrf18, vefuse, vcn18, vcamio (MT6358 only), vio18 >> vs2-ldo1-supply: >> - description: Supply for LDOs vdram2 >> + description: Supply for LDOs vdram2, vmddr (MT6366 only) >> vs2-ldo2-supply: >> description: Supply for LDOs vrf12, va12 >> vs2-ldo3-supply: >> - description: Supply for LDOs vsram-gpu, vsram-others, vsram-proc11, vsram-proc12 >> - vs2-ldo4-supply: >> - description: Supply for LDO vcamd >> - >> -patternProperties: >> - "^buck_v(core|dram1|gpu|modem|pa|proc1[12]|s[12])$": >> - description: Buck regulators >> - type: object >> - $ref: regulator.yaml# >> - unevaluatedProperties: false >> - >> - "^ldo_v(a|rf)12": >> - description: LDOs with fixed 1.2V output and 0~100/10mV tuning >> - type: object >> - $ref: regulator.yaml# >> - unevaluatedProperties: false >> - >> - "^ldo_v((aux|cn|io|rf)18|camio)": >> - description: LDOs with fixed 1.8V output and 0~100/10mV tuning >> - type: object >> - $ref: regulator.yaml# >> - unevaluatedProperties: false >> - >> - "^ldo_vxo22": >> - description: LDOs with fixed 2.2V output and 0~100/10mV tuning >> - type: object >> - $ref: regulator.yaml# >> - unevaluatedProperties: false >> - >> - "^ldo_v(aud|bif|cn|fe|io)28": >> - description: LDOs with fixed 2.8V output and 0~100/10mV tuning >> - type: object >> - $ref: regulator.yaml# >> - unevaluatedProperties: false >> - >> - "^ldo_vusb": >> - description: LDOs with fixed 3.0V output and 0~100/10mV tuning >> - type: object >> - $ref: regulator.yaml# >> - unevaluatedProperties: false >> - >> - "^ldo_vsram_(gpu|others|proc1[12])$": >> - description: LDOs with variable output >> - type: object >> - $ref: regulator.yaml# >> - unevaluatedProperties: false >> - >> - "^ldo_v(cama[12]|camd|cn33|dram2|efuse|emc|ibr|ldo28|mc|mch|sim[12])$": >> - description: LDOs with variable output and 0~100/10mV tuning >> - type: object >> - $ref: regulator.yaml# >> - unevaluatedProperties: false > > I don't understand. You just added it and it is already wrong? Please, > do not add code which is clearly incorrect. Sent too early - anyway properties cannot be defined in allOf:. That's not the place for them and there is no single reason for it. From which regulator binding you got this example? Best regards, Krzysztof