From: Andrew Lunn <andrew@lunn.ch>
To: Junhao Xie <bigfoot@classfun.cn>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>, Jonas Karlman <jonas@kwiboo.se>,
Chukun Pan <amadeus@jmu.edu.cn>, FUKAUMI Naoki <naoki@radxa.com>,
Dragan Simic <dsimic@manjaro.org>,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568
Date: Wed, 4 Sep 2024 19:25:55 +0200 [thread overview]
Message-ID: <6030542f-070d-4d76-9a5a-fbfc6bd433e6@lunn.ch> (raw)
In-Reply-To: <20240904111456.87089-4-bigfoot@classfun.cn>
> +&gmac1 {
> + assigned-clocks = <&cru SCLK_GMAC1_RX_TX>, <&cru SCLK_GMAC1>;
> + assigned-clock-parents = <&cru SCLK_GMAC1_RGMII_SPEED>;
> + assigned-clock-rates = <0>, <125000000>;
> + clock_in_out = "output";
> + phy-handle = <&rgmii_phy1>;
> + phy-mode = "rgmii";
> + phy-supply = <&vcc_3v3>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&gmac1m1_miim
> + &gmac1m1_tx_bus2
> + &gmac1m1_rx_bus2
> + &gmac1m1_rgmii_clk
> + &gmac1m1_rgmii_bus>;
> + snps,reset-gpio = <&gpio4 RK_PC0 GPIO_ACTIVE_LOW>;
> + snps,reset-active-low;
> + snps,reset-delays-us = <0 20000 100000>;
> + tx_delay = <0x38>;
> + rx_delay = <0x15>;
> + status = "okay";
This has been discussed a few times. You should be using phy-mode
rgmii-id.
arch/arm/boot/dts/rockchip/rk3288-phycore-som.dtsi is i think also a
YT8521SC.
Andrew
next prev parent reply other threads:[~2024-09-04 17:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 11:14 [PATCH 0/3] Add support for Ariaboard Photonicat RK3568 Junhao Xie
2024-09-04 11:14 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add Shanghai Novotech Ariaboard Junhao Xie
2024-09-04 11:35 ` Krzysztof Kozlowski
2024-09-04 12:14 ` Junhao Xie
2024-09-04 13:29 ` Krzysztof Kozlowski
2024-09-05 5:22 ` Junhao Xie
2024-09-04 11:14 ` [PATCH 2/3] dt-bindings: arm: rockchip: Add Ariaboard Photonicat RK3568 Junhao Xie
2024-09-04 11:36 ` Krzysztof Kozlowski
2024-09-04 11:14 ` [PATCH 3/3] arm64: dts: rockchip: add dts for " Junhao Xie
2024-09-04 17:25 ` Andrew Lunn [this message]
2024-09-05 5:47 ` Junhao Xie
2024-09-05 11:17 ` Junhao Xie
2024-09-05 12:53 ` Andrew Lunn
2024-09-05 18:01 ` Junhao Xie
2024-09-05 18:20 ` Andrew Lunn
2024-09-06 3:50 ` Chukun Pan
2024-09-06 4:13 ` Junhao Xie
2024-09-05 3:40 ` Chukun Pan
2024-09-05 9:17 ` Junhao Xie
2024-09-05 10:01 ` Chukun Pan
2024-09-05 11:06 ` Junhao Xie
2024-09-04 13:36 ` [PATCH 0/3] Add support " Rob Herring (Arm)
2024-09-05 5:37 ` Junhao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6030542f-070d-4d76-9a5a-fbfc6bd433e6@lunn.ch \
--to=andrew@lunn.ch \
--cc=amadeus@jmu.edu.cn \
--cc=bigfoot@classfun.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=naoki@radxa.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox