Re: [PATCH 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568

Junhao Xie
2024-09-05T11:05:29Z

On 2024/9/5 18:01, Chukun Pan wrote:
> Hi Junhao,
>
>>>> + vcc5v0_usb_modem: regulator-5v0-vcc-usb-modem {
>>>
>>> Are you sure this regulator is 5v?
>>>
>>
>> It should actually be 3.3V, I will fix it and rename
>> to vcc3v3_usb_modem
>
> I prefer vcc3v3_rf or vcc3v3_ngff,
> this is closer to the schematics.
>

Yes, I changed it to vcc3v3_rf, this is the name used in the schematics.

>>>> + pinctrl-names = "default";
>>>> + pinctrl-0 = <&pcie30x2m1_pins>;
>>>
>>> These are actually pcie30x1m0_pins.
>>
>> pcie30x1m0_pins seems to conflict with sdmmc0,
>> I changed it to pcie30x1m1_pins
>
> This is obviously incorrect. I didn't notice that
> your pinctrl for sdmmc0 is wrong.
> (Because the cd pin are different)

After fixing sdmmc0, using pcie30x1m0_pins can work normally.

Best regards,
Junhao