From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 109A5C4332F for ; Fri, 4 Nov 2022 13:09:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229745AbiKDNJH (ORCPT ); Fri, 4 Nov 2022 09:09:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229804AbiKDNJF (ORCPT ); Fri, 4 Nov 2022 09:09:05 -0400 Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 744D827B0C for ; Fri, 4 Nov 2022 06:09:04 -0700 (PDT) Received: by mail-qt1-x829.google.com with SMTP id x15so2945491qtv.9 for ; Fri, 04 Nov 2022 06:09:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vZ8hfa5U3lUaaForj2mH3Ulz54E7m/Sy69csnuU6d1I=; b=jthoUqjMA2TjIz8CooFEFC1WQHTjAz/A4lZ+uBXFlARKTaTZm0FEj8AbAXdQKI/C5Q s5rK/pzYhtrNhlJ5wBSI5+hhTg4UUXPAkUvsRr3XwWqJinBUi1Q4kzZXxDjsVAPh6Hl1 +9x+timhhVAL+4VreRxB0tjGF1qNPvFsYLMstc9yva/ZlxvtGeicL1/pjSJ2HfXU+9f9 ts6q52vkNK0dz3lVoZ6CKZqUtdW1lSDCGforMu9FuS8OkmcEXoO90fw2BpMGRDH5GzfL MqYithP93WSyajXKzqz24RY9kZDWosc5lI0a7VDDklwwxRUtErdMU7nmUTW1VQeaFKZI vgLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vZ8hfa5U3lUaaForj2mH3Ulz54E7m/Sy69csnuU6d1I=; b=tbjsLYrP/yYNQMCEsx/v+ZGH/QFWO9LjWB9MwafkUpEO/po0QEccY5LyFfPMi7RzLE JkkXDmJRZIi5R2M5vWd3GQnnEtQlUvw4UTg1N34JrXzyQ8wqsS3KaEvlwIs5v4/HWOga LAcVRszLuTkGJY9EMRg00nXaX538AHqZZe3l2HPgwkQBv4SJf5D/NTPkRbIWEMCQT4ao 38tiF4rheu6l252QgRL3P5+ki2VQ5C+Cr7iANiNYbLtxZLAynK8PjvDHTv7YrNiK3bOi v2ESJO1UGWuL9g6ASybfezO6CLrJcjPmD0eVC/NTsB4+uUGmCU7kJ8DiGRsuluGc2WtK JsYQ== X-Gm-Message-State: ACrzQf2s+bVVlHuqEWHjh4FZADDZeHt/WtM5LTSpVhB2rvXLeuZVZg9n DguAyeUbuW0nN5A7AJ/Q6WXDjQ== X-Google-Smtp-Source: AMsMyM6Mj8AWm3KMbV3ZCvDwJXJMgtC//MdJssJ2i8xP7YwpBQ+mizNHgB8VAwFkINWnPdaT9J8FPA== X-Received: by 2002:a05:622a:12:b0:3a5:6899:5add with SMTP id x18-20020a05622a001200b003a568995addmr1816091qtw.629.1667567343572; Fri, 04 Nov 2022 06:09:03 -0700 (PDT) Received: from ?IPV6:2601:586:5000:570:aad6:acd8:4ed9:299b? ([2601:586:5000:570:aad6:acd8:4ed9:299b]) by smtp.gmail.com with ESMTPSA id b6-20020a05620a0cc600b006e6a7c2a269sm2861212qkj.22.2022.11.04.06.09.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Nov 2022 06:09:03 -0700 (PDT) Message-ID: <6056fe63-26f8-bbda-112a-5b7cf25570ad@linaro.org> Date: Fri, 4 Nov 2022 09:09:02 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2] dt-bindings: net: nxp,sja1105: document spi-cpol/cpha Content-Language: en-US To: Vladimir Oltean Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221102185232.131168-1-krzysztof.kozlowski@linaro.org> <20221103233319.m2wq5o2w3ccvw5cu@skbuf> <698c3a72-f694-01ac-80ba-13bd40bb6534@linaro.org> <20221104020326.4l63prl7vxgi3od7@skbuf> From: Krzysztof Kozlowski In-Reply-To: <20221104020326.4l63prl7vxgi3od7@skbuf> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/11/2022 22:03, Vladimir Oltean wrote: > On Thu, Nov 03, 2022 at 09:44:36PM -0400, Krzysztof Kozlowski wrote: >>> Don't these belong to spi-peripheral-props.yaml? >> >> No, they are device specific, not controller specific. Every device >> requiring them must explicitly include them. >> >> See: >> https://lore.kernel.org/all/20220816124321.67817-1-krzysztof.kozlowski@linaro.org/ >> >> Best regards, >> Krzysztof >> > > I think you really mean to link to: > https://lore.kernel.org/all/20220718220012.GA3625497-robh@kernel.org/ > > oh and btw, doesn't that mean that the patch is missing > Fixes: 233363aba72a ("spi/panel: dt-bindings: drop CPHA and CPOL from common properties") > ? > > but I'm not sure I understand the reasoning? I mean, from the > perspective of the common schema, isn't it valid to put "spi-cpha" on a > SPI peripheral OF node even if the hardware doesn't support it, in the > same way that it's valid to put spi-max-frequency = 1 GHz even if the It is not valid to put spi-max-frequency = 1 GHz in spi-peripheral-props.yaml. > hardware doesn't support it? Or maybe I'm missing the point of > spi-peripheral-props.yaml entirely? Since when is stacked-memories/ > parallel-memories something that should be accepted by all schemas of > all SPI peripherals (for example here, an Ethernet switch)? Since we discussed it last time. What is not clear in Rob's response? He nicely explained the purpose of spi-peripheral-props.yaml. > I think that spi-cpha/spi-cpol belongs to spi-peripheral-props.yaml just > as much as the others do. > > The distinction "device specific, not controller specific" is arbitrary > to me. These are settings that the controller has to make in order to > talk to that specific peripheral. Same as many others in that file. Not every fruit is an orange, but every orange is a fruit. You do not put "color: orange" to schema for fruits. You put it to the schema for oranges. IOW, CPHA/CPOL are not valid for most devices, so they cannot be in spi-peripheral-props.yaml. Best regards, Krzysztof