From: "Heiko Stübner" <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Diederik de Haas <didi.debian@cknow.org>
Cc: Diederik de Haas <didi.debian@cknow.org>,
Dragan Simic <dsimic@manjaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: rockchip: Fix wakeup prop names on brcm BT nodes
Date: Mon, 07 Oct 2024 16:06:24 +0200 [thread overview]
Message-ID: <6096052.lOV4Wx5bFT@diego> (raw)
In-Reply-To: <20241007105657.6203-5-didi.debian@cknow.org>
Am Montag, 7. Oktober 2024, 12:28:18 CEST schrieb Diederik de Haas:
> The "brcm,bluetooth.yaml" binding has 'device-wakeup-gpios' and
> 'host-wakeup-gpios' property names.
> Fix the ones where '*-wake-gpios' was used.
>
> Note that the "realtek,bluetooth.yaml" binding does use the
> '*-wake-gpios' property names.
>
> Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
parts of the commit conflict with a previous one from me ;-) [0]
[0] https://lore.kernel.org/linux-arm-kernel/20240930210112.1993625-7-heiko@sntech.de/T/#m59bdb72d6c22f85fe79716761fedaea2a2e1c73e
> ---
> arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts | 4 ++--
> arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
> index 0c18406e4c59..16fd98698db3 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
> @@ -450,8 +450,8 @@ bluetooth {
> compatible = "brcm,bcm43438-bt";
> clocks = <&pmucru CLK_RTC_32K>;
> clock-names = "ext_clock";
> - device-wake-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>;
> - host-wake-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>;
> + device-wakeup-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>;
> + host-wakeup-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>;
> shutdown-gpios = <&gpio2 RK_PB7 GPIO_ACTIVE_HIGH>;
> pinctrl-names = "default";
> pinctrl-0 = <&bt_host_wake_l &bt_wake_l &bt_enable_h>;
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
> index de4c082dce07..7381bb751852 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
> @@ -684,8 +684,8 @@ bluetooth {
> compatible = "brcm,bcm43438-bt";
> clocks = <&rk817 1>;
> clock-names = "lpo";
> - device-wake-gpios = <&gpio0 RK_PC2 GPIO_ACTIVE_HIGH>;
> - host-wake-gpios = <&gpio0 RK_PC3 GPIO_ACTIVE_HIGH>;
> + device-wakeup-gpios = <&gpio0 RK_PC2 GPIO_ACTIVE_HIGH>;
> + host-wakeup-gpios = <&gpio0 RK_PC3 GPIO_ACTIVE_HIGH>;
> reset-gpios = <&gpio0 RK_PC4 GPIO_ACTIVE_LOW>;
> pinctrl-0 = <&bt_enable_h>, <&bt_host_wake_l>, <&bt_wake_h>;
> pinctrl-names = "default";
>
next prev parent reply other threads:[~2024-10-07 14:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 10:28 rockchip: Fix several DT validation errors Diederik de Haas
2024-10-07 10:28 ` [PATCH 1/4] arm64: dts: rockchip: Add PD to csi dphy node on rk356x Diederik de Haas
2024-10-07 10:28 ` [PATCH 2/4] arm64: dts: rockchip: Remove hdmi's 2nd interrupt on rk3328 Diederik de Haas
2024-10-07 10:28 ` [PATCH 3/4] arm64: dts: rockchip: Fix wakeup prop names on brcm BT nodes Diederik de Haas
2024-10-07 14:06 ` Heiko Stübner [this message]
2024-10-07 14:22 ` Diederik de Haas
2024-10-07 10:28 ` [PATCH 4/4] arm64: dts: rockchip: Fix reset-gpios prop " Diederik de Haas
2024-10-07 14:04 ` Heiko Stübner
2024-10-07 14:28 ` Diederik de Haas
2024-10-07 18:44 ` rockchip: Fix several DT validation errors Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6096052.lOV4Wx5bFT@diego \
--to=heiko@sntech.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=didi.debian@cknow.org \
--cc=dsimic@manjaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).