From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B0F3C4332F for ; Thu, 15 Dec 2022 13:19:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229925AbiLONTv (ORCPT ); Thu, 15 Dec 2022 08:19:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbiLONTt (ORCPT ); Thu, 15 Dec 2022 08:19:49 -0500 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1631F2DA9F for ; Thu, 15 Dec 2022 05:19:46 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id b3so15634400lfv.2 for ; Thu, 15 Dec 2022 05:19:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cF1K8h19SwoaL+H+wMzf1igK2zwK+4CVmKGZfHMVXA0=; b=CYhqFp9awOtIqq88padY/BvYAEbNELfE1BReY1kkBo0kwVO4/9gAhkVxYepRGZH5s3 O8uks3Ia6HvRGgxX4NQjcAtFd4QyR2tAftLa8ZatC9gtLhbimhSKd7b1m2rxI8NXAVce pnsCqs9+wUxXrhUrgMJMomMPTm3sJbU0ukgBUxPBv36UkvlBDs0w8IccGoBV3wB+ytcW yIluAPF96EsEpFbHoSYnYBOn7ekh1mJrcyWvEfdPX4oEWnpsZaBHg7/4Djhdr7FQKfVt PRkw/B+h6y7KgfikAbTAw9S1yR0SAiRjZz/pFVZ3Ke2ZigjEbs0Vuhe894OhbjJYW2lv nF7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cF1K8h19SwoaL+H+wMzf1igK2zwK+4CVmKGZfHMVXA0=; b=U1LAnVQJQGT77dVY8ZyHfOstSjWtCG/DzMsDErrbiyme3p4qdCUUk+HUf8lauiFrUm Ga3CtXLizGnc1Q9SvTB+xCjUtzP/VPEuOYBDPQ/dFYmyc7FX58bzTqEOR6w9lFt3D7cK G76MUn8M4YeIeCwRSRBSEXLS/tAFRJe5aLPx2npVfaNnsuhZcmU7TicYtovAwFNs5rbn LXzb/WnLb6lyl2sjTdRBKdzJNmx9RrEdOzjilNdOqT3mMktlKtpEuIrgu2kxGCfoje/N lKBL7w7oD+Lmvqvr7TW4ZnXwRfkbgklGM6aee9BlW4BqZrVt/lkEfih8N1ff2vRwsLFQ Z4Tw== X-Gm-Message-State: ANoB5pn/otdwSKvE1UBl/iFmVVrxEZfNgmnl+4/AIPDUQjQcQi6C5/tH xcd6iXVEFNN4m61Wkk0BomGUmQ== X-Google-Smtp-Source: AA0mqf4Im1g9A1hT9ddgBaf9F7aGA+qWQlnhSMZrmcYwrVqvzzJwnWohYxeeekauBPQZmn/wu/Aj/A== X-Received: by 2002:a05:6512:3d2a:b0:4b5:98ca:548 with SMTP id d42-20020a0565123d2a00b004b598ca0548mr11228556lfv.39.1671110384410; Thu, 15 Dec 2022 05:19:44 -0800 (PST) Received: from [192.168.1.101] (abxh44.neoplus.adsl.tpnet.pl. [83.9.1.44]) by smtp.gmail.com with ESMTPSA id b12-20020a0565120b8c00b0048a8c907fe9sm1157238lfv.167.2022.12.15.05.19.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Dec 2022 05:19:43 -0800 (PST) Message-ID: <60a40ace-d4e9-df74-88f9-4354d80efaac@linaro.org> Date: Thu, 15 Dec 2022 14:19:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 4/6] arm64: dts: qcom: msm8976: Declare and use SDC1 pins Content-Language: en-US To: Marijn Suijten , phone-devel@vger.kernel.org, Bjorn Andersson Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Andy Gross , Rob Herring , Krzysztof Kozlowski , AngeloGioacchino Del Regno , Luca Weiss , Adam Skladowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221214232049.703484-1-marijn.suijten@somainline.org> <20221214232049.703484-5-marijn.suijten@somainline.org> From: Konrad Dybcio In-Reply-To: <20221214232049.703484-5-marijn.suijten@somainline.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 15.12.2022 00:20, Marijn Suijten wrote: > Add the pinctrl states for SDC1 and use them on sdhc_1. > > Signed-off-by: Marijn Suijten > --- > arch/arm64/boot/dts/qcom/msm8976.dtsi | 55 +++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8976.dtsi b/arch/arm64/boot/dts/qcom/msm8976.dtsi > index 05dcb30b0779..7d4c7548882c 100644 > --- a/arch/arm64/boot/dts/qcom/msm8976.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8976.dtsi > @@ -508,6 +508,56 @@ tlmm: pinctrl@1000000 { > interrupt-controller; > #interrupt-cells = <2>; > > + sdc1_off_state: sdc1-off-state { > + clk-pins { > + pins = "sdc1_clk"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + cmd-pins { > + pins = "sdc1_cmd"; > + drive-strength = <2>; > + bias-pull-up; > + }; > + > + data-pins { > + pins = "sdc1_data"; > + drive-strength = <2>; > + bias-pull-up; > + }; > + > + rclk-pins { > + pins = "sdc1_rclk"; > + bias-pull-down; > + }; > + }; > + > + sdc1_on_state: sdc1-on-state { > + clk-pins { > + pins = "sdc1_clk"; > + drive-strength = <16>; > + bias-disable; > + }; > + > + cmd-pins { > + pins = "sdc1_cmd"; > + drive-strength = <10>; > + bias-pull-up; > + }; > + > + data-pins { > + pins = "sdc1_data"; > + drive-strength = <10>; > + bias-pull-up; > + }; > + > + rclk-pins { > + pins = "sdc1_rclk"; > + bias-pull-down; > + }; > + }; > + > spi1_default: spi0-default-state { > spi-pins { > pins = "gpio0", "gpio1", "gpio3"; > @@ -680,6 +730,11 @@ sdhc_1: mmc@7824000 { > <&gcc GCC_SDCC1_APPS_CLK>, > <&rpmcc RPM_SMD_XO_CLK_SRC>; > clock-names = "iface", "core", "xo"; > + > + pinctrl-0 = <&sdc1_on_state>; > + pinctrl-1 = <&sdc1_off_state>; > + pinctrl-names = "default", "sleep"; pinctrl-names usually goes before pinctrl-N Konrad > + > status = "disabled"; > }; >