From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: William Zhang <william.zhang@broadcom.com>,
Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>
Cc: Samyon Furman <samyon.furman@broadcom.com>,
Joel Peshkin <joel.peshkin@broadcom.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Dan Beygelman <dan.beygelman@broadcom.com>,
Tomer Yacoby <tomer.yacoby@broadcom.com>,
Anand Gore <anand.gore@broadcom.com>,
Kursad Oney <kursad.oney@broadcom.com>,
Arnd Bergmann <arnd@arndb.de>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Olof Johansson <olof@lixom.net>, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, soc@kernel.org
Subject: Re: [PATCH 3/5] ARM: dts: add dts files for bcmbca soc 47622
Date: Tue, 12 Apr 2022 18:27:54 +0200 [thread overview]
Message-ID: <60a9a401-7d1f-5100-7c3d-45452ebfa2ae@linaro.org> (raw)
In-Reply-To: <147e23b6-c5a3-a9fa-c0e1-defe906e42a9@broadcom.com>
On 12/04/2022 17:37, William Zhang wrote:
>>> +/ {
>>> + compatible = "brcm,bcm47622";
>>
>> This does not match your bindings. Even if it is not used.
> Did I miss anything? But it matches one of the compatible strings in
> brcm,bcmbca.yaml.
Your bindings expect that this compatible is followed with "brcm,bcmbca".
(...)
>>> + periph-bus@ff800000 {
>>
>> just "bus" to be generic?
> This node represents the peripheral bus in the soc. Would prefer to use
> the specific name unless it is not allowed by the linux dts.
It is allowed but the Devicetree spec explicitly asks for generic names
and gives example: bus ("2.2.2 Generic Names Recommendation"). Specific
names are discouraged.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-12 16:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 17:28 [PATCH 0/5] arm: bcmbca: introduce the bcmbca architecture and 47622 SOC William Zhang
2022-04-11 17:28 ` [PATCH 1/5] dt-bindings: arm: add bcmbca device tree binding document William Zhang
2022-04-12 11:28 ` Krzysztof Kozlowski
2022-04-11 17:28 ` [PATCH 3/5] ARM: dts: add dts files for bcmbca soc 47622 William Zhang
2022-04-12 11:27 ` Krzysztof Kozlowski
2022-04-12 15:37 ` William Zhang
2022-04-12 16:27 ` Krzysztof Kozlowski [this message]
2022-04-12 18:38 ` William Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60a9a401-7d1f-5100-7c3d-45452ebfa2ae@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=anand.gore@broadcom.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.beygelman@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=joel.peshkin@broadcom.com \
--cc=krzk+dt@kernel.org \
--cc=kursad.oney@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=samyon.furman@broadcom.com \
--cc=soc@kernel.org \
--cc=tomer.yacoby@broadcom.com \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).