From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 491FFC433EF for ; Tue, 12 Apr 2022 16:28:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241925AbiDLQaX (ORCPT ); Tue, 12 Apr 2022 12:30:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357578AbiDLQaV (ORCPT ); Tue, 12 Apr 2022 12:30:21 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D485D5D5EC for ; Tue, 12 Apr 2022 09:27:57 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id i27so38392365ejd.9 for ; Tue, 12 Apr 2022 09:27:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=NDMWPs4S7zilupRHZRh1G0PStgWMtqHNX86waZCmVE8=; b=dLqmb6kJL5mNPwhuzfsZIOYf5d4DggnddiZ5T1YazUghckPybZmqFE+PE1EBKvLGoI WJLC9SFdCWvTV3ielnSpXSBbtdLZxodidqSypOgcBqEQyxnzI8Y8N+t6+F8VJrV7mGLu ufIm5LiSViEmjJR7el+bjssJ218/plCuY61Q8hsfp1C9xEZpJnx5Jengqphk/6btlNHx nFAEYhMCaySp7kk/buf0tZYPTsPmitigjeJTNE6mNi9fjNezM7a4SYW+P41QzbpE9ZD6 yNI81MAGKHX7EmhPxVGLcyH5OyKtY0IiP7BQFQapa12TpyyXteQdmdOvhyGpHhA2Ls2o VQqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=NDMWPs4S7zilupRHZRh1G0PStgWMtqHNX86waZCmVE8=; b=3w0sMA7O6+D6u8JPj7oJdWN+eFy2zjmqcWOoHlrXd+tMuUtJkXBzy2LyAUTXPOU2m8 59O7Xwx2DZhhOwwBsgTwS4tH9b3FEWz91gfEwZb0z6bagtsPTxNS8fKe5nLLJ64Gme8U BW7v154rh/+IvkKDyrtStm8o7SmWxRo2M2Hn0Frpj0FxQrIJn4ZRsC4qNkJ5SLF8QclJ BXbuFcWGGNpZNXHAYo/+D/RNQiZ3ATglGlKWkFn7C/O3lN9aI9L5TUVHXPrHOC4R+IU3 NVOVUXF53KRbEmG9V7MaTs9QtyAqMd41Aqks8g6IEF1WlWz47deCd/ewCtqrhT4/qQyn oglQ== X-Gm-Message-State: AOAM530knmJJXnkPiS99q0ADA13Osqz05+o8BI1QJPVn8bC59BRkxnGt O31r+kcaVnl/AmgyDkYAQ4/mHg== X-Google-Smtp-Source: ABdhPJxOgxov+X+zXtcd2ayLa52f1FP4vBidDROaYaMLhZJo1c4KNN1Dn13j9jc1Pkv6HT2SJxILKA== X-Received: by 2002:a17:907:e87:b0:6e8:42ef:86d9 with SMTP id ho7-20020a1709070e8700b006e842ef86d9mr22736713ejc.59.1649780876063; Tue, 12 Apr 2022 09:27:56 -0700 (PDT) Received: from [192.168.0.197] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id r29-20020a50c01d000000b00415fb0dc793sm17267681edb.47.2022.04.12.09.27.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Apr 2022 09:27:55 -0700 (PDT) Message-ID: <60a9a401-7d1f-5100-7c3d-45452ebfa2ae@linaro.org> Date: Tue, 12 Apr 2022 18:27:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 3/5] ARM: dts: add dts files for bcmbca soc 47622 Content-Language: en-US To: William Zhang , Broadcom Kernel List Cc: Samyon Furman , Joel Peshkin , Florian Fainelli , Dan Beygelman , Tomer Yacoby , Anand Gore , Kursad Oney , Arnd Bergmann , Krzysztof Kozlowski , Olof Johansson , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, soc@kernel.org References: <20220411172815.20916-1-william.zhang@broadcom.com> <20220411172815.20916-4-william.zhang@broadcom.com> <147e23b6-c5a3-a9fa-c0e1-defe906e42a9@broadcom.com> From: Krzysztof Kozlowski In-Reply-To: <147e23b6-c5a3-a9fa-c0e1-defe906e42a9@broadcom.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/04/2022 17:37, William Zhang wrote: >>> +/ { >>> + compatible = "brcm,bcm47622"; >> >> This does not match your bindings. Even if it is not used. > Did I miss anything? But it matches one of the compatible strings in > brcm,bcmbca.yaml. Your bindings expect that this compatible is followed with "brcm,bcmbca". (...) >>> + periph-bus@ff800000 { >> >> just "bus" to be generic? > This node represents the peripheral bus in the soc. Would prefer to use > the specific name unless it is not allowed by the linux dts. It is allowed but the Devicetree spec explicitly asks for generic names and gives example: bus ("2.2.2 Generic Names Recommendation"). Specific names are discouraged. Best regards, Krzysztof