Re: [PATCH 1/2] dt-bindings: sound: qcom,sm8250: add QRB2210 and RB1 soundcards

[Krzysztof Kozlowski <krzk@kernel.org>]

On 08/10/2025 11:40, Alexey Klimov wrote:
> On Tue Oct 7, 2025 at 2:45 AM BST, Krzysztof Kozlowski wrote:
>> On 07/10/2025 10:26, Alexey Klimov wrote:
>>> Add soundcard compatible for QRB2210 (QCM2290) platforms.
>>> While at this, also add QRB2210 RB1 entry which is set to be
>>> compatible with QRB2210 soundcard.
>>
>>
>> You explained here what you did, but you should explain why. I don't
>> quite get why SoC sound card and RB1 sound card are both needed. I would
>> just go with one.
> 
> 
> I wanted to go with none in the first place and just make it rb2
> sndcard compatible (as a fallback). Then Dmitry suggested to follow other
> sndcards patterns and implmenet it like this.

But this does not match other sound cards either. You add here RB1
compatible, which is not used. Look at SM8750 - the front compatible is
used.

Whatever you decide, please explain in the commit msg the rationale,
because currently it looks different than standard/typical choice.

> 
> There is also at least one qrb2210/qcm2290-based board -- UNO Q and at this
> point I can't say if it will need separate compatble or can use
> qcom,qrb2210-sndcard as a fallback.
> 
> 
>> Please use subject prefixes matching the subsystem. For bindings, the
>> preferred subjects are explained here:
>> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
> 
> So the order in subject should be reversed. Got it.

Not entirely, there is no prefix sound.
`git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is
touching.



Best regards,
Krzysztof