From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Peter Geis <pgwipeout@gmail.com>,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/7] dt-bindings: arm: rockchip: Add Pine64 Quartz64 Model B
Date: Mon, 25 Apr 2022 20:00:47 +0200 [thread overview]
Message-ID: <60db784a-df7c-af2c-5602-bab8462b0223@linaro.org> (raw)
In-Reply-To: <20220425171344.1924057-2-pgwipeout@gmail.com>
On 25/04/2022 19:13, Peter Geis wrote:
> The Quartz64 Model B is a compact single board computer from Pine64
> based on the rk3566 SoC. It outputs on uart2 for the debug console.
>
> Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index eece92f83a2d..d6650a366753 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -507,6 +507,11 @@ properties:
> - const: pine64,quartz64-a
> - const: rockchip,rk3566
>
> + - description: Pine64 Quartz64 Model B
> + items:
> + - const: pine64,quartz64-b
Since it is a single board, not a SoM, this should be rather part of
enum of Model A block.
See also Radxa ROCK Pi entry.
Keeping such approach - each single board in one item of oneOf - makes
the file very, very long...
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-25 18:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 17:13 [PATCH v1 0/7] Add support for several new rk3566 SBCs Peter Geis
2022-04-25 17:13 ` [PATCH v1 1/7] dt-bindings: arm: rockchip: Add Pine64 Quartz64 Model B Peter Geis
2022-04-25 18:00 ` Krzysztof Kozlowski [this message]
2022-04-26 12:16 ` Peter Geis
2022-04-25 17:13 ` [PATCH v1 2/7] dt-bindings: arm: rockchip: Add Pine64 SoQuartz SoM Peter Geis
2022-04-25 18:01 ` Krzysztof Kozlowski
2022-04-25 17:13 ` [PATCH v1 3/7] dt-bindings: arm: rockchip: Add Firefly Station M2 Peter Geis
2022-04-25 18:01 ` Krzysztof Kozlowski
2022-04-25 17:13 ` [PATCH v1 4/7] arm64: dts: rockchip: add rk356x sfc support Peter Geis
2022-04-25 17:13 ` [PATCH v1 5/7] arm64: dts: rockchip: add Pine64 Quartz64-B device tree Peter Geis
2022-04-25 17:13 ` [PATCH v1 6/7] arm64: dts: rockchip: add SoQuartz CM4IO dts Peter Geis
2022-04-25 17:13 ` [PATCH v1 7/7] arm64: dts: rockchip: add dts for Firefly Station M2 rk3566 Peter Geis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60db784a-df7c-af2c-5602-bab8462b0223@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).