From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 364CFC433FE for ; Wed, 16 Nov 2022 09:21:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232134AbiKPJVw (ORCPT ); Wed, 16 Nov 2022 04:21:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230175AbiKPJVv (ORCPT ); Wed, 16 Nov 2022 04:21:51 -0500 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 398E5264AE for ; Wed, 16 Nov 2022 01:21:50 -0800 (PST) Received: by mail-lf1-x12f.google.com with SMTP id c1so28538315lfi.7 for ; Wed, 16 Nov 2022 01:21:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BJGDgjAYzHCIAoX8j9X+fWTaQJQAOPrS/p0kAef7wxk=; b=mONqG2odwNB/ARB8TqLKMmsnA7B9r4RtzDzCL4dTrWPhIpL+hWl+10qbXl06om0viA 0ESHfIhTmuhMlBRdsNtdpkUKM5ebg/XE78C6BcPy+8h6FZfdmqiP52vni3I4IxG7jPl8 qOQmDIBEVmohMeEuB95jnypjds7X3SGSPV+polz9oseF5fV3vCuFdUMTVDnwETHrrWr0 vndpVI0jggOcMjStfg9G12FGcXbJ9ke2U9bsuXO0rhiFyJWeXVtJI4hp8xsPTaDJ4LHg DrCvcHqzLhKR61b5cewymmGG8fArZll1lsttXnFHKcN4kKRTyzcVGEtxqCJ4tMb4MI0k fqjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BJGDgjAYzHCIAoX8j9X+fWTaQJQAOPrS/p0kAef7wxk=; b=HDLqKNHtR6qIcHShmI9S3SJWjyBZXUKueGFNPoP2SdtGElvE1JwEfXGdQCPH7jAnaz gfvVCud6FC+60Ow29LZlkm7JzyDhC7G2tnhFVdGuEnb//4QS+VW2iH/5gAlc8brGV3y2 QNXSCANFRhXWZRm+ZFPSYQdsQ84bHJxxfOUVC4qPbIv1CrXmITPp3JuM/YGzxHVRD5B4 ZPcwTh674DESD7w49A4S3rFYfVzXm5Eclu7WPfEBkA9T4AKh5mtuhb8rbjMN99gFC3vE 3uOldVYVDwPPR8eWMm9HVYF8H273zjrRG64djdyaD3xydy9hQOa8SvKHc9xY7Gfw5Qd2 uhkg== X-Gm-Message-State: ANoB5pmfTfpAY9Cub6XslR+TXposFxvjKqEkp0GNK//hrgEMLgDObgCO CIb3C36HzOW+qnWc2iOwUCWKTQ== X-Google-Smtp-Source: AA0mqf4nQfEaPTARH+N7BGurePdhUCQlFUm5bUoqFbP9cLw0sv+nR0LJaVhlKtPAqmlhccJ75cNTgg== X-Received: by 2002:a05:6512:370e:b0:4a2:4560:61e7 with SMTP id z14-20020a056512370e00b004a2456061e7mr6727723lfr.170.1668590508579; Wed, 16 Nov 2022 01:21:48 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id a22-20020a056512201600b004b48cc444ccsm2399043lfb.100.2022.11.16.01.21.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Nov 2022 01:21:48 -0800 (PST) Message-ID: <60e8ed22-b865-2ba1-1e34-248159746ea6@linaro.org> Date: Wed, 16 Nov 2022 10:21:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 4/9] dt-bindings: Add RISC-V incoming MSI controller bindings Content-Language: en-US To: Conor Dooley Cc: Conor Dooley , Anup Patel , Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Atish Patra , Alistair Francis , Anup Patel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20221111044207.1478350-1-apatel@ventanamicro.com> <20221111044207.1478350-5-apatel@ventanamicro.com> <3037b4f9-268d-df03-380c-393a5d01f3ba@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/11/2022 10:20, Conor Dooley wrote: > On Wed, Nov 16, 2022 at 10:00:27AM +0100, Krzysztof Kozlowski wrote: >> On 15/11/2022 23:34, Conor Dooley wrote: >>> On Mon, Nov 14, 2022 at 05:59:00PM +0530, Anup Patel wrote: >>>> On Sun, Nov 13, 2022 at 8:18 PM Conor Dooley wrote: >>> >>>>> Also, the file name says "riscv,imsic", the description says "IMSIC" but >>>>> you've used "imsics" in the compatible. Is this a typo, or a plural? >>>> >>>> Yes, the file name should be consistent. I will update the file name. >>> >>> Is there a reason why the compatible is plural when all of the other >>> mentions etc do not have an "s"? It really did look like a typo to me. >>> >>> It's the "incoming MSI controller", so I am unsure as to where the "s" >>> actually even comes from. Why not just use "riscv,imsic"? >> >> Yep, should be rather consistent with all others, and IMSIC stands for >> Integrated Circuit? > > Incoming Message Signalled Interrupts Controller, no? Ah, then still singular :) Best regards, Krzysztof