From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH 4/4] arm64: dts: imx93: enable CM33 for 11x11 EVK
Date: Sun, 25 Jun 2023 13:20:08 +0200 [thread overview]
Message-ID: <60efe832-b982-7ea7-abd3-5e9bfd41d064@linaro.org> (raw)
In-Reply-To: <20230625105528.4057850-5-peng.fan@oss.nxp.com>
On 25/06/2023 12:55, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Add reserved memory node for rpmsg
> Enable CM33 node with mailbox property included for doorbell.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
...
> };
>
> reg_vref_1v8: regulator-adc-vref {
> @@ -107,6 +139,16 @@ &lpuart1 { /* console */
> status = "okay";
> };
>
> +&{/remoteproc-cm33} {
That's not proper reference by label.
> + mbox-names = "tx", "rx", "rxdb";
> + mboxes = <&mu1 0 1
> + &mu1 1 1
> + &mu1 3 1>;
Three entries, not one. Anyway, why mboxes depend on the board? This is
quite surprising.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-25 11:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-25 10:55 [PATCH 0/4] arm64: dts: imx93: add thermal/cma/cm33 node Peng Fan (OSS)
2023-06-25 10:55 ` [PATCH 1/4] arm64: dts: imx93: add thermal support Peng Fan (OSS)
2023-06-25 10:55 ` [PATCH 2/4] arm64: dts: imx93: add cma area for i.MX93 11x11 EVK Peng Fan (OSS)
2023-06-25 10:55 ` [PATCH 3/4] arm64: dts: imx93: add cm33 node Peng Fan (OSS)
2023-06-25 10:55 ` [PATCH 4/4] arm64: dts: imx93: enable CM33 for 11x11 EVK Peng Fan (OSS)
2023-06-25 11:20 ` Krzysztof Kozlowski [this message]
2023-06-25 11:23 ` Peng Fan
2023-06-25 11:25 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60efe832-b982-7ea7-abd3-5e9bfd41d064@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).