From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Lamparter Subject: Re: [PATCH 1/2] pinctrl: qcom: ipq4019: add most other IPQ4019 pin functions and groups Date: Sat, 13 May 2017 18:03:24 +0200 Message-ID: <6106539.ylfJifP948@debian64> References: <20170510112712.14744-1-chunkeey@googlemail.com> <20170513001037.tpqdrjh3r6aciskx@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20170513001037.tpqdrjh3r6aciskx@rob-hp-laptop> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linus Walleij , Mark Rutland , Varadarajan Narayanan , Bjorn Andersson , Ram Chandra Jangir , John Crispin List-Id: devicetree@vger.kernel.org On Friday, May 12, 2017 7:10:37 PM CEST Rob Herring wrote: > On Wed, May 10, 2017 at 01:27:11PM +0200, Christian Lamparter wrote: > > This patch adds the remaining pin functions and mux groups. > > It also fixes a typo in the existing binding document. > > > > Cc: Varadarajan Narayanan > > Cc: Bjorn Andersson > > Cc: Ram Chandra Jangir > > Cc: John Crispin > > Signed-off-by: Christian Lamparter > > --- > > Note: These definitions were present in the original submission > > > > > > The DT patch was acked by Rob Herring back then. However, > > I'm not sure if this is still valid or not. @Rob, can you > > please comment? > > Am I supposed to ack patch 1/2 or patch 1/2...? The first one has the > preferred subject prefix. This was my fault. I decided to reword the patch and changed the subject among a few other things. So, this patch was sent to the ML twice. Bjorn commented that he has some comments. Unfortunately, he didn't say what exactly needs to be changed. So, I'm not really sure how to proceed. @Bjorn: can you please tell what you would like to see changed? I see what I can do about it. I do have access two a few IPQ4019/8 and can ask a few people to run tests. @Rob: I noticed that: qcom,apq8064-pinctrl.txt: pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength, qcom,ipq4019-pinctrl.txt: pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength, qcom,ipq8064-pinctrl.txt: pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength, qcom,msm8660-pinctrl.txt: pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength, qcom,msm8974-pinctrl.txt: pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength. all have the same "bias-pull,up". I think I'll just do a separate patch for this to stop it from spreading :D. Thanks, Christian > > > > (Link to Matthew McLintock's v3 that was merged) > > > > --- > > .../bindings/pinctrl/qcom,ipq4019-pinctrl.txt | 36 ++++++++++++++++++++-- > > 1 file changed, 34 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html