From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA15F65F for ; Tue, 12 Mar 2024 01:05:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710205511; cv=none; b=h2Nz7x+4/9yx6ze+qNiJTP1btmF9es1q25349TuT9Ve46vLHBzsbyORSpC4X+ekVdDuijD7hFntYhXv9z/Ix947sDE/0LOxlNBi+QuMHO4WIpEguGwZ2kh2YJSKPROuKH5obTvZF2e8a+Pp2LIvBDVkUFU5v3RL5MBhHbiyjOUM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710205511; c=relaxed/simple; bh=kiqq5+7qC6lpslO5kWCW11x3kemUPM6htnwZ29MLvMg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=a/wk00XjtJOfvYDJbFsHHF/ZXIUYmoGfRVOnUxBmoryUubzC4kX8IQGL7Cdg1+N5RMdvxQKJQ0dEgzrrl4RXJllZ5DyT7ViPOwZpCPSFEn2v2N13O/E3hlqbXP3KLy2MyGG6xqBA4EFINRyK0ZxMRrmGN/RXS5I4THhqXaofEzo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fvOtp4xx; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fvOtp4xx" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-513a6416058so2354448e87.1 for ; Mon, 11 Mar 2024 18:05:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710205507; x=1710810307; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AWlUlgD54M+Av91gLdkhwyiioJ08F7sqNreLTDCTGKg=; b=fvOtp4xx/6hZ9oR5/ceHPtTYHRKatuauXWtLgj3YTkqDyb77NPaP7CQTw7h6LFhKxK ItXKi4rzLICL0VqWhYv3p2UMnvFZS0G6U6HJuOhJuvu8Uje+JENhIfsxQfU3AsAvSrA6 1oCRgVokImXWRqxIGIZXV8LlBU0z7bHlUrJi5jLl8hJqFq3Mu5SB0s6AYdCO0nDqPyGU yIb4pPALLhnz4YQHEGlVSpiU48Doo+kxXRt/vnD0p4PGDv8OsG3mbmLRlj+FHkrVPfiW 4Z4GwOeWL03oBBp55HsxSxCfkdou5B8nbTzD0HnE4jjpXaDabmZb/5Ek7BG7sqdmJzKB Ud/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710205507; x=1710810307; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AWlUlgD54M+Av91gLdkhwyiioJ08F7sqNreLTDCTGKg=; b=DnM5cse5Bua7qHR64VC/Euf4zvfgFjmi9MuvCePe6wMi4r5svI/fDBEWaBk0kpnY/l XTmMBcGp92bfTl4EH1R6/ptgwnl1kY8T21LEwz+suYNJQ1bD1wbrZKS2VhU85mIDCXz1 NxW4xutGgBr7TLtwx4Dc//nxQSfBp7rmtwqK3Fd2B3CTNnJjNvx7LCJByDIEHOPaQ216 3H26HAtcIGroTETJVUOoJNAmn0bNX8po2/R45+WP76SO2D6WcYSsYHMYHpwhMf+neqDa kJ7+bn8GXItFuP8WgY+wzD2uj9T/tss5Ois+cwX1T8sOe+GlTn7ABwWraNZCpZqGy0Oy N2lw== X-Forwarded-Encrypted: i=1; AJvYcCWroXxXGMJ8Dhpw26jVAM5vFNHz22L6UTNwqcb27IdjJwfFESuE0nc3CD5xTlbYzBM6sC1qgT2ViqBHLLiIpYbiuda1TNhfmRu1Xg== X-Gm-Message-State: AOJu0YzvfUiOAktpR/vwut4tkk5P26U6xynS3EL68cFE8//InQpw+Hbm LhdYRcBHU+gFDRecbOm44ATs3gI4jMhOvJWlKkgNmu86L35SIv7+wd00SwRO41Q= X-Google-Smtp-Source: AGHT+IEjePFbUnyVdjlPN5OqGXrY110eXs/oog493hVp9iq9plQNBgZbCsCUqoOBrnsfBdW9+r8XcQ== X-Received: by 2002:a05:6512:4896:b0:513:57fe:97b8 with SMTP id eq22-20020a056512489600b0051357fe97b8mr4992132lfb.26.1710205506953; Mon, 11 Mar 2024 18:05:06 -0700 (PDT) Received: from [172.30.205.61] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id er26-20020a05651248da00b00513a1fe7767sm1040883lfb.209.2024.03.11.18.05.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Mar 2024 18:05:06 -0700 (PDT) Message-ID: <61232fd6-2b76-4ab0-af64-2d49ae405610@linaro.org> Date: Tue, 12 Mar 2024 02:05:05 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/5] soc: qcom: llcc: Add regmap for Broadcast_AND region Content-Language: en-US To: Unnathi Chalicheemala , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com References: From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/23/24 00:07, Unnathi Chalicheemala wrote: > Define new regmap structure for Broadcast_AND region and initialize > this regmap when HW block version is greater than 4.1, otherwise > initialize as a NULL pointer for backwards compatibility. > > Switch from broadcast_OR to broadcast_AND region (when defined in DT) > for checking status bit 1 as Broadcast_OR region checks only for bit 0. > > Signed-off-by: Unnathi Chalicheemala > --- > drivers/soc/qcom/llcc-qcom.c | 15 ++++++++++++++- > include/linux/soc/qcom/llcc-qcom.h | 4 +++- > 2 files changed, 17 insertions(+), 2 deletions(-) > > diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c > index 4ca88eaebf06..cfdc7d9d7773 100644 > --- a/drivers/soc/qcom/llcc-qcom.c > +++ b/drivers/soc/qcom/llcc-qcom.c > @@ -826,6 +826,7 @@ static int llcc_update_act_ctrl(u32 sid, > u32 status_reg; > u32 slice_status; > int ret; > + struct regmap *regmap; Reverse-Christmas-tree, please > > if (IS_ERR(drv_data)) > return PTR_ERR(drv_data); > @@ -849,7 +850,9 @@ static int llcc_update_act_ctrl(u32 sid, > return ret; > > if (drv_data->version >= LLCC_VERSION_4_1_0_0) { > - ret = regmap_read_poll_timeout(drv_data->bcast_regmap, status_reg, > + regmap = (!drv_data->bcast_and_regmap) ? drv_data->bcast_regmap > + : drv_data->bcast_and_regmap; regmap = drv_data->bcast_and_regmap ?: drv_data->bcast_regmap Konrad