From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FD31C433FE for ; Wed, 2 Nov 2022 16:27:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231264AbiKBQ1H (ORCPT ); Wed, 2 Nov 2022 12:27:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231710AbiKBQ0v (ORCPT ); Wed, 2 Nov 2022 12:26:51 -0400 Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E5CF2FC01 for ; Wed, 2 Nov 2022 09:21:47 -0700 (PDT) Received: by mail-qk1-x72f.google.com with SMTP id x18so988324qki.4 for ; Wed, 02 Nov 2022 09:21:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BzdwyCqrWaOcYdqDsje/Pfj4rGdaFiKuTe+sRQfti2U=; b=ykj6NA9kOVg6B0dagTF8Ms+5sjHUjwMU6i1UOEbRl9jMsN5B6v93vKT1wz544nwy9P rGTkpVBuhCsIVfLjNb2INE/3rBcp27rmjRNATD923yOtt6W+/5Yq0e0o7+uZT7fJtm8V gvj2wf1r1lSZj1044EBLOaaBgb8Vh6f5ysJ/xjd0B1Ee2hms5SB+PWUKKeUbcVoBPGR2 fP9Y3Ep4Ygjqiu8G7YUlL9UQIfBJsowwPjd6uBu/LwDhLjDOYRvZkkPGCtVXt2JcT/LR qIU0AunM4TFGfax36gptplY/pmWCoGgROL/gtGRC5MyF0wcfpslo5u4AthrTYATq3sx5 lQCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BzdwyCqrWaOcYdqDsje/Pfj4rGdaFiKuTe+sRQfti2U=; b=fNZ/fgo5RPbSdBG1VuIbXi1VhUDNfyf8r/Jrsqw40AmhTqg4tXmYRgEz0Szi8PsbrZ FyEdQImMZM0nUvZ30KxzFSpT4VRu6TUkIt/z9aFUOpJ3rqgrjiBgVWX+e0VP033MulAJ mPpdnUJxrCo81CTBer0dArbBvcrr7yZtPqHuVTDfv6bNGeH+/e/EAsBZl9doKfTak2s5 zLkbTozOSFoBDFfBNlCrDK+T699b/zrgj8NfSmzxHO0R+E2+e+hHe7/XWsA2FyeBpowi SgYiyUv5O+TVH8IjwV4P0gMdQgMDosVQmG9b5oy77JES7WLsq6N5cdezO0xgjiGUqGRx dchQ== X-Gm-Message-State: ACrzQf1NnsgtX7V2MGcKco2IFKDD1RorI4/q91T6XUllk8Gw78s/1iAH DkT1Gi/DOfTOJ+y/CrmNnsn4wA== X-Google-Smtp-Source: AMsMyM68XM2j+qY6P1wbfbrvGxKf6ZdMXFmcBQMO7RkfWALHDlg8qZREQzzN1RoHrtr7EkQjnb+TFg== X-Received: by 2002:a05:620a:bc3:b0:6ef:418:de91 with SMTP id s3-20020a05620a0bc300b006ef0418de91mr18251614qki.653.1667406106613; Wed, 02 Nov 2022 09:21:46 -0700 (PDT) Received: from ?IPV6:2601:586:5000:570:28d9:4790:bc16:cc93? ([2601:586:5000:570:28d9:4790:bc16:cc93]) by smtp.gmail.com with ESMTPSA id ay30-20020a05620a179e00b006ef1a8f1b81sm8823954qkb.5.2022.11.02.09.21.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 09:21:46 -0700 (PDT) Message-ID: <6130bdbc-163a-c950-e2e1-07ef77124833@linaro.org> Date: Wed, 2 Nov 2022 12:21:44 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 09/11] arm64: dts: qcom: sc8280xp-x13s: Add PM8280_{1/2} VADC channels Content-Language: en-US To: Manivannan Sadhasivam Cc: andersson@kernel.org, konrad.dybcio@somainline.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, johan+linaro@kernel.org, quic_jprakash@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221027063006.9056-1-manivannan.sadhasivam@linaro.org> <20221027063006.9056-10-manivannan.sadhasivam@linaro.org> <5e66c095-898e-067e-1874-a3d2e5babf17@linaro.org> <20221029044831.GC5362@thinkpad> <20221030071659.GE5362@thinkpad> From: Krzysztof Kozlowski In-Reply-To: <20221030071659.GE5362@thinkpad> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 30/10/2022 03:16, Manivannan Sadhasivam wrote: >>> >>>> + reg = ; >>>> + label = "pm8280_1_die_temp"; >>>> + qcom,pre-scaling = <1 1>; >>>> + }; >>>> + >>>> + sys-therm1@144 { >>> >>> I would say sys-therm@... why do we need the "1" suffix in node name? >>> >> >> Suffix represents the index of the thermistor as per the schematics but I guess >> it can be dropped. >> > > I was wrong. Suffix is necessary since IIO core registers the channel based on > the node name, so it has to be unique. > Makes sense then. Best regards, Krzysztof