From: Heiko Stuebner <heiko@sntech.de>
To: Carlos de Paula <me@carlosedp.com>
Cc: papadakospan@gmail.com, jose.abreu@synopsys.com,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
Jonas Karlman <jonas@kwiboo.se>, Peter Geis <pgwipeout@gmail.com>,
Katsuhiro Suzuki <katsuhiro@katsuster.net>,
Johan Jonker <jbx6244@gmail.com>,
Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,
Christoph Muellner <christoph.muellner@theobroma-systems.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Add txpbl node for RK3399/RK3328
Date: Sun, 01 Mar 2020 01:25:16 +0100 [thread overview]
Message-ID: <6132615.msM8OCcsVu@phil> (raw)
In-Reply-To: <20200218221040.10955-1-me@carlosedp.com>
Am Dienstag, 18. Februar 2020, 23:10:37 CET schrieb Carlos de Paula:
> Some rockchip SoCs like the RK3399 and RK3328 exhibit an issue
> where tx checksumming does not work with packets larger than 1498.
>
> The default Programmable Buffer Length for TX in these GMAC's is
> not suitable for MTUs higher than 1498. The workaround is to disable
> TX offloading with 'ethtool -K eth0 tx off rx off' causing performance
> impacts as it disables hardware checksumming.
>
> This patch sets snps,txpbl to 0x4 which is a safe number tested ok for
> the most popular MTU value of 1500.
>
> For reference, see https://lkml.org/lkml/2019/4/1/1382.
>
> Signed-off-by: Carlos de Paula <me@carlosedp.com>
applied for 5.7
Thanks
Heiko
next prev parent reply other threads:[~2020-03-01 0:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 22:10 [PATCH] arm64: dts: rockchip: Add txpbl node for RK3399/RK3328 Carlos de Paula
2020-03-01 0:25 ` Heiko Stuebner [this message]
2020-03-01 2:06 ` Leonidas P.
2020-03-01 8:22 ` Daniel Lezcano
2020-03-01 9:02 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6132615.msM8OCcsVu@phil \
--to=heiko@sntech.de \
--cc=christoph.muellner@theobroma-systems.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=jbx6244@gmail.com \
--cc=jonas@kwiboo.se \
--cc=jose.abreu@synopsys.com \
--cc=katsuhiro@katsuster.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=me@carlosedp.com \
--cc=papadakospan@gmail.com \
--cc=pgwipeout@gmail.com \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).