* [PATCH] ASoC: dt-bindings: nau8821: Convert to dtschema
@ 2023-06-28 8:50 Seven Lee
2023-06-28 9:38 ` Rob Herring
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Seven Lee @ 2023-06-28 8:50 UTC (permalink / raw)
To: broonie
Cc: lgirdwood, robh+dt, krzysztof.kozlowski+dt, conor+dt, alsa-devel,
devicetree, linux-kernel, YHCHuang, KCHSU0, CTLIN0, WTLI, SJLIN0,
scott6986, supercraig0719, dardar923, Seven Lee
Convert the NAU8821 audio CODEC bindings to DT schema.
Signed-off-by: Seven Lee <wtli@nuvoton.com>
---
.../devicetree/bindings/sound/nau8821.txt | 55 --------
.../bindings/sound/nuvoton,nau8821.yaml | 125 ++++++++++++++++++
2 files changed, 125 insertions(+), 55 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/sound/nau8821.txt
create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
diff --git a/Documentation/devicetree/bindings/sound/nau8821.txt b/Documentation/devicetree/bindings/sound/nau8821.txt
deleted file mode 100644
index 7c84e7c7327a..000000000000
--- a/Documentation/devicetree/bindings/sound/nau8821.txt
+++ /dev/null
@@ -1,55 +0,0 @@
-Nuvoton NAU88L21 audio codec
-
-This device supports I2C only.
-
-Required properties:
- - compatible : Must be "nuvoton,nau8821"
-
- - reg : the I2C address of the device. This is either 0x1B (CSB=0) or 0x54 (CSB=1).
-
-Optional properties:
- - nuvoton,jkdet-enable: Enable jack detection via JKDET pin.
- - nuvoton,jkdet-pull-enable: Enable JKDET pin pull. If set - pin pull enabled,
- otherwise pin in high impedance state.
- - nuvoton,jkdet-pull-up: Pull-up JKDET pin. If set then JKDET pin is pull up, otherwise pull down.
- - nuvoton,jkdet-polarity: JKDET pin polarity. 0 - active high, 1 - active low.
-
- - nuvoton,vref-impedance: VREF Impedance selection
- 0 - Open
- 1 - 25 kOhm
- 2 - 125 kOhm
- 3 - 2.5 kOhm
-
- - nuvoton,micbias-voltage: Micbias voltage level.
- 0 - VDDA
- 1 - VDDA
- 2 - VDDA * 1.1
- 3 - VDDA * 1.2
- 4 - VDDA * 1.3
- 5 - VDDA * 1.4
- 6 - VDDA * 1.53
- 7 - VDDA * 1.53
-
- - nuvoton,jack-insert-debounce: number from 0 to 7 that sets debounce time to 2^(n+2) ms
- - nuvoton,jack-eject-debounce: number from 0 to 7 that sets debounce time to 2^(n+2) ms
-
- - nuvoton,dmic-clk-threshold: the ADC threshold of DMIC clock.
- - nuvoton,key_enable: Headset button detection switch.
-
-Example:
-
- headset: nau8821@1b {
- compatible = "nuvoton,nau8821";
- reg = <0x1b>;
- interrupt-parent = <&gpio>;
- interrupts = <23 IRQ_TYPE_LEVEL_LOW>;
- nuvoton,jkdet-enable;
- nuvoton,jkdet-pull-enable;
- nuvoton,jkdet-pull-up;
- nuvoton,jkdet-polarity = <GPIO_ACTIVE_LOW>;
- nuvoton,vref-impedance = <2>;
- nuvoton,micbias-voltage = <6>;
- nuvoton,jack-insert-debounce = <7>;
- nuvoton,jack-eject-debounce = <7>;
- nuvoton,dmic-clk-threshold = 3072000;
- };
diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
new file mode 100644
index 000000000000..fc2f4ce4db88
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
@@ -0,0 +1,125 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/nuvoton,nau8821.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NAU88L21 audio codec
+
+maintainers:
+ - Seven Lee <wtli@nuvoton.com>
+
+allOf:
+ - $ref: dai-common.yaml#
+
+properties:
+ compatible:
+ const: nuvoton,nau8821
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ nuvoton,jkdet-enable:
+ description: Enable jack detection via JKDET pin.
+ type: boolean
+
+ nuvoton,jkdet-pull-enable:
+ description: Enable JKDET pin pull. If set - pin pull enabled,
+ otherwise pin in high impedance state.
+ type: boolean
+
+ nuvoton,jkdet-pull-up:
+ description: Pull-up JKDET pin. If set then JKDET pin is pull up,
+ otherwise pull down.
+ type: boolean
+
+ nuvoton,key-enable:
+ description: handles key press detection.
+ type: boolean
+
+ nuvoton,jkdet-polarity:
+ description: JKDET pin polarity.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ enum:
+ - 0 # active high
+ - 1 # active low
+ default: 1
+
+ nuvoton,micbias-voltage:
+ description: MICBIAS output level select.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ enum:
+ - 0 # VDDA
+ - 1 # VDDA * 1
+ - 2 # VDDA * 1.1
+ - 3 # VDDA * 1.2
+ - 4 # VDDA * 1.3
+ - 5 # VDDA * 1.4
+ - 6 # VDDA * 1.53
+ - 7 # VDDA * 1.53
+ default: 6
+
+ nuvoton,vref-impedance:
+ description: VMID Tie-off impedance select.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ enum:
+ - 0 # open
+ - 1 # 25KOhms
+ - 2 # 125KOhms
+ - 3 # 2.5KOhms
+ default: 2
+
+ nuvoton,jack-insert-debounce:
+ description: number from 0 to 7 that sets debounce time to 2^(n+2)ms.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ maximum: 7
+ default: 7
+
+ nuvoton,jack-eject-debounce:
+ description: number from 0 to 7 that sets debounce time to 2^(n+2)ms.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ maximum: 7
+ default: 0
+
+ nuvoton,dmic-clk-threshold:
+ description: DMIC clock speed expected value. Unit is Hz.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ default: 3072000
+
+ '#sound-dai-cells':
+ const: 0
+
+required:
+ - compatible
+ - reg
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ codec@1b {
+ compatible = "nuvoton,nau8821";
+ reg = <0x1b>;
+ interrupt-parent = <&gpio>;
+ interrupts = <23 IRQ_TYPE_LEVEL_LOW>;
+ nuvoton,jkdet-enable;
+ nuvoton,jkdet-pull-enable;
+ nuvoton,jkdet-pull-up;
+ nuvoton,key-enable;
+ nuvoton,jkdet-polarity = <GPIO_ACTIVE_LOW>;
+ nuvoton,micbias-voltage = <6>;
+ nuvoton,vref-impedance = <2>;
+ nuvoton,jack-insert-debounce = <7>;
+ nuvoton,jack-eject-debounce = <0>;
+ nuvoton,dmic-clk-threshold = <3072000>;
+ #sound-dai-cells = <0>;
+ };
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] ASoC: dt-bindings: nau8821: Convert to dtschema
2023-06-28 8:50 [PATCH] ASoC: dt-bindings: nau8821: Convert to dtschema Seven Lee
@ 2023-06-28 9:38 ` Rob Herring
2023-06-28 15:44 ` Rob Herring
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2023-06-28 9:38 UTC (permalink / raw)
To: Seven Lee
Cc: robh+dt, alsa-devel, scott6986, supercraig0719, broonie,
linux-kernel, WTLI, devicetree, CTLIN0, KCHSU0, dardar923,
YHCHuang, SJLIN0, lgirdwood, krzysztof.kozlowski+dt, conor+dt
On Wed, 28 Jun 2023 16:50:09 +0800, Seven Lee wrote:
> Convert the NAU8821 audio CODEC bindings to DT schema.
>
> Signed-off-by: Seven Lee <wtli@nuvoton.com>
> ---
> .../devicetree/bindings/sound/nau8821.txt | 55 --------
> .../bindings/sound/nuvoton,nau8821.yaml | 125 ++++++++++++++++++
> 2 files changed, 125 insertions(+), 55 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/sound/nau8821.txt
> create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/clock/milbeaut-clock.example.dtb: /example-2/serial@1e700010: failed to match any schema with compatible: ['socionext,milbeaut-usio-uart']
Documentation/devicetree/bindings/clock/sprd,sc9863a-clk.example.dtb: /example-1/syscon@20e00000: failed to match any schema with compatible: ['sprd,sc9863a-glbregs', 'syscon', 'simple-mfd']
Documentation/devicetree/bindings/leds/common.example.dtb: /example-2/i2c/led-controller@30: failed to match any schema with compatible: ['panasonic,an30259a']
Documentation/devicetree/bindings/sound/audio-graph-card2.example.dtb: /example-0/cpu: failed to match any schema with compatible: ['cpu-driver']
Documentation/devicetree/bindings/sound/audio-graph-card2.example.dtb: /example-0/codec: failed to match any schema with compatible: ['codec-driver']
Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.example.dtb: /example-0/avs-monitor@7d5d2000: failed to match any schema with compatible: ['brcm,bcm2711-avs-monitor', 'syscon', 'simple-mfd']
Documentation/devicetree/bindings/thermal/imx-thermal.example.dtb: /example-0/anatop@20c8000: failed to match any schema with compatible: ['fsl,imx6q-anatop', 'syscon', 'simple-mfd']
Documentation/devicetree/bindings/i2c/qcom,i2c-cci.example.dtb: /example-0/cci@ac4a000/i2c-bus@1/camera@60: failed to match any schema with compatible: ['ovti,ov7251']
Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dtb: /example-0/pmic: failed to match any schema with compatible: ['ti,twl6035-pmic', 'ti,palmas-pmic']
Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dtb: /example-0/pmic: failed to match any schema with compatible: ['ti,twl6035-pmic', 'ti,palmas-pmic']
Documentation/devicetree/bindings/input/mediatek,pmic-keys.example.dtb: /example-0/pmic: failed to match any schema with compatible: ['mediatek,mt6397']
Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.example.dtb: /example-0/pmic@0: failed to match any schema with compatible: ['sprd,sc2731']
Documentation/devicetree/bindings/dma/dma-controller.example.dtb: /example-0/dma-controller@48000000: failed to match any schema with compatible: ['ti,omap-sdma']
Documentation/devicetree/bindings/dma/dma-router.example.dtb: /example-0/dma-router@4a002b78: failed to match any schema with compatible: ['ti,dra7-dma-crossbar']
Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.example.dtb: /example-0/memory-controller@13410000/ethernet@6: failed to match any schema with compatible: ['davicom,dm9000']
Documentation/devicetree/bindings/arm/hisilicon/controller/hi3798cv200-perictrl.example.dtb: /example-0/peripheral-controller@8a20000/phy@850: failed to match any schema with compatible: ['hisilicon,hi3798cv200-combphy']
Documentation/devicetree/bindings/arm/hisilicon/controller/sysctrl.example.dtb: /example-0/system-controller@802000/clock@0: failed to match any schema with compatible: ['hisilicon,hi3620-clock']
Documentation/devicetree/bindings/arm/hisilicon/controller/cpuctrl.example.dtb: /example-0/cpuctrl@a22000/clock@0: failed to match any schema with compatible: ['hisilicon,hix5hd2-clock']
Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: /example-0/parent/i2c/camera@36: failed to match any schema with compatible: ['ovti,ov5695']
Documentation/devicetree/bindings/net/marvell,mvusb.example.dtb: /example-0/usb/mdio@1/switch@0: failed to match any schema with compatible: ['marvell,mv88e6190']
Documentation/devicetree/bindings/net/qca,ar71xx.example.dtb: /example-0/ethernet@1a000000/mdio/switch@10: failed to match any schema with compatible: ['qca,ar9331-switch']
Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.example.dtb: /example-0/iomcu@ffd7e000: failed to match any schema with compatible: ['hisilicon,hi3660-iomcu', 'syscon']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230628085009.1130318-1-wtli@nuvoton.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] ASoC: dt-bindings: nau8821: Convert to dtschema
2023-06-28 8:50 [PATCH] ASoC: dt-bindings: nau8821: Convert to dtschema Seven Lee
2023-06-28 9:38 ` Rob Herring
@ 2023-06-28 15:44 ` Rob Herring
2023-07-02 20:18 ` Krzysztof Kozlowski
2023-07-12 11:46 ` Mark Brown
3 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2023-06-28 15:44 UTC (permalink / raw)
To: Seven Lee
Cc: linux-kernel, supercraig0719, dardar923, broonie, WTLI, robh+dt,
krzysztof.kozlowski+dt, SJLIN0, lgirdwood, KCHSU0, YHCHuang,
CTLIN0, scott6986, alsa-devel, devicetree, conor+dt
On Wed, 28 Jun 2023 16:50:09 +0800, Seven Lee wrote:
> Convert the NAU8821 audio CODEC bindings to DT schema.
>
> Signed-off-by: Seven Lee <wtli@nuvoton.com>
> ---
> .../devicetree/bindings/sound/nau8821.txt | 55 --------
> .../bindings/sound/nuvoton,nau8821.yaml | 125 ++++++++++++++++++
> 2 files changed, 125 insertions(+), 55 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/sound/nau8821.txt
> create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ASoC: dt-bindings: nau8821: Convert to dtschema
2023-06-28 8:50 [PATCH] ASoC: dt-bindings: nau8821: Convert to dtschema Seven Lee
2023-06-28 9:38 ` Rob Herring
2023-06-28 15:44 ` Rob Herring
@ 2023-07-02 20:18 ` Krzysztof Kozlowski
2023-07-12 11:46 ` Mark Brown
3 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-02 20:18 UTC (permalink / raw)
To: Seven Lee, broonie
Cc: lgirdwood, robh+dt, krzysztof.kozlowski+dt, conor+dt, alsa-devel,
devicetree, linux-kernel, YHCHuang, KCHSU0, CTLIN0, SJLIN0,
scott6986, supercraig0719, dardar923
On 28/06/2023 10:50, Seven Lee wrote:
> Convert the NAU8821 audio CODEC bindings to DT schema.
>
> Signed-off-by: Seven Lee <wtli@nuvoton.com>
> ---
This is not v1. Please write proper changelog and version your patches.
You did not respond to my comment and you did not fully implement it.
With lack of changelog it looks like it was ignored
Please fix everything I asked about.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ASoC: dt-bindings: nau8821: Convert to dtschema
2023-06-28 8:50 [PATCH] ASoC: dt-bindings: nau8821: Convert to dtschema Seven Lee
` (2 preceding siblings ...)
2023-07-02 20:18 ` Krzysztof Kozlowski
@ 2023-07-12 11:46 ` Mark Brown
3 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2023-07-12 11:46 UTC (permalink / raw)
To: Seven Lee
Cc: lgirdwood, robh+dt, krzysztof.kozlowski+dt, conor+dt, alsa-devel,
devicetree, linux-kernel, YHCHuang, KCHSU0, CTLIN0, WTLI, SJLIN0,
scott6986, supercraig0719, dardar923
On Wed, 28 Jun 2023 16:50:09 +0800, Seven Lee wrote:
> Convert the NAU8821 audio CODEC bindings to DT schema.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: dt-bindings: nau8821: Convert to dtschema
commit: 754d1ce3ab6bec057bf94b0ec1a789fdfa2fef99
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] ASoC: dt-bindings: nau8821: Convert to dtschema
@ 2023-06-26 10:46 Seven Lee
2023-06-27 6:31 ` Krzysztof Kozlowski
0 siblings, 1 reply; 9+ messages in thread
From: Seven Lee @ 2023-06-26 10:46 UTC (permalink / raw)
To: broonie
Cc: lgirdwood, robh+dt, krzysztof.kozlowski+dt, conor+dt, alsa-devel,
devicetree, linux-kernel, YHCHuang, KCHSU0, CTLIN0, WTLI, SJLIN0,
scott6986, supercraig0719, dardar923, Seven Lee
Convert the NAU8821 audio CODEC bindings to DT schema.
Signed-off-by: Seven Lee <wtli@nuvoton.com>
---
.../devicetree/bindings/sound/nau8821.txt | 55 --------
.../bindings/sound/nuvoton,nau8821.yaml | 120 ++++++++++++++++++
2 files changed, 120 insertions(+), 55 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/sound/nau8821.txt
create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
diff --git a/Documentation/devicetree/bindings/sound/nau8821.txt b/Documentation/devicetree/bindings/sound/nau8821.txt
deleted file mode 100644
index 7c84e7c7327a..000000000000
--- a/Documentation/devicetree/bindings/sound/nau8821.txt
+++ /dev/null
@@ -1,55 +0,0 @@
-Nuvoton NAU88L21 audio codec
-
-This device supports I2C only.
-
-Required properties:
- - compatible : Must be "nuvoton,nau8821"
-
- - reg : the I2C address of the device. This is either 0x1B (CSB=0) or 0x54 (CSB=1).
-
-Optional properties:
- - nuvoton,jkdet-enable: Enable jack detection via JKDET pin.
- - nuvoton,jkdet-pull-enable: Enable JKDET pin pull. If set - pin pull enabled,
- otherwise pin in high impedance state.
- - nuvoton,jkdet-pull-up: Pull-up JKDET pin. If set then JKDET pin is pull up, otherwise pull down.
- - nuvoton,jkdet-polarity: JKDET pin polarity. 0 - active high, 1 - active low.
-
- - nuvoton,vref-impedance: VREF Impedance selection
- 0 - Open
- 1 - 25 kOhm
- 2 - 125 kOhm
- 3 - 2.5 kOhm
-
- - nuvoton,micbias-voltage: Micbias voltage level.
- 0 - VDDA
- 1 - VDDA
- 2 - VDDA * 1.1
- 3 - VDDA * 1.2
- 4 - VDDA * 1.3
- 5 - VDDA * 1.4
- 6 - VDDA * 1.53
- 7 - VDDA * 1.53
-
- - nuvoton,jack-insert-debounce: number from 0 to 7 that sets debounce time to 2^(n+2) ms
- - nuvoton,jack-eject-debounce: number from 0 to 7 that sets debounce time to 2^(n+2) ms
-
- - nuvoton,dmic-clk-threshold: the ADC threshold of DMIC clock.
- - nuvoton,key_enable: Headset button detection switch.
-
-Example:
-
- headset: nau8821@1b {
- compatible = "nuvoton,nau8821";
- reg = <0x1b>;
- interrupt-parent = <&gpio>;
- interrupts = <23 IRQ_TYPE_LEVEL_LOW>;
- nuvoton,jkdet-enable;
- nuvoton,jkdet-pull-enable;
- nuvoton,jkdet-pull-up;
- nuvoton,jkdet-polarity = <GPIO_ACTIVE_LOW>;
- nuvoton,vref-impedance = <2>;
- nuvoton,micbias-voltage = <6>;
- nuvoton,jack-insert-debounce = <7>;
- nuvoton,jack-eject-debounce = <7>;
- nuvoton,dmic-clk-threshold = 3072000;
- };
diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
new file mode 100644
index 000000000000..728223d20876
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
@@ -0,0 +1,120 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/nuvoton,nau8821.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NAU88L21 audio codec
+
+maintainers:
+ - Seven Lee <wtli@nuvoton.com>
+
+allOf:
+ - $ref: dai-common.yaml#
+
+properties:
+ compatible:
+ const: nuvoton,nau8821
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ nuvoton,jkdet-enable:
+ description: Enable jack detection via JKDET pin.
+ type: boolean
+
+ nuvoton,jkdet-pull-enable:
+ description: Enable JKDET pin pull. If set - pin pull enabled,
+ otherwise pin in high impedance state.
+ type: boolean
+
+ nuvoton,jkdet-pull-up:
+ description: Pull-up JKDET pin. If set then JKDET pin is pull up,
+ otherwise pull down.
+ type: boolean
+
+ nuvoton,jkdet-polarity:
+ description: JKDET pin polarity.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ enum:
+ - 0 # active high
+ - 1 # active low
+ default: 1
+
+ nuvoton,micbias-voltage:
+ description: MICBIAS output level select.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ enum:
+ - 0 # VDDA
+ - 1 # VDDA * 1
+ - 2 # VDDA * 1.1
+ - 3 # VDDA * 1.2
+ - 4 # VDDA * 1.3
+ - 5 # VDDA * 1.4
+ - 6 # VDDA * 1.53
+ - 7 # VDDA * 1.53
+ default: 6
+
+ nuvoton,vref-impedance:
+ description: VMID Tie-off impedance select.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ enum:
+ - 0 # open(default)
+ - 1 # 25KOhms
+ - 2 # 125KOhms
+ - 3 # 2.5KOhms
+ default: 2
+
+ nuvoton,jack-insert-debounce:
+ description: number from 0 to 7 that sets debounce time to 2^(n+2)ms.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ maximum: 7
+ default: 7
+
+ nuvoton,jack-eject-debounce:
+ description: number from 0 to 7 that sets debounce time to 2^(n+2)ms.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ maximum: 7
+ default: 0
+
+ nuvoton,dmic-clk-threshold:
+ description: DMIC clock speed expected value. Unit is Hz.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ default: 3072000
+
+ '#sound-dai-cells':
+ const: 0
+
+required:
+ - compatible
+ - reg
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ codec@1b {
+ #sound-dai-cells = <0>;
+ compatible = "nuvoton,nau8821";
+ reg = <0x1b>;
+ interrupt-parent = <&gpio>;
+ interrupts = <23 IRQ_TYPE_LEVEL_LOW>;
+ nuvoton,jkdet-enable;
+ nuvoton,jkdet-pull-enable;
+ nuvoton,jkdet-pull-up;
+ nuvoton,jkdet-polarity = <GPIO_ACTIVE_LOW>;
+ nuvoton,micbias-voltage = <6>;
+ nuvoton,vref-impedance = <2>;
+ nuvoton,jack-insert-debounce = <7>;
+ nuvoton,jack-eject-debounce = <0>;
+ nuvoton,dmic-clk-threshold = <3072000>;
+ };
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] ASoC: dt-bindings: nau8821: Convert to dtschema
2023-06-26 10:46 Seven Lee
@ 2023-06-27 6:31 ` Krzysztof Kozlowski
0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-27 6:31 UTC (permalink / raw)
To: Seven Lee, broonie
Cc: lgirdwood, robh+dt, krzysztof.kozlowski+dt, conor+dt, alsa-devel,
devicetree, linux-kernel, YHCHuang, KCHSU0, CTLIN0, SJLIN0,
scott6986, supercraig0719, dardar923
On 26/06/2023 12:46, Seven Lee wrote:
> Convert the NAU8821 audio CODEC bindings to DT schema.
>
> Signed-off-by: Seven Lee <wtli@nuvoton.com>
> ---
Thank you for your patch. There is something to discuss/improve.
> +
> + nuvoton,jkdet-pull-up:
> + description: Pull-up JKDET pin. If set then JKDET pin is pull up,
> + otherwise pull down.
> + type: boolean
> +
> + nuvoton,jkdet-polarity:
> + description: JKDET pin polarity.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum:
> + - 0 # active high
> + - 1 # active low
> + default: 1
> +
> + nuvoton,micbias-voltage:
> + description: MICBIAS output level select.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum:
> + - 0 # VDDA
> + - 1 # VDDA * 1
> + - 2 # VDDA * 1.1
> + - 3 # VDDA * 1.2
> + - 4 # VDDA * 1.3
> + - 5 # VDDA * 1.4
> + - 6 # VDDA * 1.53
> + - 7 # VDDA * 1.53
> + default: 6
> +
> + nuvoton,vref-impedance:
> + description: VMID Tie-off impedance select.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum:
> + - 0 # open(default)
Drop "(default)"
> + - 1 # 25KOhms
> + - 2 # 125KOhms
> + - 3 # 2.5KOhms
> + default: 2
You wrote that default is 0
> +
> + nuvoton,jack-insert-debounce:
> + description: number from 0 to 7 that sets debounce time to 2^(n+2)ms.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + maximum: 7
> + default: 7
> +
> + nuvoton,jack-eject-debounce:
> + description: number from 0 to 7 that sets debounce time to 2^(n+2)ms.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + maximum: 7
> + default: 0
> +
> + nuvoton,dmic-clk-threshold:
> + description: DMIC clock speed expected value. Unit is Hz.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + default: 3072000
> +
You miss nuvoton,key_enable. If this is intentional, mention and shortly
explain deviations from pure conversion in the commit msg.
> + '#sound-dai-cells':
> + const: 0
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + codec@1b {
> + #sound-dai-cells = <0>;
> + compatible = "nuvoton,nau8821";
> + reg = <0x1b>;
compatible is first property, reg is second. Therefore put
sound-dai-cells somewhere further.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <20230621093903.1077050-1-wtli@nuvoton.com>]
* Re: [PATCH] ASoC: dt-bindings: nau8821: Convert to dtschema
[not found] <20230621093903.1077050-1-wtli@nuvoton.com>
@ 2023-06-21 18:13 ` Mark Brown
2023-06-22 8:33 ` Krzysztof Kozlowski
0 siblings, 1 reply; 9+ messages in thread
From: Mark Brown @ 2023-06-21 18:13 UTC (permalink / raw)
To: Seven Lee
Cc: lgirdwood, alsa-devel, YHCHuang, KCHSU0, CTLIN0, SJLIN0,
scott6986, supercraig0719, dardar923, devicetree
[-- Attachment #1: Type: text/plain, Size: 6784 bytes --]
On Wed, Jun 21, 2023 at 05:39:03PM +0800, Seven Lee wrote:
> Convert the NAU8821 audio CODEC bindings to DT schema.
This wasn't sent to the DT list or maintainers, it should be in order to
ensure they can review it. Copying in the list and leaving the whole
message for context.
>
> Signed-off-by: Seven Lee <wtli@nuvoton.com>
> ---
> .../devicetree/bindings/sound/nau8821.txt | 55 --------
> .../bindings/sound/nuvoton,nau8821.yaml | 120 ++++++++++++++++++
> 2 files changed, 120 insertions(+), 55 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/sound/nau8821.txt
> create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/nau8821.txt b/Documentation/devicetree/bindings/sound/nau8821.txt
> deleted file mode 100644
> index 7c84e7c7327a..000000000000
> --- a/Documentation/devicetree/bindings/sound/nau8821.txt
> +++ /dev/null
> @@ -1,55 +0,0 @@
> -Nuvoton NAU88L21 audio codec
> -
> -This device supports I2C only.
> -
> -Required properties:
> - - compatible : Must be "nuvoton,nau8821"
> -
> - - reg : the I2C address of the device. This is either 0x1B (CSB=0) or 0x54 (CSB=1).
> -
> -Optional properties:
> - - nuvoton,jkdet-enable: Enable jack detection via JKDET pin.
> - - nuvoton,jkdet-pull-enable: Enable JKDET pin pull. If set - pin pull enabled,
> - otherwise pin in high impedance state.
> - - nuvoton,jkdet-pull-up: Pull-up JKDET pin. If set then JKDET pin is pull up, otherwise pull down.
> - - nuvoton,jkdet-polarity: JKDET pin polarity. 0 - active high, 1 - active low.
> -
> - - nuvoton,vref-impedance: VREF Impedance selection
> - 0 - Open
> - 1 - 25 kOhm
> - 2 - 125 kOhm
> - 3 - 2.5 kOhm
> -
> - - nuvoton,micbias-voltage: Micbias voltage level.
> - 0 - VDDA
> - 1 - VDDA
> - 2 - VDDA * 1.1
> - 3 - VDDA * 1.2
> - 4 - VDDA * 1.3
> - 5 - VDDA * 1.4
> - 6 - VDDA * 1.53
> - 7 - VDDA * 1.53
> -
> - - nuvoton,jack-insert-debounce: number from 0 to 7 that sets debounce time to 2^(n+2) ms
> - - nuvoton,jack-eject-debounce: number from 0 to 7 that sets debounce time to 2^(n+2) ms
> -
> - - nuvoton,dmic-clk-threshold: the ADC threshold of DMIC clock.
> - - nuvoton,key_enable: Headset button detection switch.
> -
> -Example:
> -
> - headset: nau8821@1b {
> - compatible = "nuvoton,nau8821";
> - reg = <0x1b>;
> - interrupt-parent = <&gpio>;
> - interrupts = <23 IRQ_TYPE_LEVEL_LOW>;
> - nuvoton,jkdet-enable;
> - nuvoton,jkdet-pull-enable;
> - nuvoton,jkdet-pull-up;
> - nuvoton,jkdet-polarity = <GPIO_ACTIVE_LOW>;
> - nuvoton,vref-impedance = <2>;
> - nuvoton,micbias-voltage = <6>;
> - nuvoton,jack-insert-debounce = <7>;
> - nuvoton,jack-eject-debounce = <7>;
> - nuvoton,dmic-clk-threshold = 3072000;
> - };
> diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
> new file mode 100644
> index 000000000000..728223d20876
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
> @@ -0,0 +1,120 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/nuvoton,nau8821.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NAU88L21 audio codec
> +
> +maintainers:
> + - Seven Lee <wtli@nuvoton.com>
> +
> +allOf:
> + - $ref: dai-common.yaml#
> +
> +properties:
> + compatible:
> + const: nuvoton,nau8821
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + nuvoton,jkdet-enable:
> + description: Enable jack detection via JKDET pin.
> + type: boolean
> +
> + nuvoton,jkdet-pull-enable:
> + description: Enable JKDET pin pull. If set - pin pull enabled,
> + otherwise pin in high impedance state.
> + type: boolean
> +
> + nuvoton,jkdet-pull-up:
> + description: Pull-up JKDET pin. If set then JKDET pin is pull up,
> + otherwise pull down.
> + type: boolean
> +
> + nuvoton,jkdet-polarity:
> + description: JKDET pin polarity.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum:
> + - 0 # active high
> + - 1 # active low
> + default: 1
> +
> + nuvoton,micbias-voltage:
> + description: MICBIAS output level select.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum:
> + - 0 # VDDA
> + - 1 # VDDA * 1
> + - 2 # VDDA * 1.1
> + - 3 # VDDA * 1.2
> + - 4 # VDDA * 1.3
> + - 5 # VDDA * 1.4
> + - 6 # VDDA * 1.53
> + - 7 # VDDA * 1.53
> + default: 6
> +
> + nuvoton,vref-impedance:
> + description: VMID Tie-off impedance select.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum:
> + - 0 # open(default)
> + - 1 # 25KOhms
> + - 2 # 125KOhms
> + - 3 # 2.5KOhms
> + default: 2
> +
> + nuvoton,jack-insert-debounce:
> + description: number from 0 to 7 that sets debounce time to 2^(n+2)ms.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + maximum: 7
> + default: 7
> +
> + nuvoton,jack-eject-debounce:
> + description: number from 0 to 7 that sets debounce time to 2^(n+2)ms.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + maximum: 7
> + default: 0
> +
> + nuvoton,dmic-clk-threshold:
> + description: DMIC clock speed expected value. Unit is Hz.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + default: 3072000
> +
> + '#sound-dai-cells':
> + const: 0
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + codec@1b {
> + #sound-dai-cells = <0>;
> + compatible = "nuvoton,nau8821";
> + reg = <0x1b>;
> + interrupt-parent = <&gpio>;
> + interrupts = <23 IRQ_TYPE_LEVEL_LOW>;
> + nuvoton,jkdet-enable;
> + nuvoton,jkdet-pull-enable;
> + nuvoton,jkdet-pull-up;
> + nuvoton,jkdet-polarity = <GPIO_ACTIVE_LOW>;
> + nuvoton,micbias-voltage = <6>;
> + nuvoton,vref-impedance = <2>;
> + nuvoton,jack-insert-debounce = <7>;
> + nuvoton,jack-eject-debounce = <0>;
> + nuvoton,dmic-clk-threshold = <3072000>;
> + };
> + };
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] ASoC: dt-bindings: nau8821: Convert to dtschema
2023-06-21 18:13 ` Mark Brown
@ 2023-06-22 8:33 ` Krzysztof Kozlowski
0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-22 8:33 UTC (permalink / raw)
To: Mark Brown, Seven Lee
Cc: lgirdwood, alsa-devel, YHCHuang, KCHSU0, CTLIN0, SJLIN0,
scott6986, supercraig0719, dardar923, devicetree
On 21/06/2023 20:13, Mark Brown wrote:
> On Wed, Jun 21, 2023 at 05:39:03PM +0800, Seven Lee wrote:
>> Convert the NAU8821 audio CODEC bindings to DT schema.
>
> This wasn't sent to the DT list or maintainers, it should be in order to
> ensure they can review it. Copying in the list and leaving the whole
> message for context.
Thanks.
DT list is being used for testing the patches, so this has to be resend
following get_maintainers.pl output.
Seven,
You already got such feedback before, so it's a repeat of same mistake
in the process. Use tools to automate such tasks, so the process is
being followed without need for additional steps.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-07-12 11:46 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-28 8:50 [PATCH] ASoC: dt-bindings: nau8821: Convert to dtschema Seven Lee
2023-06-28 9:38 ` Rob Herring
2023-06-28 15:44 ` Rob Herring
2023-07-02 20:18 ` Krzysztof Kozlowski
2023-07-12 11:46 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2023-06-26 10:46 Seven Lee
2023-06-27 6:31 ` Krzysztof Kozlowski
[not found] <20230621093903.1077050-1-wtli@nuvoton.com>
2023-06-21 18:13 ` Mark Brown
2023-06-22 8:33 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).