From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Naresh Solanki <naresh.solanki@9elements.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Patrick Rudolph <patrick.rudolph@9elements.com>
Cc: Marcello Sylvester Bauer <sylv@sylv.io>
Subject: Re: [PATCH v6 1/2] dt-bindings: mfd: Add bindings for MAX5970 and MAX5978
Date: Thu, 3 Nov 2022 14:01:49 -0400 [thread overview]
Message-ID: <613d7971-37d6-c8db-523e-cf3cbdcd5287@linaro.org> (raw)
In-Reply-To: <dc6c8f79-9830-dd1b-a064-3b25a3b74a35@9elements.com>
On 03/11/2022 13:53, Naresh Solanki wrote:
> Hi Krzysztof,
>
> On 03-11-2022 06:43 pm, Krzysztof Kozlowski wrote:
>>> +examples:
>>> + - |
>>> + i2c {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + regulator@3a {
>>> + compatible = "maxim,max5978";
>>> + reg = <0x3a>;
>>> + vss1-supply = <&p3v3>;
>>> +
>>> + regulators {
>>> + sw0_ref_0: SW0 {
>> No improvements here.
> I've addressed 4 space indentation, bindings are matched, compatible is
> moved to first, then reg then the rest.
OK, so indeed there are improvements.
Yet still you did not improve the warnings coming from the binding -
this does not match your binding. Test the binding and you will see big
fat warning.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-03 18:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 8:05 [PATCH v6 0/2] mfd: max597x: Add support for max597x Naresh Solanki
2022-11-03 8:05 ` [PATCH v6 1/2] dt-bindings: mfd: Add bindings for MAX5970 and MAX5978 Naresh Solanki
2022-11-03 12:35 ` Rob Herring
2022-11-03 13:13 ` Krzysztof Kozlowski
2022-11-03 17:53 ` Naresh Solanki
2022-11-03 18:01 ` Krzysztof Kozlowski [this message]
2022-11-03 18:20 ` Naresh Solanki
2022-11-03 20:26 ` Krzysztof Kozlowski
2022-11-03 21:33 ` Naresh Solanki
2022-11-03 8:05 ` [PATCH v6 2/2] mfd: max597x: Add support " Naresh Solanki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=613d7971-37d6-c8db-523e-cf3cbdcd5287@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naresh.solanki@9elements.com \
--cc=patrick.rudolph@9elements.com \
--cc=robh+dt@kernel.org \
--cc=sylv@sylv.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).