From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92336C4332F for ; Thu, 3 Nov 2022 18:04:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229587AbiKCSE4 (ORCPT ); Thu, 3 Nov 2022 14:04:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230194AbiKCSEL (ORCPT ); Thu, 3 Nov 2022 14:04:11 -0400 Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 405F623BE3 for ; Thu, 3 Nov 2022 11:01:52 -0700 (PDT) Received: by mail-qk1-x735.google.com with SMTP id k2so1659534qkk.7 for ; Thu, 03 Nov 2022 11:01:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=b6lzWnndPEx47JNYnBGGhAjHV67Tdq93TKvJyHkVGpU=; b=DViLWviJRNiRKOZurROMuetripDeQl1g19sw3T0TpCXaliobtAcUpHInTkjSEZib9D 7MkOjvKLSFviFdXN+hq26Fa5jwANIC5E0nvuHZMsH1ZMn4+BH7MWbRHQW/RwCVq6WX1f oYlqXdDmpAXr9dMLKOlPFXsohahRnHVSfZ/5JnhN2gEAOapUL85ILJoN+Cc9GICOlsuV 5SnIbPzuMXfe4Njcg3+x/kXixf6qYP3BXBlHlHybmibb4qqkdZSY4b8lvmT1wjB3fmWr reAyQsiNMRFxuqCzOkiT41wiOdztpQybVWUX3E5LxJsoTndf6ejCMr2bhS71rXNrXpOk 4X3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b6lzWnndPEx47JNYnBGGhAjHV67Tdq93TKvJyHkVGpU=; b=Yc+QvrGJQsg2RZxsu5VTZNVs4Bq+XR7kq96z6VgdPaJ1rdnlHO4H0T3RvjAL4QQIBB abx32l3O02nOpBCR1afoORR4xe5pCa0aOGlKEiEa/UNPmy6+LGuiPF9Vb2ZWtYghNPvD FWQu4D6b4RaH24VQOha0Utj0pU4gyHH5UToPLVZAfxKsEgDsIbhccG55E4wNzXn+2t/u CG6Wb6Yc7cE+pDIy4A7qx3jEeSS8hOVBmu+JXrl0y/hFsP8hO3lexkFLxINufAloCF45 IoI+VmYDkZBRdOkKqjf7VP1MZHrlCgaiw5I6WBaXDgPXC1hCyIP//wbXFai/TvewhX00 Of5Q== X-Gm-Message-State: ACrzQf1PaRRMFt7Nitue3DdMIWtYHKjM/kZ+2F5oscqNPM1RqRQ5/Y0Z inkVtCXG6QsyX/wcON3U2/2ZEg== X-Google-Smtp-Source: AMsMyM7TEv/8Z00e6YSXU/dDrn8qkVeUkqCQmw0hY0PNeKAia77RHB8u/EgrArZ2PPcHaORZnrqD3g== X-Received: by 2002:a05:620a:28cc:b0:6ee:78fe:c519 with SMTP id l12-20020a05620a28cc00b006ee78fec519mr21850553qkp.345.1667498511178; Thu, 03 Nov 2022 11:01:51 -0700 (PDT) Received: from ?IPV6:2601:586:5000:570:a35d:9f85:e3f7:d9fb? ([2601:586:5000:570:a35d:9f85:e3f7:d9fb]) by smtp.gmail.com with ESMTPSA id fy5-20020a05622a5a0500b003a533886612sm926956qtb.3.2022.11.03.11.01.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 11:01:50 -0700 (PDT) Message-ID: <613d7971-37d6-c8db-523e-cf3cbdcd5287@linaro.org> Date: Thu, 3 Nov 2022 14:01:49 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v6 1/2] dt-bindings: mfd: Add bindings for MAX5970 and MAX5978 Content-Language: en-US To: Naresh Solanki , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Lee Jones , Rob Herring , Krzysztof Kozlowski , Patrick Rudolph Cc: Marcello Sylvester Bauer References: <20221103080545.1400424-1-Naresh.Solanki@9elements.com> <20221103080545.1400424-2-Naresh.Solanki@9elements.com> <0c23e569-61e1-3eba-f9fc-4b42ed228b52@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/11/2022 13:53, Naresh Solanki wrote: > Hi Krzysztof, > > On 03-11-2022 06:43 pm, Krzysztof Kozlowski wrote: >>> +examples: >>> + - | >>> + i2c { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + regulator@3a { >>> + compatible = "maxim,max5978"; >>> + reg = <0x3a>; >>> + vss1-supply = <&p3v3>; >>> + >>> + regulators { >>> + sw0_ref_0: SW0 { >> No improvements here. > I've addressed 4 space indentation, bindings are matched, compatible is > moved to first, then reg then the rest. OK, so indeed there are improvements. Yet still you did not improve the warnings coming from the binding - this does not match your binding. Test the binding and you will see big fat warning. Best regards, Krzysztof