Re: [PATCH v2 4/9] drm/panthor: Implement optional reset

Marek Vasut
2025-09-28T16:57:07Z

On 9/28/25 10:24 AM, Rain Yang wrote:
> On Fri, Sep 26, 2025 at 03:32:46PM +0200, Marek Vasut wrote:
>> On 9/26/25 11:18 AM, Rain Yang wrote:
>>
>> Hello Jiyu,
>>
>>>>> as the 0x4d810008 is a write-once register and whose operation has been moved into the SM side,
>>>>> so please drop the reset change.
>>>>> can you also change the label of the gpu node from gpu to mali like "mali: gpu@4d900000",
>>>>> as the internal driver use mali label to control the thermal up/low limitation.
>>>>
>>>> I updated all of the AHAB container, imx-oei and imx-sm components, and the
>>>> reset controller is no longer needed indeed.
>>>
>>> thanks, please update the gpu node label if possibly.
>>
>> Which label do you refer to, and which one would you prefer to have there ?
>
> "mali: gpu@4d900000", not "gpu: gpu@4d900000".
All of imx*.dts* use gpu: or gpu2d:/gpu3d:/vpuvg: for the GPU label.

I see allwinner does use mali: label, but maybe it would be better to
stay consistent with the i.MX labels ?

Also, variants of gpu: label seems more popular:

linux$ grep -hro '[a-z0-9_]\+: gpu@' arch/ | sort | uniq -c
3 adreno_gpu: gpu@
1 bb2d: gpu@
1 gpu2d: gpu@
1 gpu3d: gpu@
80 gpu: gpu@
4 gpu_2d: gpu@
1 gpu_3d0: gpu@
4 gpu_3d: gpu@
6 gpu_mem: gpu@
1 gpu_reserved: gpu@
2 gpu_vg: gpu@
17 mali: gpu@
1 v3d: gpu@
2 zap_shader_region: gpu@