From: Wei Xu <xuwei5@hisilicon.com>
To: Michael Walle <michael@walle.cc>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] arm64: dts: hisilicon: fix arm,sp805 compatible string
Date: Sat, 18 Sep 2021 17:25:24 +0800 [thread overview]
Message-ID: <6145B084.6020803@hisilicon.com> (raw)
In-Reply-To: <20210830165113.222867-1-michael@walle.cc>
Hi Michael,
On 2021/8/31 0:51, Michael Walle wrote:
> According to Documentation/devicetree/bindings/watchdog/arm,sp805.yaml
> the compatible is:
> compatible = "arm,sp805", "arm,primecell";
>
> The current compatible string doesn't exist at all. Fix it.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
Applied to the HiSilicon arm64 dt tree.
Thanks!
Best Regards,
Wei
> ---
> There are also the layerscape SoC which are using these compatible
> strings. I'm on it to change these, too.
>
> arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 4 ++--
> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> index 2d5c1a348716..6eabec2602e2 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> @@ -1087,7 +1087,7 @@ dwmmc2: dwmmc2@ff3ff000 {
> };
>
> watchdog0: watchdog@e8a06000 {
> - compatible = "arm,sp805-wdt", "arm,primecell";
> + compatible = "arm,sp805", "arm,primecell";
> reg = <0x0 0xe8a06000 0x0 0x1000>;
> interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&crg_ctrl HI3660_OSC32K>,
> @@ -1096,7 +1096,7 @@ watchdog0: watchdog@e8a06000 {
> };
>
> watchdog1: watchdog@e8a07000 {
> - compatible = "arm,sp805-wdt", "arm,primecell";
> + compatible = "arm,sp805", "arm,primecell";
> reg = <0x0 0xe8a07000 0x0 0x1000>;
> interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&crg_ctrl HI3660_OSC32K>,
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index dde9371dc545..e4860b8a638e 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -840,7 +840,7 @@ dwmmc_2: dwmmc2@f723f000 {
> };
>
> watchdog0: watchdog@f8005000 {
> - compatible = "arm,sp805-wdt", "arm,primecell";
> + compatible = "arm,sp805", "arm,primecell";
> reg = <0x0 0xf8005000 0x0 0x1000>;
> interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&ao_ctrl HI6220_WDT0_PCLK>,
>
prev parent reply other threads:[~2021-09-18 9:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 16:51 [PATCH] arm64: dts: hisilicon: fix arm,sp805 compatible string Michael Walle
2021-09-18 9:25 ` Wei Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6145B084.6020803@hisilicon.com \
--to=xuwei5@hisilicon.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).