From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Johan Hovold <johan+linaro@kernel.org>, Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/13] phy: qcom-qmp-usb: fix sc8280xp PCS_USB offset
Date: Mon, 24 Oct 2022 16:32:53 +0300 [thread overview]
Message-ID: <614b03b7-e6ff-bdad-449c-b84f840b2e1f@linaro.org> (raw)
In-Reply-To: <20221024100632.20549-2-johan+linaro@kernel.org>
On 24/10/2022 13:06, Johan Hovold wrote:
> The PCS_USB register block lives at an offset of 0x1000 from the PCS
> region on SC8280XP so add the missing offset to avoid corrupting
> unrelated registers on runtime suspend.
>
> Note that the current binding is broken as it does not describe the
> PCS_USB region and the PCS register size does not cover PCS_USB and the
> regions in between. As Linux currently maps full pages, simply adding
> the offset to driver works until the binding has been fixed.
>
> Fixes: c0c7769cdae2 ("phy: qcom-qmp: Add SC8280XP USB3 UNI phy")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
> drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2022-10-24 19:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 10:06 [PATCH 00/13] phy: qcom-qmp-usb: fix sc8280xp binding Johan Hovold
2022-10-24 10:06 ` [PATCH 01/13] phy: qcom-qmp-usb: fix sc8280xp PCS_USB offset Johan Hovold
2022-10-24 13:32 ` Dmitry Baryshkov [this message]
2022-10-24 10:06 ` [PATCH 02/13] phy: qcom-qmp-usb: sort device-id table Johan Hovold
2022-10-24 13:33 ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 03/13] phy: qcom-qmp-usb: move " Johan Hovold
2022-10-24 13:33 ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 04/13] phy: qcom-qmp-usb: move pm ops Johan Hovold
2022-10-24 13:33 ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 05/13] phy: qcom-qmp-usb: merge driver data Johan Hovold
2022-10-24 13:33 ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 06/13] phy: qcom-qmp-usb: clean up device-tree parsing Johan Hovold
2022-10-24 13:34 ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 07/13] phy: qcom-qmp-usb: clean up probe initialisation Johan Hovold
2022-10-24 13:34 ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 08/13] phy: qcom-qmp-usb: rename PHY ops structure Johan Hovold
2022-10-24 13:34 ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 09/13] phy: qcom-qmp-usb: clean up PHY init Johan Hovold
2022-10-24 13:34 ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 10/13] dt-bindings: phy: qcom,qmp-usb: rename current bindings Johan Hovold
2022-10-28 2:12 ` Krzysztof Kozlowski
2022-10-24 10:06 ` [PATCH 11/13] dt-bindings: phy: qcom,qmp-usb: fix sc8280xp binding Johan Hovold
2022-10-28 2:15 ` Krzysztof Kozlowski
2022-10-28 6:09 ` Johan Hovold
2022-10-28 6:13 ` Johan Hovold
2022-10-28 13:05 ` Vinod Koul
2022-10-24 10:06 ` [PATCH 12/13] phy: qcom-qmp-usb: restructure PHY creation Johan Hovold
2022-10-24 13:35 ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 13/13] phy: qcom-qmp-usb: add support for updated sc8280xp binding Johan Hovold
2022-10-24 13:35 ` Dmitry Baryshkov
2022-10-24 13:38 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=614b03b7-e6ff-bdad-449c-b84f840b2e1f@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).