From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78131C38A2D for ; Mon, 24 Oct 2022 19:50:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233453AbiJXTsv (ORCPT ); Mon, 24 Oct 2022 15:48:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233480AbiJXTs3 (ORCPT ); Mon, 24 Oct 2022 15:48:29 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3E6596235 for ; Mon, 24 Oct 2022 11:14:21 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id r22so13821869ljn.10 for ; Mon, 24 Oct 2022 11:14:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2xaMm78fM2rUZsQPmBvYXK97To/2DK/rtGwK+0qiEt0=; b=r0gnmUhcfoDGmqHuXWVGnOZ8m4Vp2E9CRPBUM3zSGQ0+v3W6eCljPT1bVvefZLqlqN CGqHJtZZLjGOgMNOIzZDNUye2auuKVXnxEvNaDglhe+BOT4HQj37jr3Ot/fI3gvN1ByX M/d7ZLuzCaSqlvDb2NgSQDH0Mh+QStyVva74R/oPhm4lBYRxLQGKRQiX9EOjbGqDjPWx upfpa2Ybp5OkLnYWBBT7X9QSv/EJ5+ZvUANae+mqQdmPjY2P96gPAWAxOJUyklj5bRyk Qr6x+4tcHzVmHvcnPyOt+9PKe8Eyx8J7tdoTraqOIHakQI+MOCd/N4Vtv4/ic2g7wa8w UDfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2xaMm78fM2rUZsQPmBvYXK97To/2DK/rtGwK+0qiEt0=; b=No3ouSIEbqgISp69DZHx+MVltYMBfQFzdIP1hsgBek3Tr/QN+qgbfdwM4oHxZnt2Y6 8xnsf0nFfd9WCr3moJiz3nTXY0kT7QGjisaC88/Nh+1Jiyvr8q1kWcinopPRq0OP0kAg /BWaIoWLcUeqEyFyOmostE+3Mx9E0XrRXGLPsuc0V/M1+IGsuTyAMsjXqvRgApaL+JHW QCHpmplKnjEvXoXLAoRlwqI41gSg30H9uI79gqDhcYX/u8CSGKh4rSEX4jbYGp1sjuHB WylZVKzdSyFWDpnkvjy2gjlQ4kRn3MQQpX8euxHzNG8G9iUJ7dCJM3FspweW/Fl1TWMM V+cg== X-Gm-Message-State: ACrzQf1+7IrOA/cnFe/4kX3/bAbG2poUp1XXi0Tvk2udEhkSDjmMv+3v 3tKWdBkjW1vuOL6+wAGXJ9ZBw1DP9X6EdnAo X-Google-Smtp-Source: AMsMyM58S+kwJjzf/AcosLQEKY92VlM/X/zNBCksGzwTStER3W9096fbJUbGcKmYoC1waiUXkJ7OAQ== X-Received: by 2002:a05:651c:1950:b0:26f:ec78:6178 with SMTP id bs16-20020a05651c195000b0026fec786178mr11284200ljb.98.1666618374256; Mon, 24 Oct 2022 06:32:54 -0700 (PDT) Received: from [10.10.15.130] ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id i11-20020ac2522b000000b00499bf7605afsm4545272lfl.143.2022.10.24.06.32.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Oct 2022 06:32:53 -0700 (PDT) Message-ID: <614b03b7-e6ff-bdad-449c-b84f840b2e1f@linaro.org> Date: Mon, 24 Oct 2022 16:32:53 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH 01/13] phy: qcom-qmp-usb: fix sc8280xp PCS_USB offset Content-Language: en-GB To: Johan Hovold , Vinod Koul Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221024100632.20549-1-johan+linaro@kernel.org> <20221024100632.20549-2-johan+linaro@kernel.org> From: Dmitry Baryshkov In-Reply-To: <20221024100632.20549-2-johan+linaro@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 24/10/2022 13:06, Johan Hovold wrote: > The PCS_USB register block lives at an offset of 0x1000 from the PCS > region on SC8280XP so add the missing offset to avoid corrupting > unrelated registers on runtime suspend. > > Note that the current binding is broken as it does not describe the > PCS_USB region and the PCS register size does not cover PCS_USB and the > regions in between. As Linux currently maps full pages, simply adding > the offset to driver works until the binding has been fixed. > > Fixes: c0c7769cdae2 ("phy: qcom-qmp: Add SC8280XP USB3 UNI phy") > Signed-off-by: Johan Hovold > --- > drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry