From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Verkuil Subject: Re: [PATCH 3/5] media: sunxi: Add A10 CSI driver Date: Tue, 13 Nov 2018 16:39:42 +0100 Message-ID: <6153b08e-b81d-8e4a-9fd2-0f593523d8da@cisco.com> References: <71d315a34e4b12b0eb1d4c9003b297e46695f9cf.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <71d315a34e4b12b0eb1d4c9003b297e46695f9cf.camel@perches.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Joe Perches , Hans Verkuil , Maxime Ripard , Hans Verkuil , Sakari Ailus , Mauro Carvalho Chehab Cc: Thomas Petazzoni , Laurent Pinchart , linux-media@vger.kernel.org, Andrzej Hajda , Chen-Yu Tsai , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Mark Rutland , Rob Herring , Frank Rowand List-Id: devicetree@vger.kernel.org On 11/13/18 16:19, Joe Perches wrote: > On Tue, 2018-11-13 at 13:24 +0100, Hans Verkuil wrote: >> On 11/13/18 09:24, Maxime Ripard wrote: >>> The older CSI drivers have camera capture interface different from the one >>> in the newer ones. > [] >>> diff --git a/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.h b/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.h > [] >>> + // Videobuf2 >> >> Doesn't checkpatch.pl --strict complain about the use of '//'? > > No, not since > > commit dadf680de3c2eb4cba9840619991eda0cfe98778 > Author: Joe Perches > Date: Tue Aug 2 14:04:33 2016 -0700 > > checkpatch: allow c99 style // comments > > Sanitise the lines that contain c99 comments so that the error doesn't > get emitted. > > Huh, I'm really out of date. But the good news is that I learned something new today! Thank you, Hans