From: Arnd Bergmann <arnd@arndb.de>
To: James Liao <jamesjj.liao@mediatek.com>
Cc: linux-arm-kernel@lists.infradead.org,
kbuild test robot <lkp@intel.com>,
srv_heupstream@mediatek.com, devicetree@vger.kernel.org,
Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
kbuild-all@01.org, Sascha Hauer <kernel@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: Move vendor's Kconfig into CCF menu section
Date: Wed, 27 Jan 2016 11:32:29 +0100 [thread overview]
Message-ID: <6167008.u8jfFpmfhy@wuerfel> (raw)
In-Reply-To: <1453888578.28646.7.camel@mtksdaap41>
On Wednesday 27 January 2016 17:56:18 James Liao wrote:
> >
> > I think you should include this change in your patch, or as a preparation.
> > All other samsung platforms already select COMMON_CLK through ARCH_MULTIPLATFORM,
> > and all SoCs that are part of ARCH_S3C24XX individually select a symbol that
> > selects COMMON_CLK.
>
> Oops, I didn't notice there are warnings after moving these Kconfigs
> into menu section.
>
> The original motivation of this patch is preventing new clk drivers
> include their Kconfig in a wrong place, so it's not critical. Do you
> think we should apply this patch (with your changes below) or drop this
> patch directly?
I think your patch is good, we just need to fix S3C24xx, which is doing
things in a strange way for historic reasons.
Arnd
next prev parent reply other threads:[~2016-01-27 10:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 7:26 [PATCH] clk: Move vendor's Kconfig into CCF menu section James Liao
2016-01-27 9:18 ` kbuild test robot
[not found] ` <201601271708.gQUxXACW%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-01-27 9:27 ` Arnd Bergmann
2016-01-27 9:56 ` James Liao
2016-01-27 10:32 ` Arnd Bergmann [this message]
2016-01-28 8:36 ` Stephen Boyd
2016-01-28 11:31 ` Arnd Bergmann
[not found] ` <1453879563-39500-1-git-send-email-jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2016-01-27 10:25 ` kbuild test robot
2016-01-27 14:48 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6167008.u8jfFpmfhy@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=jamesjj.liao@mediatek.com \
--cc=kbuild-all@01.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lkp@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox