Re: [PATCH 05/12] MIPS: GIC: Add device-tree support

Andrew Bresticker
2014-08-31T18:42:14Z

On Sat, Aug 30, 2014 at 12:54 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 29 August 2014 15:14:32 Andrew Bresticker wrote:
>> Add device-tree support for the MIPS GIC. With DT, no per-platform
>> static device interrupt mapping is supplied and instead all device
>> interrupts are specified through the DT. The GIC-to-CPU interrupts
>> must also be specified in the DT.
>>
>> Platforms using DT-based probing of the GIC need only supply the
>> GIC_NUM_INTRS and, if necessary, MIPS_GIC_IRQ_BASE values and
>> call of_irq_init() with an of_device_id table including the GIC.
>>
>> Currenlty only legacy and vecotred interrupt modes are supported.
>>
>> Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
>> ---
>> arch/mips/include/asm/gic.h | 15 ++++++
>> arch/mips/kernel/irq-gic.c | 122 +++++++++++++++++++++++++++++++++++++++++++-
>>
>
>
> Can you move this to drivers/irqchip and use the IRQCHIP_DECLARE()
> macro to define the entry point?

Sure. I was planning on doing this later, but I don't see why it
couldn't be done now though.