* [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport
2025-11-20 10:58 [PATCH 0/2] Enable lt8713sx bridge with displayport for monaco-evk Vishnu Saini
@ 2025-11-20 10:58 ` Vishnu Saini
2025-11-20 12:11 ` Konrad Dybcio
` (2 more replies)
0 siblings, 3 replies; 28+ messages in thread
From: Vishnu Saini @ 2025-11-20 10:58 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Vishnu Saini,
prahlad.valluru, Prahlad Valluru, Vishnu Saini
Monaco-evk has LT8713sx which act as DP to 3 DP output
converter. Edp PHY from monaco soc is connected to lt8713sx
as input and output of lt8713sx is connected to 3 mini DP ports.
Two of these ports are available in mainboard and one port
is available on Mezz board. lt8713sx is connected to soc over
i2c0 and with reset gpio connected to pin6 or ioexpander5.
Enable the edp nodes from monaco and enable lontium lt8713sx
bridge node.
Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/monaco-evk.dts | 44 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
index bb35893da73d..947807f8a9cb 100644
--- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
+++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
@@ -317,6 +317,20 @@ &gpu_zap_shader {
firmware-name = "qcom/qcs8300/a623_zap.mbn";
};
+&i2c0 {
+ pinctrl-0 = <&qup_i2c0_default>;
+ pinctrl-names = "default";
+
+ status = "okay";
+
+ lt8713sx: lt8713sx@4f {
+ /*Display bridge chip, DP1.4/HDMI2.0/DP++ hub*/
+ compatible = "lontium,lt8713sx";
+ reg = <0x4f>;
+ reset-gpios = <&expander5 6 GPIO_ACTIVE_HIGH>;
+ };
+};
+
&i2c1 {
pinctrl-0 = <&qup_i2c1_default>;
pinctrl-names = "default";
@@ -396,6 +410,23 @@ expander6: gpio@3e {
};
};
+&mdss {
+ status = "okay";
+};
+
+&mdss_dp0 {
+ status = "okay";
+};
+
+&mdss_dp0_out {
+ data-lanes = <0 1 2 3>;
+ link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+};
+
+&mdss_dp0_phy {
+ status = "okay";
+};
+
&iris {
status = "okay";
};
@@ -435,6 +466,12 @@ &serdes0 {
};
&tlmm {
+ dp_hot_plug_det: dp-hot-plug-det-state {
+ pins = "gpio94";
+ function = "edp0_hot";
+ bias-disable;
+ };
+
ethernet0_default: ethernet0-default-state {
ethernet0_mdc: ethernet0-mdc-pins {
pins = "gpio5";
@@ -451,6 +488,13 @@ ethernet0_mdio: ethernet0-mdio-pins {
};
};
+ qup_i2c0_default: qup-i2c0-state {
+ pins = "gpio17", "gpio18";
+ function = "qup0_se0";
+ drive-strength = <2>;
+ bias-pull-up;
+ };
+
qup_i2c1_default: qup-i2c1-state {
pins = "gpio19", "gpio20";
function = "qup0_se1";
--
2.34.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport
2025-11-20 10:58 ` [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport Vishnu Saini
@ 2025-11-20 12:11 ` Konrad Dybcio
2025-12-19 11:20 ` Vishnu Saini
2025-11-20 14:26 ` Bjorn Andersson
2025-11-24 10:46 ` kernel test robot
2 siblings, 1 reply; 28+ messages in thread
From: Konrad Dybcio @ 2025-11-20 12:11 UTC (permalink / raw)
To: Vishnu Saini, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Vishnu Saini,
prahlad.valluru, Prahlad Valluru
On 11/20/25 11:58 AM, Vishnu Saini wrote:
> Monaco-evk has LT8713sx which act as DP to 3 DP output
> converter. Edp PHY from monaco soc is connected to lt8713sx
> as input and output of lt8713sx is connected to 3 mini DP ports.
> Two of these ports are available in mainboard and one port
> is available on Mezz board. lt8713sx is connected to soc over
> i2c0 and with reset gpio connected to pin6 or ioexpander5.
>
> Enable the edp nodes from monaco and enable lontium lt8713sx
> bridge node.
>
> Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> ---
[...]
> +&i2c0 {
> + pinctrl-0 = <&qup_i2c0_default>;
> + pinctrl-names = "default";
> +
> + status = "okay";
> +
> + lt8713sx: lt8713sx@4f {
Node names should be generic, so bridge@4f
> + /*Display bridge chip, DP1.4/HDMI2.0/DP++ hub*/
Comment start/stop markers should have a space after/before them
respectively, however I'm not sure this comment is useful given the
dt-bindings already describe what it is
[...]
> &tlmm {
> + dp_hot_plug_det: dp-hot-plug-det-state {
> + pins = "gpio94";
> + function = "edp0_hot";
> + bias-disable;
This is an SoC-mandated function on the pin, so please move it to
monaco.dtsi
> + };
> +
> ethernet0_default: ethernet0-default-state {
> ethernet0_mdc: ethernet0-mdc-pins {
> pins = "gpio5";
> @@ -451,6 +488,13 @@ ethernet0_mdio: ethernet0-mdio-pins {
> };
> };
>
> + qup_i2c0_default: qup-i2c0-state {
> + pins = "gpio17", "gpio18";
> + function = "qup0_se0";
> + drive-strength = <2>;
> + bias-pull-up;
Similarly, you can move these settings to monaco.dtsi and keep them as
defaults since 99.99% of I2C users will share them
Konrad
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport
2025-11-20 10:58 ` [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport Vishnu Saini
2025-11-20 12:11 ` Konrad Dybcio
@ 2025-11-20 14:26 ` Bjorn Andersson
2025-12-19 11:24 ` Vishnu Saini
2025-11-24 10:46 ` kernel test robot
2 siblings, 1 reply; 28+ messages in thread
From: Bjorn Andersson @ 2025-11-20 14:26 UTC (permalink / raw)
To: Vishnu Saini
Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-msm, devicetree, linux-kernel, Vishnu Saini,
prahlad.valluru, Prahlad Valluru
On Thu, Nov 20, 2025 at 04:28:05PM +0530, Vishnu Saini wrote:
> Monaco-evk has LT8713sx which act as DP to 3 DP output
> converter. Edp PHY from monaco soc is connected to lt8713sx
> as input and output of lt8713sx is connected to 3 mini DP ports.
> Two of these ports are available in mainboard and one port
> is available on Mezz board. lt8713sx is connected to soc over
> i2c0 and with reset gpio connected to pin6 or ioexpander5.
>
This is good, you're describing the role of LT8713sx and how it's
connected on the board. Thank you for taking the time to do so!
I think one aspect that's worth pointing out on its own is the
placement of the mini DP ports. You do capture it, but the fact that
we have two on the EVK and one on the expansion board is "hidden" there
in the middle of the paragraph.
I think extracting this part of the message into its own paragraph would
improve the commit message further.
> Enable the edp nodes from monaco and enable lontium lt8713sx
> bridge node.
>
> Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/monaco-evk.dts | 44 ++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> index bb35893da73d..947807f8a9cb 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> @@ -317,6 +317,20 @@ &gpu_zap_shader {
> firmware-name = "qcom/qcs8300/a623_zap.mbn";
> };
>
Would it be possible to add dp-connector nodes and wire them up to the
<8713sx, like I did in sa8295-adp.dts?
> +&i2c0 {
> + pinctrl-0 = <&qup_i2c0_default>;
> + pinctrl-names = "default";
> +
> + status = "okay";
> +
> + lt8713sx: lt8713sx@4f {
This should be bridge@4f.
Also, unless we need to reference this from a overlay there's no need to
give it a label.
> + /*Display bridge chip, DP1.4/HDMI2.0/DP++ hub*/
This comment explains what "lontium,lt8713sx" is. The binding call tell
me that, so the value of this comment would be for you to tell us what
it is used for on this particular board - and if that's obvious you can
omit the comment.
> + compatible = "lontium,lt8713sx";
> + reg = <0x4f>;
> + reset-gpios = <&expander5 6 GPIO_ACTIVE_HIGH>;
In addition to using an of_graph to describe the connectors that this is
wired to, it would be nice to have a port describing the relationship to
the DP controller here as well - so we know where the signal is coming
from.
Would that be possible to add?
Regards,
Bjorn
> + };
> +};
> +
> &i2c1 {
> pinctrl-0 = <&qup_i2c1_default>;
> pinctrl-names = "default";
> @@ -396,6 +410,23 @@ expander6: gpio@3e {
> };
> };
>
> +&mdss {
> + status = "okay";
> +};
> +
> +&mdss_dp0 {
> + status = "okay";
> +};
> +
> +&mdss_dp0_out {
> + data-lanes = <0 1 2 3>;
> + link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
> +};
> +
> +&mdss_dp0_phy {
> + status = "okay";
> +};
> +
> &iris {
> status = "okay";
> };
> @@ -435,6 +466,12 @@ &serdes0 {
> };
>
> &tlmm {
> + dp_hot_plug_det: dp-hot-plug-det-state {
> + pins = "gpio94";
> + function = "edp0_hot";
> + bias-disable;
> + };
> +
> ethernet0_default: ethernet0-default-state {
> ethernet0_mdc: ethernet0-mdc-pins {
> pins = "gpio5";
> @@ -451,6 +488,13 @@ ethernet0_mdio: ethernet0-mdio-pins {
> };
> };
>
> + qup_i2c0_default: qup-i2c0-state {
> + pins = "gpio17", "gpio18";
> + function = "qup0_se0";
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> +
> qup_i2c1_default: qup-i2c1-state {
> pins = "gpio19", "gpio20";
> function = "qup0_se1";
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport
2025-11-20 10:58 ` [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport Vishnu Saini
2025-11-20 12:11 ` Konrad Dybcio
2025-11-20 14:26 ` Bjorn Andersson
@ 2025-11-24 10:46 ` kernel test robot
2 siblings, 0 replies; 28+ messages in thread
From: kernel test robot @ 2025-11-24 10:46 UTC (permalink / raw)
To: Vishnu Saini, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: oe-kbuild-all, linux-arm-msm, devicetree, linux-kernel,
Vishnu Saini, prahlad.valluru, Prahlad Valluru
Hi Vishnu,
kernel test robot noticed the following build errors:
[auto build test ERROR on 3c3d81183061b9e49dd3207fbbbc36314744bf3f]
url: https://github.com/intel-lab-lkp/linux/commits/Vishnu-Saini/arm64-dts-qcom-monaco-add-lt8713sx-bridge-with-displayport/20251120-190522
base: 3c3d81183061b9e49dd3207fbbbc36314744bf3f
patch link: https://lore.kernel.org/r/20251120-lt8713sx-bridge-linux-for-next-v1-1-2246fc5fb490%40qti.qualcomm.com
patch subject: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20251124/202511241826.Maela061-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251124/202511241826.Maela061-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511241826.Maela061-lkp@intel.com/
All errors (new ones prefixed by >>):
Error: arch/arm64/boot/dts/qcom/monaco-evk.dts:413.1-6 Label or path mdss not found
Error: arch/arm64/boot/dts/qcom/monaco-evk.dts:417.1-10 Label or path mdss_dp0 not found
Error: arch/arm64/boot/dts/qcom/monaco-evk.dts:421.1-14 Label or path mdss_dp0_out not found
Error: arch/arm64/boot/dts/qcom/monaco-evk.dts:426.1-14 Label or path mdss_dp0_phy not found
>> FATAL ERROR: Syntax error parsing input tree
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport
2025-11-20 12:11 ` Konrad Dybcio
@ 2025-12-19 11:20 ` Vishnu Saini
2025-12-19 12:10 ` Konrad Dybcio
0 siblings, 1 reply; 28+ messages in thread
From: Vishnu Saini @ 2025-12-19 11:20 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
Vishnu Saini, prahlad.valluru, Prahlad Valluru
On Thu, Nov 20, 2025 at 01:11:00PM +0100, Konrad Dybcio wrote:
> On 11/20/25 11:58 AM, Vishnu Saini wrote:
> > Monaco-evk has LT8713sx which act as DP to 3 DP output
> > converter. Edp PHY from monaco soc is connected to lt8713sx
> > as input and output of lt8713sx is connected to 3 mini DP ports.
> > Two of these ports are available in mainboard and one port
> > is available on Mezz board. lt8713sx is connected to soc over
> > i2c0 and with reset gpio connected to pin6 or ioexpander5.
> >
> > Enable the edp nodes from monaco and enable lontium lt8713sx
> > bridge node.
> >
> > Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> > ---
>
> [...]
>
> > +&i2c0 {
> > + pinctrl-0 = <&qup_i2c0_default>;
> > + pinctrl-names = "default";
> > +
> > + status = "okay";
> > +
> > + lt8713sx: lt8713sx@4f {
>
> Node names should be generic, so bridge@4f
Yes, done in V2.
> > + /*Display bridge chip, DP1.4/HDMI2.0/DP++ hub*/
>
> Comment start/stop markers should have a space after/before them
> respectively, however I'm not sure this comment is useful given the
> dt-bindings already describe what it is
>
Removed this comment in V2.
> [...]
>
> > &tlmm {
> > + dp_hot_plug_det: dp-hot-plug-det-state {
> > + pins = "gpio94";
> > + function = "edp0_hot";
> > + bias-disable;
>
> This is an SoC-mandated function on the pin, so please move it to
> monaco.dtsi
Yes, done in V2.
>
> > + };
> > +
> > ethernet0_default: ethernet0-default-state {
> > ethernet0_mdc: ethernet0-mdc-pins {
> > pins = "gpio5";
> > @@ -451,6 +488,13 @@ ethernet0_mdio: ethernet0-mdio-pins {
> > };
> > };
> >
> > + qup_i2c0_default: qup-i2c0-state {
> > + pins = "gpio17", "gpio18";
> > + function = "qup0_se0";
> > + drive-strength = <2>;
> > + bias-pull-up;
>
> Similarly, you can move these settings to monaco.dtsi and keep them as
> defaults since 99.99% of I2C users will share them
Is it ok if i update this in a different series, similar other nodes like qup_i2c1_default
added in monaco-evk.dts?
> Konrad
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport
2025-11-20 14:26 ` Bjorn Andersson
@ 2025-12-19 11:24 ` Vishnu Saini
0 siblings, 0 replies; 28+ messages in thread
From: Vishnu Saini @ 2025-12-19 11:24 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-msm, devicetree, linux-kernel, Vishnu Saini,
prahlad.valluru, Prahlad Valluru
On Thu, Nov 20, 2025 at 08:26:40AM -0600, Bjorn Andersson wrote:
> On Thu, Nov 20, 2025 at 04:28:05PM +0530, Vishnu Saini wrote:
> > Monaco-evk has LT8713sx which act as DP to 3 DP output
> > converter. Edp PHY from monaco soc is connected to lt8713sx
> > as input and output of lt8713sx is connected to 3 mini DP ports.
> > Two of these ports are available in mainboard and one port
> > is available on Mezz board. lt8713sx is connected to soc over
> > i2c0 and with reset gpio connected to pin6 or ioexpander5.
> >
>
> This is good, you're describing the role of LT8713sx and how it's
> connected on the board. Thank you for taking the time to do so!
>
> I think one aspect that's worth pointing out on its own is the
> placement of the mini DP ports. You do capture it, but the fact that
> we have two on the EVK and one on the expansion board is "hidden" there
> in the middle of the paragraph.
> I think extracting this part of the message into its own paragraph would
> improve the commit message further.
>
Yes, Updated in V2.
> > Enable the edp nodes from monaco and enable lontium lt8713sx
> > bridge node.
> >
> > Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> > ---
> > arch/arm64/boot/dts/qcom/monaco-evk.dts | 44 ++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 44 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> > index bb35893da73d..947807f8a9cb 100644
> > --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
> > +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> > @@ -317,6 +317,20 @@ &gpu_zap_shader {
> > firmware-name = "qcom/qcs8300/a623_zap.mbn";
> > };
> >
>
> Would it be possible to add dp-connector nodes and wire them up to the
> <8713sx, like I did in sa8295-adp.dts?
>
Yes, added dp-connectors in V2.
> > +&i2c0 {
> > + pinctrl-0 = <&qup_i2c0_default>;
> > + pinctrl-names = "default";
> > +
> > + status = "okay";
> > +
> > + lt8713sx: lt8713sx@4f {
>
> This should be bridge@4f.
>
> Also, unless we need to reference this from a overlay there's no need to
> give it a label.
Yes, done.
>
> > + /*Display bridge chip, DP1.4/HDMI2.0/DP++ hub*/
>
> This comment explains what "lontium,lt8713sx" is. The binding call tell
> me that, so the value of this comment would be for you to tell us what
> it is used for on this particular board - and if that's obvious you can
> omit the comment.
Yes, removed it.
> > + compatible = "lontium,lt8713sx";
> > + reg = <0x4f>;
> > + reset-gpios = <&expander5 6 GPIO_ACTIVE_HIGH>;
>
> In addition to using an of_graph to describe the connectors that this is
> wired to, it would be nice to have a port describing the relationship to
> the DP controller here as well - so we know where the signal is coming
> from.
>
> Would that be possible to add?
Yes, added ports and connectors in v2.
> Regards,
> Bjorn
>
> > + };
> > +};
> > +
> > &i2c1 {
> > pinctrl-0 = <&qup_i2c1_default>;
> > pinctrl-names = "default";
> > @@ -396,6 +410,23 @@ expander6: gpio@3e {
> > };
> > };
> >
> > +&mdss {
> > + status = "okay";
> > +};
> > +
> > +&mdss_dp0 {
> > + status = "okay";
> > +};
> > +
> > +&mdss_dp0_out {
> > + data-lanes = <0 1 2 3>;
> > + link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
> > +};
> > +
> > +&mdss_dp0_phy {
> > + status = "okay";
> > +};
> > +
> > &iris {
> > status = "okay";
> > };
> > @@ -435,6 +466,12 @@ &serdes0 {
> > };
> >
> > &tlmm {
> > + dp_hot_plug_det: dp-hot-plug-det-state {
> > + pins = "gpio94";
> > + function = "edp0_hot";
> > + bias-disable;
> > + };
> > +
> > ethernet0_default: ethernet0-default-state {
> > ethernet0_mdc: ethernet0-mdc-pins {
> > pins = "gpio5";
> > @@ -451,6 +488,13 @@ ethernet0_mdio: ethernet0-mdio-pins {
> > };
> > };
> >
> > + qup_i2c0_default: qup-i2c0-state {
> > + pins = "gpio17", "gpio18";
> > + function = "qup0_se0";
> > + drive-strength = <2>;
> > + bias-pull-up;
> > + };
> > +
> > qup_i2c1_default: qup-i2c1-state {
> > pins = "gpio19", "gpio20";
> > function = "qup0_se1";
> >
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport
2025-12-19 11:20 ` Vishnu Saini
@ 2025-12-19 12:10 ` Konrad Dybcio
2025-12-19 12:59 ` Vishnu Saini
0 siblings, 1 reply; 28+ messages in thread
From: Konrad Dybcio @ 2025-12-19 12:10 UTC (permalink / raw)
To: Vishnu Saini
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
Vishnu Saini, prahlad.valluru, Prahlad Valluru
On 12/19/25 12:20 PM, Vishnu Saini wrote:
> On Thu, Nov 20, 2025 at 01:11:00PM +0100, Konrad Dybcio wrote:
>> On 11/20/25 11:58 AM, Vishnu Saini wrote:
>>> Monaco-evk has LT8713sx which act as DP to 3 DP output
>>> converter. Edp PHY from monaco soc is connected to lt8713sx
>>> as input and output of lt8713sx is connected to 3 mini DP ports.
>>> Two of these ports are available in mainboard and one port
>>> is available on Mezz board. lt8713sx is connected to soc over
>>> i2c0 and with reset gpio connected to pin6 or ioexpander5.
>>>
>>> Enable the edp nodes from monaco and enable lontium lt8713sx
>>> bridge node.
>>>
>>> Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
>>> Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
>>> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
>>> ---
[...]
>>> + qup_i2c0_default: qup-i2c0-state {
>>> + pins = "gpio17", "gpio18";
>>> + function = "qup0_se0";
>>> + drive-strength = <2>;
>>> + bias-pull-up;
>>
>> Similarly, you can move these settings to monaco.dtsi and keep them as
>> defaults since 99.99% of I2C users will share them
> Is it ok if i update this in a different series, similar other nodes like qup_i2c1_default
> added in monaco-evk.dts?
No, I don't want you to introduce something "wrong" only because you
don't want to run git commit --amend
I see you've now sent a v2 just 7 minutes after asking this question.
Should I interpret that as you expecting me to drop everything and rush
to respond to your queries immediately, or do you not care about my
feedback anyway?
Konrad
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport
2025-12-19 12:10 ` Konrad Dybcio
@ 2025-12-19 12:59 ` Vishnu Saini
2025-12-19 13:33 ` Konrad Dybcio
0 siblings, 1 reply; 28+ messages in thread
From: Vishnu Saini @ 2025-12-19 12:59 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
Vishnu Saini, prahlad.valluru, Prahlad Valluru
On Fri, Dec 19, 2025 at 01:10:19PM +0100, Konrad Dybcio wrote:
> On 12/19/25 12:20 PM, Vishnu Saini wrote:
> > On Thu, Nov 20, 2025 at 01:11:00PM +0100, Konrad Dybcio wrote:
> >> On 11/20/25 11:58 AM, Vishnu Saini wrote:
> >>> Monaco-evk has LT8713sx which act as DP to 3 DP output
> >>> converter. Edp PHY from monaco soc is connected to lt8713sx
> >>> as input and output of lt8713sx is connected to 3 mini DP ports.
> >>> Two of these ports are available in mainboard and one port
> >>> is available on Mezz board. lt8713sx is connected to soc over
> >>> i2c0 and with reset gpio connected to pin6 or ioexpander5.
> >>>
> >>> Enable the edp nodes from monaco and enable lontium lt8713sx
> >>> bridge node.
> >>>
> >>> Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> >>> Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> >>> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> >>> ---
>
> [...]
>
> >>> + qup_i2c0_default: qup-i2c0-state {
> >>> + pins = "gpio17", "gpio18";
> >>> + function = "qup0_se0";
> >>> + drive-strength = <2>;
> >>> + bias-pull-up;
> >>
> >> Similarly, you can move these settings to monaco.dtsi and keep them as
> >> defaults since 99.99% of I2C users will share them
> > Is it ok if i update this in a different series, similar other nodes like qup_i2c1_default
> > added in monaco-evk.dts?
>
> No, I don't want you to introduce something "wrong" only because you
> don't want to run git commit --amend
>
> I see you've now sent a v2 just 7 minutes after asking this question.
> Should I interpret that as you expecting me to drop everything and rush
> to respond to your queries immediately, or do you not care about my
> feedback anyway?
Apologies, for quickly raising the new patch, i thought of correcting this
in next V3 patch if you ask for.
I am new contributor to the upstream community, just now i setup mutt and learned a bit about
sending reply to the emails and V2 patch was already validated that's why i submitted it.
monaco.dtsi already have below node except drive-strength and bias-pull-up.
tlmm {
qup_i2c0_data_clk: qup-i2c0-data-clk-state {
pins = "gpio17", "gpio18";
function = "qup0_se0";
};
};
I will add drive-strength and bias-pull-up in monaco-evk.dts, let me know if this is ok?
> Konrad
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport
2025-12-19 12:59 ` Vishnu Saini
@ 2025-12-19 13:33 ` Konrad Dybcio
0 siblings, 0 replies; 28+ messages in thread
From: Konrad Dybcio @ 2025-12-19 13:33 UTC (permalink / raw)
To: Vishnu Saini
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
Vishnu Saini, prahlad.valluru, Prahlad Valluru
On 12/19/25 1:59 PM, Vishnu Saini wrote:
> On Fri, Dec 19, 2025 at 01:10:19PM +0100, Konrad Dybcio wrote:
>> On 12/19/25 12:20 PM, Vishnu Saini wrote:
>>> On Thu, Nov 20, 2025 at 01:11:00PM +0100, Konrad Dybcio wrote:
>>>> On 11/20/25 11:58 AM, Vishnu Saini wrote:
>>>>> Monaco-evk has LT8713sx which act as DP to 3 DP output
>>>>> converter. Edp PHY from monaco soc is connected to lt8713sx
>>>>> as input and output of lt8713sx is connected to 3 mini DP ports.
>>>>> Two of these ports are available in mainboard and one port
>>>>> is available on Mezz board. lt8713sx is connected to soc over
>>>>> i2c0 and with reset gpio connected to pin6 or ioexpander5.
>>>>>
>>>>> Enable the edp nodes from monaco and enable lontium lt8713sx
>>>>> bridge node.
>>>>>
>>>>> Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
>>>>> Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
>>>>> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
>>>>> ---
>>
>> [...]
>>
>>>>> + qup_i2c0_default: qup-i2c0-state {
>>>>> + pins = "gpio17", "gpio18";
>>>>> + function = "qup0_se0";
>>>>> + drive-strength = <2>;
>>>>> + bias-pull-up;
>>>>
>>>> Similarly, you can move these settings to monaco.dtsi and keep them as
>>>> defaults since 99.99% of I2C users will share them
>>> Is it ok if i update this in a different series, similar other nodes like qup_i2c1_default
>>> added in monaco-evk.dts?
>>
>> No, I don't want you to introduce something "wrong" only because you
>> don't want to run git commit --amend
>>
>> I see you've now sent a v2 just 7 minutes after asking this question.
>> Should I interpret that as you expecting me to drop everything and rush
>> to respond to your queries immediately, or do you not care about my
>> feedback anyway?
> Apologies, for quickly raising the new patch, i thought of correcting this
> in next V3 patch if you ask for.
> I am new contributor to the upstream community, just now i setup mutt and learned a bit about
> sending reply to the emails and V2 patch was already validated that's why i submitted it.
It's okay. Just please try not to do it again - it's really an anti-pattern.
> monaco.dtsi already have below node except drive-strength and bias-pull-up.
> tlmm {
> qup_i2c0_data_clk: qup-i2c0-data-clk-state {
> pins = "gpio17", "gpio18";
> function = "qup0_se0";
> };
> };
> I will add drive-strength and bias-pull-up in monaco-evk.dts, let me know if this is ok?
That should be fine. Other SoC DTSIs do that already
Konrad
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH 0/2] Enable lt8713sx bridge with displayport for monaco-evk
@ 2026-03-17 6:03 Vishnu Saini
2026-03-17 6:03 ` [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport Vishnu Saini
2026-03-17 6:03 ` [PATCH 2/2] arm64: defconfig: Enable Lontium LT8713sx driver Vishnu Saini
0 siblings, 2 replies; 28+ messages in thread
From: Vishnu Saini @ 2026-03-17 6:03 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Vishnu Saini,
prahlad.valluru, Prahlad Valluru, Dmitry Baryshkov
This series enables lt8713sx bridge and displayport on Qualcomm
monaco-evk platform.
Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
---
Vishnu Saini (2):
arm64: dts: qcom: monaco: add lt8713sx bridge with displayport
arm64: defconfig: Enable Lontium LT8713sx driver
arch/arm64/boot/dts/qcom/monaco-evk.dts | 89 +++++++++++++++++++++++++++++++++
arch/arm64/boot/dts/qcom/monaco.dtsi | 6 +++
arch/arm64/configs/defconfig | 1 +
3 files changed, 96 insertions(+)
---
base-commit: b691d0ede8f0d622eba958ddc32e6009d54832f1
change-id: 20260317-lt8713sx_dt_for_next-73fea668efe9
prerequisite-message-id: <20260303-lt8713sx-bridge-driver-v5-0-6cc2a855aafa@oss.qualcomm.com>
prerequisite-patch-id: c5155e9804a0e30aba47c54471cf6870482d0738
prerequisite-patch-id: 44e87c690845b24fb4dd88bba67e89fcfd18048a
Best regards,
--
Vishnu Saini <vishnu.saini@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport
2026-03-17 6:03 [PATCH 0/2] Enable lt8713sx bridge with displayport for monaco-evk Vishnu Saini
@ 2026-03-17 6:03 ` Vishnu Saini
2026-03-17 9:22 ` Konrad Dybcio
2026-03-17 11:42 ` Krzysztof Kozlowski
2026-03-17 6:03 ` [PATCH 2/2] arm64: defconfig: Enable Lontium LT8713sx driver Vishnu Saini
1 sibling, 2 replies; 28+ messages in thread
From: Vishnu Saini @ 2026-03-17 6:03 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Vishnu Saini,
prahlad.valluru, Prahlad Valluru, Dmitry Baryshkov
Monaco-evk has LT8713sx which act as DP to 3 DP output
converter. Edp PHY from monaco soc is connected to lt8713sx
as input and output of lt8713sx is connected to 3 mini DP ports.
Two ports are available in mainboard and one port
is available on Mezz board.
lt8713sx is connected to soc over i2c0 and with reset gpio
connected to pin6 of ioexpander5.
Enable the edp nodes from monaco and enable lontium lt8713sx
bridge node.
Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/monaco-evk.dts | 89 +++++++++++++++++++++++++++++++++
arch/arm64/boot/dts/qcom/monaco.dtsi | 6 +++
2 files changed, 95 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
index 0b26cc334a69..0ca5615c996d 100644
--- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
+++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
@@ -52,6 +52,30 @@ dmic: audio-codec-0 {
num-channels = <1>;
};
+ dp-connector0 {
+ compatible = "dp-connector";
+ label = "DP";
+ type = "mini";
+
+ port {
+ dp0_connector_in: endpoint {
+ remote-endpoint = <<8713sx_dp0_out>;
+ };
+ };
+ };
+
+ dp-connector1 {
+ compatible = "dp-connector";
+ label = "DP";
+ type = "mini";
+
+ port {
+ dp1_connector_in: endpoint {
+ remote-endpoint = <<8713sx_dp1_out>;
+ };
+ };
+ };
+
max98357a: audio-codec-1 {
compatible = "maxim,max98357a";
#sound-dai-cells = <0>;
@@ -355,6 +379,42 @@ &gpu_zap_shader {
firmware-name = "qcom/qcs8300/a623_zap.mbn";
};
+&i2c0 {
+ status = "okay";
+
+ bridge@4f {
+ compatible = "lontium,lt8713sx";
+ reg = <0x4f>;
+ reset-gpios = <&expander5 6 GPIO_ACTIVE_LOW>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ lt8713sx_dp_in: endpoint {
+ remote-endpoint = <&mdss_dp0_out>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ lt8713sx_dp0_out: endpoint {
+ remote-endpoint = <&dp0_connector_in>;
+ };
+ };
+
+ port@2 {
+ reg = <2>;
+ lt8713sx_dp1_out: endpoint {
+ remote-endpoint = <&dp1_connector_in>;
+ };
+ };
+ };
+ };
+};
+
&i2c1 {
pinctrl-0 = <&qup_i2c1_default>;
pinctrl-names = "default";
@@ -483,6 +543,30 @@ &iris {
status = "okay";
};
+&mdss {
+ status = "okay";
+};
+
+&mdss_dp0 {
+ pinctrl-0 = <&dp_hot_plug_det>;
+ pinctrl-names = "default";
+
+ status = "okay";
+};
+
+&mdss_dp0_out {
+ data-lanes = <0 1 2 3>;
+ link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+ remote-endpoint = <<8713sx_dp_in>;
+};
+
+&mdss_dp0_phy {
+ vdda-phy-supply = <&vreg_l5a>;
+ vdda-pll-supply = <&vreg_l4a>;
+
+ status = "okay";
+};
+
&pcie0 {
pinctrl-0 = <&pcie0_default_state>;
pinctrl-names = "default";
@@ -531,6 +615,11 @@ usb2_id: usb2-id-state {
};
};
+&qup_i2c0_data_clk {
+ drive-strength = <2>;
+ bias-pull-up;
+};
+
&qupv3_id_0 {
firmware-name = "qcom/qcs8300/qupv3fw.elf";
status = "okay";
diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qcom/monaco.dtsi
index f92fdb1cefa0..5741cdbde3f5 100644
--- a/arch/arm64/boot/dts/qcom/monaco.dtsi
+++ b/arch/arm64/boot/dts/qcom/monaco.dtsi
@@ -5893,6 +5893,12 @@ tlmm: pinctrl@f100000 {
#interrupt-cells = <2>;
wakeup-parent = <&pdc>;
+ dp_hot_plug_det: dp-hot-plug-det-state {
+ pins = "gpio94";
+ function = "edp0_hot";
+ bias-disable;
+ };
+
hs0_mi2s_active: hs0-mi2s-active-state {
pins = "gpio106", "gpio107", "gpio108", "gpio109";
function = "hs0_mi2s";
--
2.34.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 2/2] arm64: defconfig: Enable Lontium LT8713sx driver
2026-03-17 6:03 [PATCH 0/2] Enable lt8713sx bridge with displayport for monaco-evk Vishnu Saini
2026-03-17 6:03 ` [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport Vishnu Saini
@ 2026-03-17 6:03 ` Vishnu Saini
2026-03-17 11:44 ` Krzysztof Kozlowski
1 sibling, 1 reply; 28+ messages in thread
From: Vishnu Saini @ 2026-03-17 6:03 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Vishnu Saini,
prahlad.valluru
Lontium LT8713sx DP bridge hub can be found on a Qualcomm
Monaco EVK board for converting 1 DP to 3 DP outputs.
Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 1d967a81b82a..c8f89c87672b 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1002,6 +1002,7 @@ CONFIG_DRM_PANEL_VISIONOX_VTDR6130=m
CONFIG_DRM_DISPLAY_CONNECTOR=m
CONFIG_DRM_FSL_LDB=m
CONFIG_DRM_ITE_IT6263=m
+CONFIG_DRM_LONTIUM_LT8713SX=m
CONFIG_DRM_LONTIUM_LT8912B=m
CONFIG_DRM_LONTIUM_LT9611=m
CONFIG_DRM_LONTIUM_LT9611UXC=m
--
2.34.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport
2026-03-17 6:03 ` [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport Vishnu Saini
@ 2026-03-17 9:22 ` Konrad Dybcio
2026-03-17 13:53 ` Vishnu Saini
2026-03-17 11:42 ` Krzysztof Kozlowski
1 sibling, 1 reply; 28+ messages in thread
From: Konrad Dybcio @ 2026-03-17 9:22 UTC (permalink / raw)
To: Vishnu Saini, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, prahlad.valluru,
Prahlad Valluru, Dmitry Baryshkov
On 3/17/26 7:03 AM, Vishnu Saini wrote:
> Monaco-evk has LT8713sx which act as DP to 3 DP output
> converter. Edp PHY from monaco soc is connected to lt8713sx
> as input and output of lt8713sx is connected to 3 mini DP ports.
>
> Two ports are available in mainboard and one port
> is available on Mezz board.
>
> lt8713sx is connected to soc over i2c0 and with reset gpio
> connected to pin6 of ioexpander5.
>
> Enable the edp nodes from monaco and enable lontium lt8713sx
> bridge node.
>
> Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/monaco-evk.dts | 89 +++++++++++++++++++++++++++++++++
Subject: "s/monaco:/monaco-evk:"
> arch/arm64/boot/dts/qcom/monaco.dtsi | 6 +++
> 2 files changed, 95 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> index 0b26cc334a69..0ca5615c996d 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> @@ -52,6 +52,30 @@ dmic: audio-codec-0 {
> num-channels = <1>;
> };
>
> + dp-connector0 {
> + compatible = "dp-connector";
> + label = "DP";
The labels should be unique, is there any silkscreen or similar that would
be a good candidate?
Konrad
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport
2026-03-17 6:03 ` [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport Vishnu Saini
2026-03-17 9:22 ` Konrad Dybcio
@ 2026-03-17 11:42 ` Krzysztof Kozlowski
2026-03-17 14:10 ` Vishnu Saini
1 sibling, 1 reply; 28+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-17 11:42 UTC (permalink / raw)
To: Vishnu Saini, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, prahlad.valluru,
Prahlad Valluru, Dmitry Baryshkov
On 17/03/2026 07:03, Vishnu Saini wrote:
> Monaco-evk has LT8713sx which act as DP to 3 DP output
> converter. Edp PHY from monaco soc is connected to lt8713sx
> as input and output of lt8713sx is connected to 3 mini DP ports.
>
> Two ports are available in mainboard and one port
> is available on Mezz board.
>
> lt8713sx is connected to soc over i2c0 and with reset gpio
> connected to pin6 of ioexpander5.
>
> Enable the edp nodes from monaco and enable lontium lt8713sx
> bridge node.
>
> Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
How v1 could be reviewed already? v1 is the first posting.
> ---
> arch/arm64/boot/dts/qcom/monaco-evk.dts | 89 +++++++++++++++++++++++++++++++++
> arch/arm64/boot/dts/qcom/monaco.dtsi | 6 +++
> 2 files changed, 95 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> index 0b26cc334a69..0ca5615c996d 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> @@ -52,6 +52,30 @@ dmic: audio-codec-0 {
> num-channels = <1>;
> };
>
> + dp-connector0 {
dp-connector-0
> + compatible = "dp-connector";
> + label = "DP";
> + type = "mini";
> +
> + port {
> + dp0_connector_in: endpoint {
> + remote-endpoint = <<8713sx_dp0_out>;
> + };
> + };
> + };
> +
> + dp-connector1 {
dp-connector-1
> + compatible = "dp-connector";
> + label = "DP";
> + type = "mini";
> +
> + port {
> + dp1_connector_in: endpoint {
> + remote-endpoint = <<8713sx_dp1_out>;
> + };
> + };
> + };
> +
> max98357a: audio-codec-1 {
And here you have example. Write code consistent with the rest.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: defconfig: Enable Lontium LT8713sx driver
2026-03-17 6:03 ` [PATCH 2/2] arm64: defconfig: Enable Lontium LT8713sx driver Vishnu Saini
@ 2026-03-17 11:44 ` Krzysztof Kozlowski
2026-03-17 13:38 ` Vishnu Saini
0 siblings, 1 reply; 28+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-17 11:44 UTC (permalink / raw)
To: Vishnu Saini, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, prahlad.valluru
On 17/03/2026 07:03, Vishnu Saini wrote:
> Lontium LT8713sx DP bridge hub can be found on a Qualcomm
> Monaco EVK board for converting 1 DP to 3 DP outputs.
>
> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> ---
> arch/arm64/configs/defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 1d967a81b82a..c8f89c87672b 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1002,6 +1002,7 @@ CONFIG_DRM_PANEL_VISIONOX_VTDR6130=m
> CONFIG_DRM_DISPLAY_CONNECTOR=m
> CONFIG_DRM_FSL_LDB=m
> CONFIG_DRM_ITE_IT6263=m
> +CONFIG_DRM_LONTIUM_LT8713SX=m
Wrongly placed, at least at next I am checking now. Look at Kconfig or
just run savedefconfig.
> CONFIG_DRM_LONTIUM_LT8912B=m
> CONFIG_DRM_LONTIUM_LT9611=m
> CONFIG_DRM_LONTIUM_LT9611UXC=m
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: defconfig: Enable Lontium LT8713sx driver
2026-03-17 11:44 ` Krzysztof Kozlowski
@ 2026-03-17 13:38 ` Vishnu Saini
2026-03-17 13:49 ` Krzysztof Kozlowski
0 siblings, 1 reply; 28+ messages in thread
From: Vishnu Saini @ 2026-03-17 13:38 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
prahlad.valluru
On Tue, Mar 17, 2026 at 12:44:05PM +0100, Krzysztof Kozlowski wrote:
> On 17/03/2026 07:03, Vishnu Saini wrote:
> > Lontium LT8713sx DP bridge hub can be found on a Qualcomm
> > Monaco EVK board for converting 1 DP to 3 DP outputs.
> >
> > Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> > ---
> > arch/arm64/configs/defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 1d967a81b82a..c8f89c87672b 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -1002,6 +1002,7 @@ CONFIG_DRM_PANEL_VISIONOX_VTDR6130=m
> > CONFIG_DRM_DISPLAY_CONNECTOR=m
> > CONFIG_DRM_FSL_LDB=m
> > CONFIG_DRM_ITE_IT6263=m
> > +CONFIG_DRM_LONTIUM_LT8713SX=m
>
> Wrongly placed, at least at next I am checking now. Look at Kconfig or
> just run savedefconfig.
Cross checked this few rescent changes were added configs in same file.
verified added config is present in generated .config file and lt8713sx driver is compiled with it.
Let me know if need to add this config is another file or at different place.
> > CONFIG_DRM_LONTIUM_LT8912B=m
> > CONFIG_DRM_LONTIUM_LT9611=m
> > CONFIG_DRM_LONTIUM_LT9611UXC=m
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: defconfig: Enable Lontium LT8713sx driver
2026-03-17 13:38 ` Vishnu Saini
@ 2026-03-17 13:49 ` Krzysztof Kozlowski
2026-03-17 14:23 ` Vishnu Saini
0 siblings, 1 reply; 28+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-17 13:49 UTC (permalink / raw)
To: Vishnu Saini
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
prahlad.valluru
On 17/03/2026 14:38, Vishnu Saini wrote:
> On Tue, Mar 17, 2026 at 12:44:05PM +0100, Krzysztof Kozlowski wrote:
>> On 17/03/2026 07:03, Vishnu Saini wrote:
>>> Lontium LT8713sx DP bridge hub can be found on a Qualcomm
>>> Monaco EVK board for converting 1 DP to 3 DP outputs.
>>>
>>> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
>>> ---
>>> arch/arm64/configs/defconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>> index 1d967a81b82a..c8f89c87672b 100644
>>> --- a/arch/arm64/configs/defconfig
>>> +++ b/arch/arm64/configs/defconfig
>>> @@ -1002,6 +1002,7 @@ CONFIG_DRM_PANEL_VISIONOX_VTDR6130=m
>>> CONFIG_DRM_DISPLAY_CONNECTOR=m
>>> CONFIG_DRM_FSL_LDB=m
>>> CONFIG_DRM_ITE_IT6263=m
>>> +CONFIG_DRM_LONTIUM_LT8713SX=m
>>
>> Wrongly placed, at least at next I am checking now. Look at Kconfig or
>> just run savedefconfig.
>
> Cross checked this few rescent changes were added configs in same file.
> verified added config is present in generated .config file and lt8713sx driver is compiled with it.
> Let me know if need to add this config is another file or at different place.
So did you run `make savedefconfig`? If you do not understand review
then at least follow what I asked for...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport
2026-03-17 9:22 ` Konrad Dybcio
@ 2026-03-17 13:53 ` Vishnu Saini
2026-03-17 13:58 ` Konrad Dybcio
0 siblings, 1 reply; 28+ messages in thread
From: Vishnu Saini @ 2026-03-17 13:53 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
prahlad.valluru, Prahlad Valluru, Dmitry Baryshkov
On Tue, Mar 17, 2026 at 10:22:04AM +0100, Konrad Dybcio wrote:
> On 3/17/26 7:03 AM, Vishnu Saini wrote:
> > Monaco-evk has LT8713sx which act as DP to 3 DP output
> > converter. Edp PHY from monaco soc is connected to lt8713sx
> > as input and output of lt8713sx is connected to 3 mini DP ports.
> >
> > Two ports are available in mainboard and one port
> > is available on Mezz board.
> >
> > lt8713sx is connected to soc over i2c0 and with reset gpio
> > connected to pin6 of ioexpander5.
> >
> > Enable the edp nodes from monaco and enable lontium lt8713sx
> > bridge node.
> >
> > Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> > ---
> > arch/arm64/boot/dts/qcom/monaco-evk.dts | 89 +++++++++++++++++++++++++++++++++
>
> Subject: "s/monaco:/monaco-evk:"
Will fix this in next revision.
> > arch/arm64/boot/dts/qcom/monaco.dtsi | 6 +++
> > 2 files changed, 95 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> > index 0b26cc334a69..0ca5615c996d 100644
> > --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
> > +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> > @@ -52,6 +52,30 @@ dmic: audio-codec-0 {
> > num-channels = <1>;
> > };
> >
> > + dp-connector0 {
> > + compatible = "dp-connector";
> > + label = "DP";
>
> The labels should be unique, is there any silkscreen or similar that would
> be a good candidate?
yes, the connectors are marked as JEDP0 and JEDP1 on the board silkscreen.
I will update labels accordingly in next revision.
> Konrad
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport
2026-03-17 13:53 ` Vishnu Saini
@ 2026-03-17 13:58 ` Konrad Dybcio
0 siblings, 0 replies; 28+ messages in thread
From: Konrad Dybcio @ 2026-03-17 13:58 UTC (permalink / raw)
To: Vishnu Saini
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
prahlad.valluru, Prahlad Valluru, Dmitry Baryshkov
On 3/17/26 2:53 PM, Vishnu Saini wrote:
> On Tue, Mar 17, 2026 at 10:22:04AM +0100, Konrad Dybcio wrote:
>> On 3/17/26 7:03 AM, Vishnu Saini wrote:
>>> Monaco-evk has LT8713sx which act as DP to 3 DP output
>>> converter. Edp PHY from monaco soc is connected to lt8713sx
>>> as input and output of lt8713sx is connected to 3 mini DP ports.
>>>
>>> Two ports are available in mainboard and one port
>>> is available on Mezz board.
>>>
>>> lt8713sx is connected to soc over i2c0 and with reset gpio
>>> connected to pin6 of ioexpander5.
>>>
>>> Enable the edp nodes from monaco and enable lontium lt8713sx
>>> bridge node.
>>>
>>> Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
>>> Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
>>> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>>> ---
>>> arch/arm64/boot/dts/qcom/monaco-evk.dts | 89 +++++++++++++++++++++++++++++++++
>>
>> Subject: "s/monaco:/monaco-evk:"
> Will fix this in next revision.
>
>>> arch/arm64/boot/dts/qcom/monaco.dtsi | 6 +++
>>> 2 files changed, 95 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
>>> index 0b26cc334a69..0ca5615c996d 100644
>>> --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
>>> +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
>>> @@ -52,6 +52,30 @@ dmic: audio-codec-0 {
>>> num-channels = <1>;
>>> };
>>>
>>> + dp-connector0 {
>>> + compatible = "dp-connector";
>>> + label = "DP";
>>
>> The labels should be unique, is there any silkscreen or similar that would
>> be a good candidate?
> yes, the connectors are marked as JEDP0 and JEDP1 on the board silkscreen.
> I will update labels accordingly in next revision.
"DP0" and "DP1" are fine too, and probably more obvious
Konrad
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport
2026-03-17 11:42 ` Krzysztof Kozlowski
@ 2026-03-17 14:10 ` Vishnu Saini
2026-03-17 14:40 ` Krzysztof Kozlowski
2026-03-17 14:40 ` Dmitry Baryshkov
0 siblings, 2 replies; 28+ messages in thread
From: Vishnu Saini @ 2026-03-17 14:10 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
prahlad.valluru, Prahlad Valluru, Dmitry Baryshkov
On Tue, Mar 17, 2026 at 12:42:24PM +0100, Krzysztof Kozlowski wrote:
> On 17/03/2026 07:03, Vishnu Saini wrote:
> > Monaco-evk has LT8713sx which act as DP to 3 DP output
> > converter. Edp PHY from monaco soc is connected to lt8713sx
> > as input and output of lt8713sx is connected to 3 mini DP ports.
> >
> > Two ports are available in mainboard and one port
> > is available on Mezz board.
> >
> > lt8713sx is connected to soc over i2c0 and with reset gpio
> > connected to pin6 of ioexpander5.
> >
> > Enable the edp nodes from monaco and enable lontium lt8713sx
> > bridge node.
> >
> > Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>
> How v1 could be reviewed already? v1 is the first posting.
This series was reviewed previously, https://lore.kernel.org/all/20251228-lt8713sx-bridge-linux-for-next-v3-0-3f77ad84d7d1@oss.qualcomm.com/
Maintainer asked to submit a new series once dependent patches are merged.
>
> > ---
> > arch/arm64/boot/dts/qcom/monaco-evk.dts | 89 +++++++++++++++++++++++++++++++++
> > arch/arm64/boot/dts/qcom/monaco.dtsi | 6 +++
> > 2 files changed, 95 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> > index 0b26cc334a69..0ca5615c996d 100644
> > --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
> > +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> > @@ -52,6 +52,30 @@ dmic: audio-codec-0 {
> > num-channels = <1>;
> > };
> >
> > + dp-connector0 {
>
> dp-connector-0
>
> > + compatible = "dp-connector";
> > + label = "DP";
> > + type = "mini";
> > +
> > + port {
> > + dp0_connector_in: endpoint {
> > + remote-endpoint = <<8713sx_dp0_out>;
> > + };
> > + };
> > + };
> > +
> > + dp-connector1 {
>
>
> dp-connector-1
>
> > + compatible = "dp-connector";
> > + label = "DP";
> > + type = "mini";
> > +
> > + port {
> > + dp1_connector_in: endpoint {
> > + remote-endpoint = <<8713sx_dp1_out>;
> > + };
> > + };
> > + };
> > +
> > max98357a: audio-codec-1 {
>
> And here you have example. Write code consistent with the rest.
>
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: defconfig: Enable Lontium LT8713sx driver
2026-03-17 13:49 ` Krzysztof Kozlowski
@ 2026-03-17 14:23 ` Vishnu Saini
2026-03-17 14:40 ` Krzysztof Kozlowski
0 siblings, 1 reply; 28+ messages in thread
From: Vishnu Saini @ 2026-03-17 14:23 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
prahlad.valluru
On Tue, Mar 17, 2026 at 02:49:56PM +0100, Krzysztof Kozlowski wrote:
> On 17/03/2026 14:38, Vishnu Saini wrote:
> > On Tue, Mar 17, 2026 at 12:44:05PM +0100, Krzysztof Kozlowski wrote:
> >> On 17/03/2026 07:03, Vishnu Saini wrote:
> >>> Lontium LT8713sx DP bridge hub can be found on a Qualcomm
> >>> Monaco EVK board for converting 1 DP to 3 DP outputs.
> >>>
> >>> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> >>> ---
> >>> arch/arm64/configs/defconfig | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> >>> index 1d967a81b82a..c8f89c87672b 100644
> >>> --- a/arch/arm64/configs/defconfig
> >>> +++ b/arch/arm64/configs/defconfig
> >>> @@ -1002,6 +1002,7 @@ CONFIG_DRM_PANEL_VISIONOX_VTDR6130=m
> >>> CONFIG_DRM_DISPLAY_CONNECTOR=m
> >>> CONFIG_DRM_FSL_LDB=m
> >>> CONFIG_DRM_ITE_IT6263=m
> >>> +CONFIG_DRM_LONTIUM_LT8713SX=m
> >>
> >> Wrongly placed, at least at next I am checking now. Look at Kconfig or
> >> just run savedefconfig.
> >
> > Cross checked this few rescent changes were added configs in same file.
> > verified added config is present in generated .config file and lt8713sx driver is compiled with it.
> > Let me know if need to add this config is another file or at different place.
>
> So did you run `make savedefconfig`? If you do not understand review
> then at least follow what I asked for...
Yes, 'make savedefconfig' executed as below, sorry i did not mention about this earlier.
make savedefconfig
HOSTCC scripts/basic/fixdep
HOSTCC scripts/kconfig/conf.o
HOSTCC scripts/kconfig/confdata.o
HOSTCC scripts/kconfig/expr.o
HOSTCC scripts/kconfig/lexer.lex.o
HOSTCC scripts/kconfig/menu.o
HOSTCC scripts/kconfig/parser.tab.o
HOSTCC scripts/kconfig/preprocess.o
HOSTCC scripts/kconfig/symbol.o
HOSTCC scripts/kconfig/util.o
HOSTLD scripts/kconfig/conf
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport
2026-03-17 14:10 ` Vishnu Saini
@ 2026-03-17 14:40 ` Krzysztof Kozlowski
2026-03-17 14:40 ` Dmitry Baryshkov
1 sibling, 0 replies; 28+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-17 14:40 UTC (permalink / raw)
To: Vishnu Saini
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
prahlad.valluru, Prahlad Valluru, Dmitry Baryshkov
On 17/03/2026 15:10, Vishnu Saini wrote:
> On Tue, Mar 17, 2026 at 12:42:24PM +0100, Krzysztof Kozlowski wrote:
>> On 17/03/2026 07:03, Vishnu Saini wrote:
>>> Monaco-evk has LT8713sx which act as DP to 3 DP output
>>> converter. Edp PHY from monaco soc is connected to lt8713sx
>>> as input and output of lt8713sx is connected to 3 mini DP ports.
>>>
>>> Two ports are available in mainboard and one port
>>> is available on Mezz board.
>>>
>>> lt8713sx is connected to soc over i2c0 and with reset gpio
>>> connected to pin6 of ioexpander5.
>>>
>>> Enable the edp nodes from monaco and enable lontium lt8713sx
>>> bridge node.
>>>
>>> Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
>>> Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
>>> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>>
>> How v1 could be reviewed already? v1 is the first posting.
> This series was reviewed previously, https://lore.kernel.org/all/20251228-lt8713sx-bridge-linux-for-next-v3-0-3f77ad84d7d1@oss.qualcomm.com/
> Maintainer asked to submit a new series once dependent patches are merged.\
Not a v1 in such case. Please keep versioning, changelog and previous
references/lore links.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport
2026-03-17 14:10 ` Vishnu Saini
2026-03-17 14:40 ` Krzysztof Kozlowski
@ 2026-03-17 14:40 ` Dmitry Baryshkov
2026-03-17 15:25 ` Vishnu Saini
1 sibling, 1 reply; 28+ messages in thread
From: Dmitry Baryshkov @ 2026-03-17 14:40 UTC (permalink / raw)
To: Vishnu Saini
Cc: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel, prahlad.valluru, Prahlad Valluru
On Tue, Mar 17, 2026 at 07:40:09PM +0530, Vishnu Saini wrote:
> On Tue, Mar 17, 2026 at 12:42:24PM +0100, Krzysztof Kozlowski wrote:
> > On 17/03/2026 07:03, Vishnu Saini wrote:
> > > Monaco-evk has LT8713sx which act as DP to 3 DP output
> > > converter. Edp PHY from monaco soc is connected to lt8713sx
> > > as input and output of lt8713sx is connected to 3 mini DP ports.
> > >
> > > Two ports are available in mainboard and one port
> > > is available on Mezz board.
> > >
> > > lt8713sx is connected to soc over i2c0 and with reset gpio
> > > connected to pin6 of ioexpander5.
> > >
> > > Enable the edp nodes from monaco and enable lontium lt8713sx
> > > bridge node.
> > >
> > > Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > > Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > > Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> >
> > How v1 could be reviewed already? v1 is the first posting.
> This series was reviewed previously, https://lore.kernel.org/all/20251228-lt8713sx-bridge-linux-for-next-v3-0-3f77ad84d7d1@oss.qualcomm.com/
> Maintainer asked to submit a new series once dependent patches are merged.
The patches were already sent, so this should be v4 at least.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: defconfig: Enable Lontium LT8713sx driver
2026-03-17 14:23 ` Vishnu Saini
@ 2026-03-17 14:40 ` Krzysztof Kozlowski
2026-03-17 15:19 ` Vishnu Saini
0 siblings, 1 reply; 28+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-17 14:40 UTC (permalink / raw)
To: Vishnu Saini
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
prahlad.valluru
On 17/03/2026 15:23, Vishnu Saini wrote:
> On Tue, Mar 17, 2026 at 02:49:56PM +0100, Krzysztof Kozlowski wrote:
>> On 17/03/2026 14:38, Vishnu Saini wrote:
>>> On Tue, Mar 17, 2026 at 12:44:05PM +0100, Krzysztof Kozlowski wrote:
>>>> On 17/03/2026 07:03, Vishnu Saini wrote:
>>>>> Lontium LT8713sx DP bridge hub can be found on a Qualcomm
>>>>> Monaco EVK board for converting 1 DP to 3 DP outputs.
>>>>>
>>>>> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
>>>>> ---
>>>>> arch/arm64/configs/defconfig | 1 +
>>>>> 1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>>>> index 1d967a81b82a..c8f89c87672b 100644
>>>>> --- a/arch/arm64/configs/defconfig
>>>>> +++ b/arch/arm64/configs/defconfig
>>>>> @@ -1002,6 +1002,7 @@ CONFIG_DRM_PANEL_VISIONOX_VTDR6130=m
>>>>> CONFIG_DRM_DISPLAY_CONNECTOR=m
>>>>> CONFIG_DRM_FSL_LDB=m
>>>>> CONFIG_DRM_ITE_IT6263=m
>>>>> +CONFIG_DRM_LONTIUM_LT8713SX=m
>>>>
>>>> Wrongly placed, at least at next I am checking now. Look at Kconfig or
>>>> just run savedefconfig.
>>>
>>> Cross checked this few rescent changes were added configs in same file.
>>> verified added config is present in generated .config file and lt8713sx driver is compiled with it.
>>> Let me know if need to add this config is another file or at different place.
>>
>> So did you run `make savedefconfig`? If you do not understand review
>> then at least follow what I asked for...
> Yes, 'make savedefconfig' executed as below, sorry i did not mention about this earlier.
> make savedefconfig
And? What is the point of savedefconfig?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: defconfig: Enable Lontium LT8713sx driver
2026-03-17 14:40 ` Krzysztof Kozlowski
@ 2026-03-17 15:19 ` Vishnu Saini
2026-03-17 17:51 ` Dmitry Baryshkov
0 siblings, 1 reply; 28+ messages in thread
From: Vishnu Saini @ 2026-03-17 15:19 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
prahlad.valluru
On Tue, Mar 17, 2026 at 03:40:54PM +0100, Krzysztof Kozlowski wrote:
> On 17/03/2026 15:23, Vishnu Saini wrote:
> > On Tue, Mar 17, 2026 at 02:49:56PM +0100, Krzysztof Kozlowski wrote:
> >> On 17/03/2026 14:38, Vishnu Saini wrote:
> >>> On Tue, Mar 17, 2026 at 12:44:05PM +0100, Krzysztof Kozlowski wrote:
> >>>> On 17/03/2026 07:03, Vishnu Saini wrote:
> >>>>> Lontium LT8713sx DP bridge hub can be found on a Qualcomm
> >>>>> Monaco EVK board for converting 1 DP to 3 DP outputs.
> >>>>>
> >>>>> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> >>>>> ---
> >>>>> arch/arm64/configs/defconfig | 1 +
> >>>>> 1 file changed, 1 insertion(+)
> >>>>>
> >>>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> >>>>> index 1d967a81b82a..c8f89c87672b 100644
> >>>>> --- a/arch/arm64/configs/defconfig
> >>>>> +++ b/arch/arm64/configs/defconfig
> >>>>> @@ -1002,6 +1002,7 @@ CONFIG_DRM_PANEL_VISIONOX_VTDR6130=m
> >>>>> CONFIG_DRM_DISPLAY_CONNECTOR=m
> >>>>> CONFIG_DRM_FSL_LDB=m
> >>>>> CONFIG_DRM_ITE_IT6263=m
> >>>>> +CONFIG_DRM_LONTIUM_LT8713SX=m
> >>>>
> >>>> Wrongly placed, at least at next I am checking now. Look at Kconfig or
> >>>> just run savedefconfig.
> >>>
> >>> Cross checked this few rescent changes were added configs in same file.
> >>> verified added config is present in generated .config file and lt8713sx driver is compiled with it.
> >>> Let me know if need to add this config is another file or at different place.
> >>
> >> So did you run `make savedefconfig`? If you do not understand review
> >> then at least follow what I asked for...
> > Yes, 'make savedefconfig' executed as below, sorry i did not mention about this earlier.
> > make savedefconfig
>
> And? What is the point of savedefconfig?
This generate a minimal defconfig containing only non‑default options.
A defconfig file is generated in my root dir, CONFIG_DRM_LONTIUM_LT8713SX is part of this generated defconfig.
shall i update arch/arm64/configs/defconfig with generated defconfig and verify ?
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport
2026-03-17 14:40 ` Dmitry Baryshkov
@ 2026-03-17 15:25 ` Vishnu Saini
0 siblings, 0 replies; 28+ messages in thread
From: Vishnu Saini @ 2026-03-17 15:25 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel, prahlad.valluru, Prahlad Valluru
On Tue, Mar 17, 2026 at 04:40:51PM +0200, Dmitry Baryshkov wrote:
> On Tue, Mar 17, 2026 at 07:40:09PM +0530, Vishnu Saini wrote:
> > On Tue, Mar 17, 2026 at 12:42:24PM +0100, Krzysztof Kozlowski wrote:
> > > On 17/03/2026 07:03, Vishnu Saini wrote:
> > > > Monaco-evk has LT8713sx which act as DP to 3 DP output
> > > > converter. Edp PHY from monaco soc is connected to lt8713sx
> > > > as input and output of lt8713sx is connected to 3 mini DP ports.
> > > >
> > > > Two ports are available in mainboard and one port
> > > > is available on Mezz board.
> > > >
> > > > lt8713sx is connected to soc over i2c0 and with reset gpio
> > > > connected to pin6 of ioexpander5.
> > > >
> > > > Enable the edp nodes from monaco and enable lontium lt8713sx
> > > > bridge node.
> > > >
> > > > Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > > > Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > > > Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> > >
> > > How v1 could be reviewed already? v1 is the first posting.
> > This series was reviewed previously, https://lore.kernel.org/all/20251228-lt8713sx-bridge-linux-for-next-v3-0-3f77ad84d7d1@oss.qualcomm.com/
> > Maintainer asked to submit a new series once dependent patches are merged.
>
> The patches were already sent, so this should be v4 at least.
Sorry for the misunderstanding, i will rebase and submit v4 to previous series.
I will address review comments from this series in v4.
>
> --
> With best wishes
> Dmitry
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: defconfig: Enable Lontium LT8713sx driver
2026-03-17 15:19 ` Vishnu Saini
@ 2026-03-17 17:51 ` Dmitry Baryshkov
2026-03-17 19:03 ` Vishnu Saini
0 siblings, 1 reply; 28+ messages in thread
From: Dmitry Baryshkov @ 2026-03-17 17:51 UTC (permalink / raw)
To: Vishnu Saini
Cc: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel, prahlad.valluru
On Tue, Mar 17, 2026 at 08:49:10PM +0530, Vishnu Saini wrote:
> On Tue, Mar 17, 2026 at 03:40:54PM +0100, Krzysztof Kozlowski wrote:
> > On 17/03/2026 15:23, Vishnu Saini wrote:
> > > On Tue, Mar 17, 2026 at 02:49:56PM +0100, Krzysztof Kozlowski wrote:
> > >> On 17/03/2026 14:38, Vishnu Saini wrote:
> > >>> On Tue, Mar 17, 2026 at 12:44:05PM +0100, Krzysztof Kozlowski wrote:
> > >>>> On 17/03/2026 07:03, Vishnu Saini wrote:
> > >>>>> Lontium LT8713sx DP bridge hub can be found on a Qualcomm
> > >>>>> Monaco EVK board for converting 1 DP to 3 DP outputs.
> > >>>>>
> > >>>>> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> > >>>>> ---
> > >>>>> arch/arm64/configs/defconfig | 1 +
> > >>>>> 1 file changed, 1 insertion(+)
> > >>>>>
> > >>>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > >>>>> index 1d967a81b82a..c8f89c87672b 100644
> > >>>>> --- a/arch/arm64/configs/defconfig
> > >>>>> +++ b/arch/arm64/configs/defconfig
> > >>>>> @@ -1002,6 +1002,7 @@ CONFIG_DRM_PANEL_VISIONOX_VTDR6130=m
> > >>>>> CONFIG_DRM_DISPLAY_CONNECTOR=m
> > >>>>> CONFIG_DRM_FSL_LDB=m
> > >>>>> CONFIG_DRM_ITE_IT6263=m
> > >>>>> +CONFIG_DRM_LONTIUM_LT8713SX=m
> > >>>>
> > >>>> Wrongly placed, at least at next I am checking now. Look at Kconfig or
> > >>>> just run savedefconfig.
> > >>>
> > >>> Cross checked this few rescent changes were added configs in same file.
> > >>> verified added config is present in generated .config file and lt8713sx driver is compiled with it.
> > >>> Let me know if need to add this config is another file or at different place.
> > >>
> > >> So did you run `make savedefconfig`? If you do not understand review
> > >> then at least follow what I asked for...
> > > Yes, 'make savedefconfig' executed as below, sorry i did not mention about this earlier.
> > > make savedefconfig
> >
> > And? What is the point of savedefconfig?
> This generate a minimal defconfig containing only non‑default options.
> A defconfig file is generated in my root dir, CONFIG_DRM_LONTIUM_LT8713SX is part of this generated defconfig.
> shall i update arch/arm64/configs/defconfig with generated defconfig and verify ?
In which place is the config entry present in defconfig and is it the
same as the one in your patch? That was the question that Krzysztof
asked in the first email, which you seem to ignore.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: defconfig: Enable Lontium LT8713sx driver
2026-03-17 17:51 ` Dmitry Baryshkov
@ 2026-03-17 19:03 ` Vishnu Saini
0 siblings, 0 replies; 28+ messages in thread
From: Vishnu Saini @ 2026-03-17 19:03 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel, prahlad.valluru
On Tue, Mar 17, 2026 at 07:51:36PM +0200, Dmitry Baryshkov wrote:
> On Tue, Mar 17, 2026 at 08:49:10PM +0530, Vishnu Saini wrote:
> > On Tue, Mar 17, 2026 at 03:40:54PM +0100, Krzysztof Kozlowski wrote:
> > > On 17/03/2026 15:23, Vishnu Saini wrote:
> > > > On Tue, Mar 17, 2026 at 02:49:56PM +0100, Krzysztof Kozlowski wrote:
> > > >> On 17/03/2026 14:38, Vishnu Saini wrote:
> > > >>> On Tue, Mar 17, 2026 at 12:44:05PM +0100, Krzysztof Kozlowski wrote:
> > > >>>> On 17/03/2026 07:03, Vishnu Saini wrote:
> > > >>>>> Lontium LT8713sx DP bridge hub can be found on a Qualcomm
> > > >>>>> Monaco EVK board for converting 1 DP to 3 DP outputs.
> > > >>>>>
> > > >>>>> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> > > >>>>> ---
> > > >>>>> arch/arm64/configs/defconfig | 1 +
> > > >>>>> 1 file changed, 1 insertion(+)
> > > >>>>>
> > > >>>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > > >>>>> index 1d967a81b82a..c8f89c87672b 100644
> > > >>>>> --- a/arch/arm64/configs/defconfig
> > > >>>>> +++ b/arch/arm64/configs/defconfig
> > > >>>>> @@ -1002,6 +1002,7 @@ CONFIG_DRM_PANEL_VISIONOX_VTDR6130=m
> > > >>>>> CONFIG_DRM_DISPLAY_CONNECTOR=m
> > > >>>>> CONFIG_DRM_FSL_LDB=m
> > > >>>>> CONFIG_DRM_ITE_IT6263=m
> > > >>>>> +CONFIG_DRM_LONTIUM_LT8713SX=m
> > > >>>>
> > > >>>> Wrongly placed, at least at next I am checking now. Look at Kconfig or
> > > >>>> just run savedefconfig.
> > > >>>
> > > >>> Cross checked this few rescent changes were added configs in same file.
> > > >>> verified added config is present in generated .config file and lt8713sx driver is compiled with it.
> > > >>> Let me know if need to add this config is another file or at different place.
> > > >>
> > > >> So did you run `make savedefconfig`? If you do not understand review
> > > >> then at least follow what I asked for...
> > > > Yes, 'make savedefconfig' executed as below, sorry i did not mention about this earlier.
> > > > make savedefconfig
> > >
> > > And? What is the point of savedefconfig?
> > This generate a minimal defconfig containing only non‑default options.
> > A defconfig file is generated in my root dir, CONFIG_DRM_LONTIUM_LT8713SX is part of this generated defconfig.
> > shall i update arch/arm64/configs/defconfig with generated defconfig and verify ?
>
> In which place is the config entry present in defconfig and is it the
> same as the one in your patch? That was the question that Krzysztof
> asked in the first email, which you seem to ignore.
Thank you for the clarity, I thought lexicographical order is followed here.
savedefconfig generated in below order, i will follow same in v4 patch.
Sorry Krzysztof i completely misunderstood the question.
CONFIG_DRM_LONTIUM_LT8912B=m
CONFIG_DRM_LONTIUM_LT9611=m
CONFIG_DRM_LONTIUM_LT9611UXC=m
CONFIG_DRM_LONTIUM_LT8713SX=m
CONFIG_DRM_ITE_IT66121=m
CONFIG_DRM_NWL_MIPI_DSI=m
> --
> With best wishes
> Dmitry
^ permalink raw reply [flat|nested] 28+ messages in thread
end of thread, other threads:[~2026-03-17 19:03 UTC | newest]
Thread overview: 28+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-17 6:03 [PATCH 0/2] Enable lt8713sx bridge with displayport for monaco-evk Vishnu Saini
2026-03-17 6:03 ` [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport Vishnu Saini
2026-03-17 9:22 ` Konrad Dybcio
2026-03-17 13:53 ` Vishnu Saini
2026-03-17 13:58 ` Konrad Dybcio
2026-03-17 11:42 ` Krzysztof Kozlowski
2026-03-17 14:10 ` Vishnu Saini
2026-03-17 14:40 ` Krzysztof Kozlowski
2026-03-17 14:40 ` Dmitry Baryshkov
2026-03-17 15:25 ` Vishnu Saini
2026-03-17 6:03 ` [PATCH 2/2] arm64: defconfig: Enable Lontium LT8713sx driver Vishnu Saini
2026-03-17 11:44 ` Krzysztof Kozlowski
2026-03-17 13:38 ` Vishnu Saini
2026-03-17 13:49 ` Krzysztof Kozlowski
2026-03-17 14:23 ` Vishnu Saini
2026-03-17 14:40 ` Krzysztof Kozlowski
2026-03-17 15:19 ` Vishnu Saini
2026-03-17 17:51 ` Dmitry Baryshkov
2026-03-17 19:03 ` Vishnu Saini
-- strict thread matches above, loose matches on Subject: below --
2025-11-20 10:58 [PATCH 0/2] Enable lt8713sx bridge with displayport for monaco-evk Vishnu Saini
2025-11-20 10:58 ` [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport Vishnu Saini
2025-11-20 12:11 ` Konrad Dybcio
2025-12-19 11:20 ` Vishnu Saini
2025-12-19 12:10 ` Konrad Dybcio
2025-12-19 12:59 ` Vishnu Saini
2025-12-19 13:33 ` Konrad Dybcio
2025-11-20 14:26 ` Bjorn Andersson
2025-12-19 11:24 ` Vishnu Saini
2025-11-24 10:46 ` kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox