devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: vendor-prefixes: add kfr prefix
@ 2025-11-14  7:53 Gilles BULOZ
  2025-11-14  8:40 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 6+ messages in thread
From: Gilles BULOZ @ 2025-11-14  7:53 UTC (permalink / raw)
  To: Rob Herring; +Cc: devicetree

Add kfr vendor prefix for Kontron France, which is a single-board
computer (SBC) manufacturer.

Signed-off-by: Gilles Buloz <gilles.buloz@kontron.com>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff -u a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -843,6 +843,8 @@
     description: Keith & Koep GmbH
   "^keymile,.*":
     description: Keymile GmbH
+  "^kfr,.*":
+    description: Kontron France
   "^khadas,.*":
     description: Khadas
   "^kiebackpeter,.*":


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] dt-bindings: vendor-prefixes: add kfr prefix
  2025-11-14  7:53 [PATCH] dt-bindings: vendor-prefixes: add kfr prefix Gilles BULOZ
@ 2025-11-14  8:40 ` Krzysztof Kozlowski
  2025-11-14  9:23   ` Gilles BULOZ
  0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-11-14  8:40 UTC (permalink / raw)
  To: Gilles BULOZ, Rob Herring; +Cc: devicetree

On 14/11/2025 08:53, Gilles BULOZ wrote:
> Add kfr vendor prefix for Kontron France, which is a single-board
> computer (SBC) manufacturer.

There is no user for this.

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument, so you will
not CC people just because they made one commit years ago). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
</form letter>

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] dt-bindings: vendor-prefixes: add kfr prefix
  2025-11-14  8:40 ` Krzysztof Kozlowski
@ 2025-11-14  9:23   ` Gilles BULOZ
  2025-11-14  9:32     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 6+ messages in thread
From: Gilles BULOZ @ 2025-11-14  9:23 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Rob Herring; +Cc: devicetree

Le 14/11/2025 à 09:40, Krzysztof Kozlowski a écrit :

> [Vous ne recevez pas souvent de courriers de krzk@kernel.org. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>
> On 14/11/2025 08:53, Gilles BULOZ wrote:
>> Add kfr vendor prefix for Kontron France, which is a single-board
>> computer (SBC) manufacturer.
> There is no user for this.

Hi Krzysztof,

Yes, there's no user for vendor "kfr" in kernel tree, but Kontron has
produced some ARM boards (VM6103,VX3106,VX6124,VX3124) on which we
ported uboot and added some entries in device tree for board specific
devices (CPLD) using vendor "kfr". We also provide a Linux BSP for these
boards with drivers using compatible = kfr,<cpldchip>.
My patch was just to reserve this vendor officially so that no other
company will use it.
Am I wrong with this way to proceed ?

Best regards

Gilles

>
> <form letter>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC (and consider --no-git-fallback argument, so you will
> not CC people just because they made one commit years ago). It might
> happen, that command when run on an older kernel, gives you outdated
> entries. Therefore please be sure you base your patches on recent Linux
> kernel.
>
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
> </form letter>
>
> Best regards,
> Krzysztof
> .
>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] dt-bindings: vendor-prefixes: add kfr prefix
  2025-11-14  9:23   ` Gilles BULOZ
@ 2025-11-14  9:32     ` Krzysztof Kozlowski
  2025-11-14 10:19       ` Gilles BULOZ
  0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-11-14  9:32 UTC (permalink / raw)
  To: Gilles BULOZ, Rob Herring; +Cc: devicetree

On 14/11/2025 10:23, Gilles BULOZ wrote:
> Le 14/11/2025 à 09:40, Krzysztof Kozlowski a écrit :
> 
>> [Vous ne recevez pas souvent de courriers de krzk@kernel.org. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>>
>> On 14/11/2025 08:53, Gilles BULOZ wrote:
>>> Add kfr vendor prefix for Kontron France, which is a single-board
>>> computer (SBC) manufacturer.
>> There is no user for this.
> 
> Hi Krzysztof,
> 
> Yes, there's no user for vendor "kfr" in kernel tree, but Kontron has
> produced some ARM boards (VM6103,VX3106,VX6124,VX3124) on which we
> ported uboot and added some entries in device tree for board specific
> devices (CPLD) using vendor "kfr". We also provide a Linux BSP for these
> boards with drivers using compatible = kfr,<cpldchip>.
> My patch was just to reserve this vendor officially so that no other

You have entire commit msg to explain unusual things. Your commit msg
must explain WHY you are doing it so we know WHY we would want to accept
that patch. If you do not want to convince me why I want this patch
then... I don't want that patch (please watch Greg's talk titled that way).

Anyway, you cannot "reserve" prefix. You must reference here the
upstream user, if it is not obvious.

Plus I am pretty sure Kontron already has prefix and there is no point
for another one. How many companies Samsung has? 10? 20? How many prefixes?


> company will use it.
> Am I wrong with this way to proceed ?
> 
> Best regards
> 
> Gilles
> 
>>
>> <form letter>
>> Please use scripts/get_maintainers.pl to get a list of necessary people
>> and lists to CC (and consider --no-git-fallback argument, so you will
>> not CC people just because they made one commit years ago). It might
>> happen, that command when run on an older kernel, gives you outdated
>> entries. Therefore please be sure you base your patches on recent Linux
>> kernel.
>>
>> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
>> people, so fix your workflow. Tools might also fail if you work on some
>> ancient tree (don't, instead use mainline) or work on fork of kernel
>> (don't, instead use mainline). Just use b4 and everything should be
>> fine, although remember about `b4 prep --auto-to-cc` if you added new
>> patches to the patchset.

And this part you ignored or accepted?

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] dt-bindings: vendor-prefixes: add kfr prefix
  2025-11-14  9:32     ` Krzysztof Kozlowski
@ 2025-11-14 10:19       ` Gilles BULOZ
  2025-11-14 10:25         ` Krzysztof Kozlowski
  0 siblings, 1 reply; 6+ messages in thread
From: Gilles BULOZ @ 2025-11-14 10:19 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Rob Herring; +Cc: devicetree

Le 14/11/2025 à 10:32, Krzysztof Kozlowski a écrit :

> On 14/11/2025 10:23, Gilles BULOZ wrote:
>> Le 14/11/2025 à 09:40, Krzysztof Kozlowski a écrit :
>>
>>>
>>> On 14/11/2025 08:53, Gilles BULOZ wrote:
>>>> Add kfr vendor prefix for Kontron France, which is a single-board
>>>> computer (SBC) manufacturer.
>>> There is no user for this.
>> Hi Krzysztof,
>>
>> Yes, there's no user for vendor "kfr" in kernel tree, but Kontron has
>> produced some ARM boards (VM6103,VX3106,VX6124,VX3124) on which we
>> ported uboot and added some entries in device tree for board specific
>> devices (CPLD) using vendor "kfr". We also provide a Linux BSP for these
>> boards with drivers using compatible = kfr,<cpldchip>.
>> My patch was just to reserve this vendor officially so that no other
> You have entire commit msg to explain unusual things. Your commit msg
> must explain WHY you are doing it so we know WHY we would want to accept
> that patch. If you do not want to convince me why I want this patch
> then... I don't want that patch (please watch Greg's talk titled that way).

Sorry, I had a look to the mailing list archive and did as another developer
did to have a vendor added to the list, but his patch also added new drivers
using this vendor, unlike mine.

I also did not understand you answer "there is no user for this" but I
guessed, I hope right.

>
> Anyway, you cannot "reserve" prefix. You must reference here the
> upstream user, if it is not obvious.

With "upstream user", do you mean a driver in the official kernel tree ?
In this case there's none : we provide our drivers out-of-tree in a BSP package.

>
> Plus I am pretty sure Kontron already has prefix and there is no point
> for another one. How many companies Samsung has? 10? 20? How many prefixes?

Yes there's already "Kontron S&T AG" but as Kontron France is making very
specific products, I thought this was possible to have a different vendor as
for ACPI/PNP ID registry where Kontron has four entries. Maybe this rule is
written somewhere but I was not aware and did not see device-tree vendors as
a rare resource.

>
>> company will use it.
>> Am I wrong with this way to proceed ?
>>
>> Best regards
>>
>> Gilles
>>
>>> <form letter>
>>> Please use scripts/get_maintainers.pl to get a list of necessary people
>>> and lists to CC (and consider --no-git-fallback argument, so you will
>>> not CC people just because they made one commit years ago). It might
>>> happen, that command when run on an older kernel, gives you outdated
>>> entries. Therefore please be sure you base your patches on recent Linux
>>> kernel.
>>>
>>> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
>>> people, so fix your workflow. Tools might also fail if you work on some
>>> ancient tree (don't, instead use mainline) or work on fork of kernel
>>> (don't, instead use mainline). Just use b4 and everything should be
>>> fine, although remember about `b4 prep --auto-to-cc` if you added new
>>> patches to the patchset.
> And this part you ignored or accepted?

Sorry by I did not understand the "from-letter" : I thought this was just
a reminder, not I made a mistake that had to be fixed.

I've already submitted few patches that are now in the mainstream, but as
you can see I'm not an expert in patch submission and I try to do my best.
But up to now I never had a so brutal and negative feedback.
Sorry for the overhead.

>
> Best regards,
> Krzysztof
> .
>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] dt-bindings: vendor-prefixes: add kfr prefix
  2025-11-14 10:19       ` Gilles BULOZ
@ 2025-11-14 10:25         ` Krzysztof Kozlowski
  0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-11-14 10:25 UTC (permalink / raw)
  To: Gilles BULOZ, Rob Herring; +Cc: devicetree

On 14/11/2025 11:19, Gilles BULOZ wrote:
> Le 14/11/2025 à 10:32, Krzysztof Kozlowski a écrit :
> 
>> On 14/11/2025 10:23, Gilles BULOZ wrote:
>>> Le 14/11/2025 à 09:40, Krzysztof Kozlowski a écrit :
>>>
>>>>
>>>> On 14/11/2025 08:53, Gilles BULOZ wrote:
>>>>> Add kfr vendor prefix for Kontron France, which is a single-board
>>>>> computer (SBC) manufacturer.
>>>> There is no user for this.
>>> Hi Krzysztof,
>>>
>>> Yes, there's no user for vendor "kfr" in kernel tree, but Kontron has
>>> produced some ARM boards (VM6103,VX3106,VX6124,VX3124) on which we
>>> ported uboot and added some entries in device tree for board specific
>>> devices (CPLD) using vendor "kfr". We also provide a Linux BSP for these
>>> boards with drivers using compatible = kfr,<cpldchip>.
>>> My patch was just to reserve this vendor officially so that no other
>> You have entire commit msg to explain unusual things. Your commit msg
>> must explain WHY you are doing it so we know WHY we would want to accept
>> that patch. If you do not want to convince me why I want this patch
>> then... I don't want that patch (please watch Greg's talk titled that way).
> 
> Sorry, I had a look to the mailing list archive and did as another developer
> did to have a vendor added to the list, but his patch also added new drivers
> using this vendor, unlike mine.
> 
> I also did not understand you answer "there is no user for this" but I
> guessed, I hope right.
> 
>>
>> Anyway, you cannot "reserve" prefix. You must reference here the
>> upstream user, if it is not obvious.
> 
> With "upstream user", do you mean a driver in the official kernel tree ?
> In this case there's none : we provide our drivers out-of-tree in a BSP package.

Upstream user, or user in this context, is any upstream open-source
project using these bindings or in-kernel DTS.

out-of-tree forks are not upstream, thus does not count here, sorry.


> 
>>
>> Plus I am pretty sure Kontron already has prefix and there is no point
>> for another one. How many companies Samsung has? 10? 20? How many prefixes?
> 
> Yes there's already "Kontron S&T AG" but as Kontron France is making very
> specific products, I thought this was possible to have a different vendor as
> for ACPI/PNP ID registry where Kontron has four entries. Maybe this rule is
> written somewhere but I was not aware and did not see device-tree vendors as
> a rare resource.

One prefix is just enough, there are no benefits usually of having more.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-11-14 10:25 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-14  7:53 [PATCH] dt-bindings: vendor-prefixes: add kfr prefix Gilles BULOZ
2025-11-14  8:40 ` Krzysztof Kozlowski
2025-11-14  9:23   ` Gilles BULOZ
2025-11-14  9:32     ` Krzysztof Kozlowski
2025-11-14 10:19       ` Gilles BULOZ
2025-11-14 10:25         ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).