From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
vkoul@kernel.org, yung-chuan.liao@linux.intel.com
Cc: andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, sanyog.r.kale@intel.com,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 6/6] soundwire: qcom: add support for v1.7 Soundwire Controller
Date: Thu, 27 Oct 2022 11:19:28 +0100 [thread overview]
Message-ID: <619a829e-d902-eba9-537e-176a8acb149c@linaro.org> (raw)
In-Reply-To: <e3ebba30-65ec-183a-eb91-c5147c28441d@linux.intel.com>
Hi Pierre,
On 26/10/2022 21:14, Pierre-Louis Bossart wrote:
>
>> @@ -1582,6 +1597,7 @@ static const struct of_device_id qcom_swrm_of_match[] = {
>> { .compatible = "qcom,soundwire-v1.3.0", .data = &swrm_v1_3_data },
>> { .compatible = "qcom,soundwire-v1.5.1", .data = &swrm_v1_5_data },
>> { .compatible = "qcom,soundwire-v1.6.0", .data = &swrm_v1_6_data },
>> + { .compatible = "qcom,soundwire-v1.7.0", .data = &swrm_v1_5_data },
>
> is this line intentional, it looks odd that 1.7 is compatible with 1.5,
> but 1.6 isn't?
This is more around the data rather than compatible, 1.6 data is marked
with sw_clk_gate_required = true which is not the case with 1.7.
from 1.5 we use same frame shape info for 1.6, 1.7, except that 1.6 had
this sw_clk_gate_required flag set.
--srini
>
next prev parent reply other threads:[~2022-10-27 10:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 11:02 [PATCH 0/6] soundwire: qcom: fixes and support for v1.7 Srinivas Kandagatla
2022-10-26 11:02 ` [PATCH 1/6] soundwire: qcom: reinit broadcast completion Srinivas Kandagatla
2022-10-26 11:02 ` [PATCH 2/6] soundwire: qcom: check for outanding writes before doing a read Srinivas Kandagatla
2022-10-26 11:02 ` [PATCH 3/6] soundwire: qcom: remove unused SWRM_SPECIAL_CMD_ID Srinivas Kandagatla
2022-10-26 11:02 ` [PATCH 4/6] soundwire: qcom: make reset optional for v1.6 controller Srinivas Kandagatla
2022-10-26 11:02 ` [PATCH 5/6] dt-bindings: soundwire: qcom: add v1.7.0 support Srinivas Kandagatla
2022-10-26 14:28 ` Krzysztof Kozlowski
2022-10-26 11:02 ` [PATCH 6/6] soundwire: qcom: add support for v1.7 Soundwire Controller Srinivas Kandagatla
2022-10-26 20:14 ` Pierre-Louis Bossart
2022-10-27 10:19 ` Srinivas Kandagatla [this message]
2022-10-27 12:45 ` Pierre-Louis Bossart
2022-10-28 11:31 ` [PATCH 0/6] soundwire: qcom: fixes and support for v1.7 Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=619a829e-d902-eba9-537e-176a8acb149c@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).