From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1843EC67871 for ; Thu, 27 Oct 2022 10:19:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235246AbiJ0KTo (ORCPT ); Thu, 27 Oct 2022 06:19:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235268AbiJ0KTn (ORCPT ); Thu, 27 Oct 2022 06:19:43 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A7131167 for ; Thu, 27 Oct 2022 03:19:35 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id c3-20020a1c3503000000b003bd21e3dd7aso3786647wma.1 for ; Thu, 27 Oct 2022 03:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=p3v8EBCOL/pBarxV0ODSGCNmHcX5fEuS/fZKHlL3Tpw=; b=gKA2dW3fJ2rFkjzoulrUEa0ZDzOT0UEWyrFD/SIlWhEb6Whcmyl6CQAToGDwyRWYIJ L256X0v3MeZ37S0/8KOzsxMjhEGFBmJJDa3AxZR6Q2WocPGUKDteY2MxuuKoDQdgzV/M 5HMuHkRSrZgeZFcaC9hGoL/xffJEUk944P8pq6u/+WeCzeApEbiuAX7XQWGNkpbo3PoL ymvNPOx4jvD+0ZlMbF1UJPli0/VxcBsd6pf4ScXWLGf8clXlSjovCcPOLlrO9+85LmpL ysiq4xEo4G50hftAGd4vfdz3bH9w49ipcSdKOwEX4oZbEiSZJF9QmdTGDZE9Gun1Lkur uEIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=p3v8EBCOL/pBarxV0ODSGCNmHcX5fEuS/fZKHlL3Tpw=; b=ns5lL4d7PvxO1iMMPPNOgiYl1Djbl/wfGAWmhvB+V0cDm5y0d7a4sRmShiQ0fd3LGQ Abdf23shFY3DqE8MdUKo+mDbVhXjdSQ9Q3wmbOM0g8YfWJV5QvFUZY8xDxr0RD8X2BrW weRY06IYvp1gcNCM1lNkQx85unyTghIoKSp0eCA6Wpe8euBQ8d/4T5PJLkkJG0LNPN/c f+xUZvdt0B3Ci8MokhntyGZwVI7UI4+OagHwEUrLRQTI1TN8XkTgULuRYU+OeqEWRVtT s8It3JV5CEAW7TUMKWZGgbiSkPqe5gkdFlQ+hTCOjCtMnz0NrktE1n7zR8kfafk++0nP 6Axg== X-Gm-Message-State: ACrzQf0zYS/ylsiydDLf709rsxFUI2enoJRiZtyzxuuCpHuQIzgg/Ict 7KcPqoyZWleDTfwvdeXIrAnBr/LM9crHkg== X-Google-Smtp-Source: AMsMyM7Z0QwLULgwz0dq3qhv6BQb+6iwiHd/mM4Ad8Zaf10YeEBPSMLE6J0xqkKIeai1eHLPuCoM9g== X-Received: by 2002:a05:600c:1c9d:b0:3c5:8081:1fc4 with SMTP id k29-20020a05600c1c9d00b003c580811fc4mr5425907wms.161.1666865974182; Thu, 27 Oct 2022 03:19:34 -0700 (PDT) Received: from [192.168.1.194] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id l3-20020a05600c4f0300b003a5f3f5883dsm4703642wmq.17.2022.10.27.03.19.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Oct 2022 03:19:33 -0700 (PDT) Message-ID: <619a829e-d902-eba9-537e-176a8acb149c@linaro.org> Date: Thu, 27 Oct 2022 11:19:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 6/6] soundwire: qcom: add support for v1.7 Soundwire Controller Content-Language: en-US To: Pierre-Louis Bossart , vkoul@kernel.org, yung-chuan.liao@linux.intel.com Cc: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, sanyog.r.kale@intel.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org References: <20221026110210.6575-1-srinivas.kandagatla@linaro.org> <20221026110210.6575-7-srinivas.kandagatla@linaro.org> From: Srinivas Kandagatla In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Pierre, On 26/10/2022 21:14, Pierre-Louis Bossart wrote: > >> @@ -1582,6 +1597,7 @@ static const struct of_device_id qcom_swrm_of_match[] = { >> { .compatible = "qcom,soundwire-v1.3.0", .data = &swrm_v1_3_data }, >> { .compatible = "qcom,soundwire-v1.5.1", .data = &swrm_v1_5_data }, >> { .compatible = "qcom,soundwire-v1.6.0", .data = &swrm_v1_6_data }, >> + { .compatible = "qcom,soundwire-v1.7.0", .data = &swrm_v1_5_data }, > > is this line intentional, it looks odd that 1.7 is compatible with 1.5, > but 1.6 isn't? This is more around the data rather than compatible, 1.6 data is marked with sw_clk_gate_required = true which is not the case with 1.7. from 1.5 we use same frame shape info for 1.6, 1.7, except that 1.6 had this sw_clk_gate_required flag set. --srini >