devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tony Lindgren <tony@atomide.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Simha BN <simhavcs@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Michael Walle <mwalle@kernel.org>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 03/10] dt-bindings: display: bridge: tc358775: Add support for tc358765
Date: Thu, 15 Feb 2024 19:43:05 +0100	[thread overview]
Message-ID: <61a6b5a8-7dbf-4b37-9f6e-1bd85dc5f7b5@linaro.org> (raw)
In-Reply-To: <20240215123222.42609-4-tony@atomide.com>

On 15/02/2024 13:31, Tony Lindgren wrote:
> The tc358765 is similar to tc358775. The tc358765 just an earlier version
> of the hardware, and it's pin and register compatible with tc358775 for
> most part.
> 
> From the binding point of view the only difference is that the tc358765
> does not have stdby-gpios.
> 
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
>  .../display/bridge/toshiba,tc358775.yaml         | 16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml
> --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml
> @@ -10,7 +10,7 @@ maintainers:
>    - Vinay Simha BN <simhavcs@gmail.com>
>  
>  description: |
> -  This binding supports DSI to LVDS bridge TC358775
> +  This binding supports DSI to LVDS bridges TC358765 and TC358775
>  
>    MIPI DSI-RX Data 4-lane, CLK 1-lane with data rates up to 800 Mbps/lane.
>    Video frame size:
> @@ -21,7 +21,9 @@ description: |
>  
>  properties:
>    compatible:
> -    const: toshiba,tc358775
> +    enum:
> +      - toshiba,tc358765
> +      - toshiba,tc358775
>  
>    reg:
>      maxItems: 1
> @@ -81,6 +83,16 @@ properties:
>        - port@0
>        - port@1
>  
> +allOf:

If there is going to be new version, please put allOf: block after
required: block.

Anyway:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


  reply	other threads:[~2024-02-15 18:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-15 12:31 [PATCH v4 00/10] Improvments for tc358775 with support for tc358765 Tony Lindgren
2024-02-15 12:31 ` [PATCH v4 01/10] dt-bindings: display: bridge: tc358775: make stby gpio optional Tony Lindgren
2024-02-15 12:31 ` [PATCH v4 02/10] dt-bindings: display: bridge: tc358775: Add data-lanes Tony Lindgren
2024-02-15 12:31 ` [PATCH v4 03/10] dt-bindings: display: bridge: tc358775: Add support for tc358765 Tony Lindgren
2024-02-15 18:43   ` Krzysztof Kozlowski [this message]
2024-02-25  6:11     ` Tony Lindgren
2024-02-15 12:31 ` [PATCH v4 04/10] drm/bridge: tc358775: fix support for jeida-18 and jeida-24 Tony Lindgren
2024-02-15 12:31 ` [PATCH v4 05/10] drm/bridge: tc358775: make standby GPIO optional Tony Lindgren
2024-02-15 12:31 ` [PATCH v4 06/10] drm/bridge: tc358775: Get bridge data lanes instead of the DSI host lanes Tony Lindgren
2024-02-15 12:31 ` [PATCH v4 07/10] drm/bridge: tc358775: Add burst and low-power modes Tony Lindgren
2024-02-15 12:31 ` [PATCH v4 08/10] drm/bridge: tc358775: Enable pre_enable_prev_first flag Tony Lindgren
2024-02-15 12:31 ` [PATCH v4 09/10] drm/bridge: tc358775: Add support for tc358765 Tony Lindgren
2024-02-15 12:31 ` [PATCH v4 10/10] drm/bridge: tc358775: Configure hs_rate and lp_rate Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61a6b5a8-7dbf-4b37-9f6e-1bd85dc5f7b5@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=mwalle@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=simhavcs@gmail.com \
    --cc=tony@atomide.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).