From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [RFC resend 1/4] dt-bindings: display: mediatek: add drm binding Date: Thu, 19 Oct 2017 16:36:09 +0200 Message-ID: <61b146fe-da63-0eeb-f55a-00bd2499d38f@suse.com> References: <20171019112610.13645-1-mbrugger@suse.com> <20171019112610.13645-2-mbrugger@suse.com> <1508415566.5287.10.camel@mtkswgap22> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1508415566.5287.10.camel@mtkswgap22> Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ryder Lee , Matthias Brugger Cc: ulrich.hecht+renesas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org, ck.hu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, airlied-cv59FeDIM0c@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 10/19/2017 02:19 PM, Ryder Lee wrote: > Hi Matthias, > > Should I base on your changes and resend this patch series > https://patchwork.kernel.org/patch/9980061/ ? > > I add a similar node - display_components, but your approach is better > than mine. > You series should have the same issue as the Ulrich sees on the chromebook. Basically you have two nodes which both bind to mediatek,mt7623-mmsys. The only difference here is, that your clock drivers is a builtin_platform_driver while on mt8173 it get's probed earlier as it is defined as CLK_OF_DECLARE. Do you see both drivers getting probed? I don't have my mt7623 board at hand right now to check this. In any case, please wait until we found a way to fix the issue before we add these bindings. Regards, Matthias PS @ryder: I have the rest of the series on my radar, between today and tomorrow I will look into this > Thanks. > > On Thu, 2017-10-19 at 13:26 +0200, Matthias Brugger wrote: >> DRM subysystem and clock driver shared the same compatible mmsys. >> This stopped does not work, as only the first driver for a compatible >> gets probed. We change the comaptible to the new DRM identifier to fix >> this. >> >> Signed-off-by: Matthias Brugger >> --- >> .../devicetree/bindings/display/mediatek/mediatek,disp.txt | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt >> index 383183a89164..6db652463e64 100644 >> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt >> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt >> @@ -27,6 +27,7 @@ Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt. >> >> Required properties (all function blocks): >> - compatible: "mediatek,-disp-", one of >> + "mediatek,-dispsys" - central component for the DRM system >> "mediatek,-disp-ovl" - overlay (4 layers, blending, csc) >> "mediatek,-disp-rdma" - read DMA / line buffer >> "mediatek,-disp-wdma" - write DMA >> @@ -71,6 +72,11 @@ mmsys: clock-controller@14000000 { >> #clock-cells = <1>; >> }; >> >> +dispsys: display-system { >> + compatible = "mediatek,mt2701-dispsys"; >> + mediatek,mmsys = <&mmsys>; >> +} >> + >> ovl0: ovl@1400c000 { >> compatible = "mediatek,mt8173-disp-ovl"; >> reg = <0 0x1400c000 0 0x1000>; > > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html