From: Junhao Xie <bigfoot@classfun.cn>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>, Jonas Karlman <jonas@kwiboo.se>,
Chukun Pan <amadeus@jmu.edu.cn>, FUKAUMI Naoki <naoki@radxa.com>,
Dragan Simic <dsimic@manjaro.org>,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Junhao Xie <bigfoot@classfun.cn>
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568
Date: Thu, 5 Sep 2024 19:06:53 +0800 [thread overview]
Message-ID: <61bccef8-8cb1-4224-accd-0468e8892b91@classfun.cn> (raw)
In-Reply-To: <20240905100100.348444-1-amadeus@jmu.edu.cn>
On 2024/9/5 18:01, Chukun Pan wrote:
> Hi Junhao,
>
>>>> + vcc5v0_usb_modem: regulator-5v0-vcc-usb-modem {
>>>
>>> Are you sure this regulator is 5v?
>>>
>>
>> It should actually be 3.3V, I will fix it and rename
>> to vcc3v3_usb_modem
>
> I prefer vcc3v3_rf or vcc3v3_ngff,
> this is closer to the schematics.
>
Yes, I changed it to vcc3v3_rf, this is the name used in the schematics.
>>>> + pinctrl-names = "default";
>>>> + pinctrl-0 = <&pcie30x2m1_pins>;
>>>
>>> These are actually pcie30x1m0_pins.
>>
>> pcie30x1m0_pins seems to conflict with sdmmc0,
>> I changed it to pcie30x1m1_pins
>
> This is obviously incorrect. I didn't notice that
> your pinctrl for sdmmc0 is wrong.
> (Because the cd pin are different)
After fixing sdmmc0, using pcie30x1m0_pins can work normally.
Best regards,
Junhao
next prev parent reply other threads:[~2024-09-05 11:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 11:14 [PATCH 0/3] Add support for Ariaboard Photonicat RK3568 Junhao Xie
2024-09-04 11:14 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add Shanghai Novotech Ariaboard Junhao Xie
2024-09-04 11:35 ` Krzysztof Kozlowski
2024-09-04 12:14 ` Junhao Xie
2024-09-04 13:29 ` Krzysztof Kozlowski
2024-09-05 5:22 ` Junhao Xie
2024-09-04 11:14 ` [PATCH 2/3] dt-bindings: arm: rockchip: Add Ariaboard Photonicat RK3568 Junhao Xie
2024-09-04 11:36 ` Krzysztof Kozlowski
2024-09-04 11:14 ` [PATCH 3/3] arm64: dts: rockchip: add dts for " Junhao Xie
2024-09-04 17:25 ` Andrew Lunn
2024-09-05 5:47 ` Junhao Xie
2024-09-05 11:17 ` Junhao Xie
2024-09-05 12:53 ` Andrew Lunn
2024-09-05 18:01 ` Junhao Xie
2024-09-05 18:20 ` Andrew Lunn
2024-09-06 3:50 ` Chukun Pan
2024-09-06 4:13 ` Junhao Xie
2024-09-05 3:40 ` Chukun Pan
2024-09-05 9:17 ` Junhao Xie
2024-09-05 10:01 ` Chukun Pan
2024-09-05 11:06 ` Junhao Xie [this message]
2024-09-04 13:36 ` [PATCH 0/3] Add support " Rob Herring (Arm)
2024-09-05 5:37 ` Junhao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61bccef8-8cb1-4224-accd-0468e8892b91@classfun.cn \
--to=bigfoot@classfun.cn \
--cc=amadeus@jmu.edu.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=naoki@radxa.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox