From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BC35158A00; Tue, 25 Jun 2024 13:40:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719322846; cv=none; b=ioDRk43B4JRjt68vpgK6pIqIVcw8adF6Qyv6/UE36hLHK+V7TMnKI8JqK7OywpNyIn7u1VI44CD1Zr02knk1RI14tS1Cc+ykCw6CxoiHeWcgZXMVmc5o2zFXMVH5c8PQSV8L8qg9QidISE3ckQ1IavJorZ5U0SgPHXZAO7wloCI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719322846; c=relaxed/simple; bh=qqL9H/PknuuatuNzziRQ+FebZ99lyT6kuZqHItV5Ww4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f04Wuq/S+toSgELV522YvqeVir0IJJDEVyfooY65gIvWkhvlYLYKnT6QRs8KmpTgnsHqYHCjNES4ttrKil2Q8XSRGFp+EDGV1sEeuLO31I0Ekvl2Qu8LYLpL4BVBkyyt5gbb9KpvhXrZQ7E015uujXFBvRouWAi/MtXpKEl88Nw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rlLSLdq3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rlLSLdq3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64798C32781; Tue, 25 Jun 2024 13:40:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719322845; bh=qqL9H/PknuuatuNzziRQ+FebZ99lyT6kuZqHItV5Ww4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=rlLSLdq3twIEHLzTSuumicRspbGsq/HY45vpRM5l1iDd42JNHj/JPRXVsNTG6i9nE VjMgEFYUWIq+H5aVURxEHilrCoRuIDNwUhaJUPJsE5E3cb4keNM5X7FDC1sqPC5sxa iMmnvY4WRB17y67/vZVdnV2y9FR+9lGOm+495pytrGeU0Hn4OyyXURhdrTSaykp+Z9 G3b8yv0EM2ZKqarIqJ1cXDqzKJfcpbVMRA9ng0L3ot0yNuBAxwFH+UFKb88r6wiXFY msm+Sz+SCqFAAN2GAwnJ76RpudNLrSLhhTR2lpWI11KP25rwIjkhHlMhr0MiDPxDNT S2ysIKZOzcWNg== Message-ID: <61c1eb8b-b8fd-4e9e-b0fc-27ce1c2eb2b1@kernel.org> Date: Tue, 25 Jun 2024 15:40:39 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] clk: imx93: Drop macro IMX93_CLK_END To: Pengfei Li Cc: krzk+dt@kernel.org, robh@kernel.org, abelvesa@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, ping.bai@nxp.com, ye.li@nxp.com, peng.fan@nxp.com, aisheng.dong@nxp.com, frank.li@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-clk@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240625175147.94985-1-pengfei.li_1@nxp.com> <20240625175147.94985-2-pengfei.li_1@nxp.com> <39bcab8b-ed9c-4da9-b1ee-32dbfb2a23a4@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 25/06/2024 12:43, Pengfei Li wrote: > On Tue, Jun 25, 2024 at 09:44:42AM +0200, Krzysztof Kozlowski wrote: >> On 25/06/2024 19:51, Pengfei Li wrote: >>> IMX93_CLK_END was previously defined in imx93-clock.h to >>> indicate the number of clocks, but it is not part of the >>> ABI, so it should be dropped. >>> >>> Now, the driver gets the number of clks by querying the >>> maximum index in the clk array. Due to the discontinuity >>> in the definition of clk index, with some gaps present, >>> the total count cannot be obtained by summing the array >>> size. >>> >>> Signed-off-by: Pengfei Li >>> --- >>> drivers/clk/imx/clk-imx93.c | 25 +++++++++++++++++++++---- >>> 1 file changed, 21 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c >>> index c6a9bc8ecc1f..68c929512e16 100644 >>> --- a/drivers/clk/imx/clk-imx93.c >>> +++ b/drivers/clk/imx/clk-imx93.c >>> @@ -257,6 +257,20 @@ static const struct imx93_clk_ccgr { >>> static struct clk_hw_onecell_data *clk_hw_data; >>> static struct clk_hw **clks; >>> >>> +static int imx_clks_get_num(void) >>> +{ >>> + u32 val = 0; >>> + int i; >>> + >>> + for (i = 0; i < ARRAY_SIZE(root_array); i++) >>> + val = max_t(u32, val, root_array[i].clk); >>> + >>> + for (i = 0; i < ARRAY_SIZE(ccgr_array); i++) >>> + val = max_t(u32, val, ccgr_array[i].clk); >>> + >>> + return val + 1; >>> +} >>> + >>> static int imx93_clocks_probe(struct platform_device *pdev) >>> { >>> struct device *dev = &pdev->dev; >>> @@ -264,14 +278,17 @@ static int imx93_clocks_probe(struct platform_device *pdev) >>> const struct imx93_clk_root *root; >>> const struct imx93_clk_ccgr *ccgr; >>> void __iomem *base, *anatop_base; >>> + int clks_num; >>> int i, ret; >>> >>> + clks_num = imx_clks_get_num(); >>> + >>> clk_hw_data = devm_kzalloc(dev, struct_size(clk_hw_data, hws, >>> - IMX93_CLK_END), GFP_KERNEL); >>> + clks_num), GFP_KERNEL); >>> if (!clk_hw_data) >>> return -ENOMEM; >>> >>> - clk_hw_data->num = IMX93_CLK_END; >>> + clk_hw_data->num = clks_num; >> >> Why so complicated code instead of pre-processor define or array size? >> >> Best regards, >> Krzysztof >> >> > > Hi Krzysztof, > > Thanks for the comment, here are some of our thoughts. > > Regarding the predefined method, it's easy to forget to update the macro definition when adding some new clocks to > imx93-clock.h in the future. Somehow most developers in most platforms can do it... Anyway, that would be build time detectable so no problem at all. > > Also, we cannot use the array size method in this scenario, as some unnecessary clocks have been removed in the past, > resulting in discontinuous definitions of clock indexes. This means that the maximum clock index can be larger than > the allocated clk_hw array size. At this point, using the maximum index to access the clk_hw array will result in an > out of bounds error. You mix bindings with array entries. That's independent or just clock drivers are broken. Best regards, Krzysztof