From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Luca Weiss <luca.weiss@fairphone.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Iskren Chernev <me@iskren.info>
Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] arm64: dts: qcom: sm6115: Add missing reg-names property for UFS
Date: Fri, 30 Dec 2022 10:12:48 +0100 [thread overview]
Message-ID: <61cb9bab-aefb-cd45-acb0-ef846a411d76@linaro.org> (raw)
In-Reply-To: <20221209-dt-binding-ufs-v2-1-dc7a04699579@fairphone.com>
On 30.12.2022 08:42, Luca Weiss wrote:
> The UFS driver expects the second reg to be named "ice" otherwise the
> Inline Crypto Engine won't get enabled.
>
> Fixes: 97e563bf5ba1 ("arm64: dts: qcom: sm6115: Add basic soc dtsi")
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=for-next&id=01b6041454e8bc4f5feb76e6bcdc83a48cea21f2
Konrad
> arch/arm64/boot/dts/qcom/sm6115.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> index 572bf04adf90..85673d562723 100644
> --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> @@ -704,6 +704,7 @@ opp-202000000 {
> ufs_mem_hc: ufs@4804000 {
> compatible = "qcom,sm6115-ufshc", "qcom,ufshc", "jedec,ufs-2.0";
> reg = <0x04804000 0x3000>, <0x04810000 0x8000>;
> + reg-names = "std", "ice";
> interrupts = <GIC_SPI 356 IRQ_TYPE_LEVEL_HIGH>;
> phys = <&ufs_mem_phy_lanes>;
> phy-names = "ufsphy";
>
next prev parent reply other threads:[~2022-12-30 9:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-30 7:42 [PATCH v2 0/3] Fix some issues in QCOM UFS bindings Luca Weiss
2022-12-30 7:42 ` [PATCH v2 1/3] arm64: dts: qcom: sm6115: Add missing reg-names property for UFS Luca Weiss
2022-12-30 9:12 ` Konrad Dybcio [this message]
2022-12-30 9:17 ` Luca Weiss
2022-12-30 7:42 ` [PATCH v2 2/3] dt-bindings: ufs: qcom: Add reg-names property for ICE Luca Weiss
2022-12-30 7:54 ` Krzysztof Kozlowski
2022-12-30 7:42 ` [PATCH v2 3/3] dt-bindings: ufs: qcom: Fix sm8450 bindings Luca Weiss
2022-12-30 7:54 ` Krzysztof Kozlowski
2022-12-30 16:34 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61cb9bab-aefb-cd45-acb0-ef846a411d76@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=me@iskren.info \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox