From: Ansuel Smith <ansuelsmth@gmail.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Taniya Das <tdas@codeaurora.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 11/15] dt-bindings: clock: add ipq8064 ce5 clk define
Date: Tue, 25 Jan 2022 22:02:59 +0100 [thread overview]
Message-ID: <61f06586.1c69fb81.890c7.4462@mx.google.com> (raw)
In-Reply-To: <20220125204727.D3BC8C340E0@smtp.kernel.org>
On Tue, Jan 25, 2022 at 12:47:26PM -0800, Stephen Boyd wrote:
> Quoting Ansuel Smith (2022-01-21 13:03:36)
> > Add ipq8064 ce5 clk define needed for CryptoEngine in gcc driver.
> >
> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > ---
> > include/dt-bindings/clock/qcom,gcc-ipq806x.h | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/dt-bindings/clock/qcom,gcc-ipq806x.h b/include/dt-bindings/clock/qcom,gcc-ipq806x.h
> > index 7deec14a6dee..02262d2ac899 100644
> > --- a/include/dt-bindings/clock/qcom,gcc-ipq806x.h
> > +++ b/include/dt-bindings/clock/qcom,gcc-ipq806x.h
> > @@ -240,7 +240,7 @@
> > #define PLL14 232
> > #define PLL14_VOTE 233
> > #define PLL18 234
> > -#define CE5_SRC 235
> > +#define CE5_A_CLK 235
>
> Technically this is ABI and changing it is bad. I see that CE5_SRC isn't
> used though so I guess it's OK.
>
Consider that this naming comes directly from qsdk so I really don't
know why it was called SRC from the start.
> > #define CE5_H_CLK 236
> > #define CE5_CORE_CLK 237
> > #define CE3_SLEEP_CLK 238
> > @@ -283,5 +283,8 @@
> > #define EBI2_AON_CLK 281
> > #define NSSTCM_CLK_SRC 282
> > #define NSSTCM_CLK 283
> > +#define CE5_A_CLK_SRC 285
> > +#define CE5_H_CLK_SRC 286
> > +#define CE5_CORE_CLK_SRC 287
--
Ansuel
next prev parent reply other threads:[~2022-01-25 21:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 21:03 [PATCH v3 00/15] Multiple addition and improvement to ipq8064 gcc Ansuel Smith
2022-01-21 21:03 ` [PATCH v3 01/15] dt-bindings: clock: split qcom,gcc.yaml to common and specific schema Ansuel Smith
2022-01-31 23:11 ` Bjorn Andersson
2022-02-01 21:53 ` Ansuel Smith
2022-01-21 21:03 ` [PATCH v3 02/15] dt-bindings: clock: simplify qcom,gcc-apq8064 Documentation Ansuel Smith
2022-01-21 21:03 ` [PATCH v3 03/15] dt-bindings: clock: Document qcom,gcc-ipq8064 binding Ansuel Smith
2022-01-21 21:03 ` [PATCH v3 04/15] drivers: clk: qcom: gcc-ipq806x: fix wrong naming for gcc_pxo_pll8_pll0 Ansuel Smith
2022-01-31 23:13 ` Bjorn Andersson
2022-01-21 21:03 ` [PATCH v3 05/15] drivers: clk: qcom: gcc-ipq806x: convert parent_names to parent_data Ansuel Smith
2022-01-21 21:03 ` [PATCH v3 06/15] drivers: clk: qcom: gcc-ipq806x: use ARRAY_SIZE for num_parents Ansuel Smith
2022-01-21 21:03 ` [PATCH v3 07/15] drivers: clk: qcom: gcc-ipq806x: drop hardcoded pxo and cxo source clk Ansuel Smith
2022-01-21 21:03 ` [PATCH v3 08/15] drivers: clk: qcom: gcc-ipq806x: add additional freq nss cores Ansuel Smith
2022-01-21 21:03 ` [PATCH v3 09/15] drivers: clk: qcom: gcc-ipq806x: add unusued flag for critical clock Ansuel Smith
2022-01-21 21:03 ` [PATCH v3 10/15] drivers: clk: qcom: gcc-ipq806x: add additional freq for sdc table Ansuel Smith
2022-01-25 20:45 ` Stephen Boyd
2022-01-25 21:03 ` Ansuel Smith
2022-01-25 22:18 ` Stephen Boyd
2022-02-01 22:01 ` Ansuel Smith
2022-02-05 3:03 ` Stephen Boyd
2022-01-21 21:03 ` [PATCH v3 11/15] dt-bindings: clock: add ipq8064 ce5 clk define Ansuel Smith
2022-01-25 20:47 ` Stephen Boyd
2022-01-25 21:02 ` Ansuel Smith [this message]
2022-01-21 21:03 ` [PATCH v3 12/15] drivers: clk: qcom: gcc-ipq806x: add CryptoEngine clocks Ansuel Smith
2022-01-21 21:03 ` [PATCH v3 13/15] dt-bindings: reset: add ipq8064 ce5 resets Ansuel Smith
2022-01-21 21:03 ` [PATCH v3 14/15] drivers: clk: qcom: gcc-ipq806x: add CryptoEngine resets Ansuel Smith
2022-01-21 21:03 ` [PATCH v3 15/15] ARM: dts: qcom: Add syscon and cxo/pxo clock to gcc node for ipq8064 Ansuel Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61f06586.1c69fb81.890c7.4462@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).