From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A4C1315BC for ; Tue, 7 Nov 2023 16:56:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WdOImb9T" Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 969AFA2 for ; Tue, 7 Nov 2023 08:56:19 -0800 (PST) Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2c6ef6c1ec2so72394211fa.2 for ; Tue, 07 Nov 2023 08:56:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699376178; x=1699980978; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=kbJ6S/o2GoaTYn/BOJScRNRrTIl3Xt5INY64Fvpcd0w=; b=WdOImb9Thc7ViboWAa/2yHTIWnbQMhe0K7TW3/aVI6Ll3Gjp5hUeQ6MalEKyJngFt0 ows0tkfHBMfK4wXOomt3L2eT1fBpBzBaXt2iLFBRUVxRidXLJj42AfZqtKYn6GOA3xEh XeG4VM82aG4JT3Vy7ct7htAdHeE7f5KHvZDqFmyXIqzzlSZ65bQ4Oz7t3nosHIFI4co5 yp9Cd4Oh9VzRDZrhZ2PtjUMcrhtUC/VbebtGmOTnEET6oJv3rUthOY/lgsrq2w6vIj3c lZZgsEsvp+906bQSByH/AycNLFCG47/y2IAZJyxvRCuPfMoKjyeb27+i3C04r7GOAtaH o4Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699376178; x=1699980978; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kbJ6S/o2GoaTYn/BOJScRNRrTIl3Xt5INY64Fvpcd0w=; b=HsCxYcJe+tBmX6ctXkOXhu/rjuY8KmuZ6mpv9dvQnMB4PhjNeXtzuMTUY0is5euJ3I MF46gIiHNFPkIsM816WdmQuwLh9SvaQSiZFc4RaWW2pjlRJwfk5d3D3JgaAf18Cr53qU styotDpOPoF5XYdO8k0Nl7EYdjGtX0Ypawnib2bRC7qmG3GflwE8oNY81Rae3sSrUn/q YBBQwu3aHCrsX1PLR2yErGvdNnbOrdce5vavxhPOW67r7NS+qEr1VfrhjJNDRd4cxXuc OVLc76CXYmrztY07eFcfJnxouLvsUl/+ynJX5mWVVuRXDWFxrnLRT3LrDyMi1KndfvxT GZmA== X-Gm-Message-State: AOJu0YwL6pkqNg8F1KzUTYV/Dcl9b2Q0mNJ/Uokx4dCabkPYTg0f9IhC OguH9JNcbz/jVLw4j8EkBn3Sgw== X-Google-Smtp-Source: AGHT+IGT4HKeVgMKEcNh4lB9vVupAt3j8/OufFftas5vKACJLEXbG9PIZo6ZyGLgzdDSPdcDTm91iA== X-Received: by 2002:a2e:a789:0:b0:2c5:18ed:180a with SMTP id c9-20020a2ea789000000b002c518ed180amr33150222ljf.33.1699376177720; Tue, 07 Nov 2023 08:56:17 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id ba15-20020a0560001c0f00b0032326908972sm2869551wrb.17.2023.11.07.08.56.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Nov 2023 08:56:17 -0800 (PST) Message-ID: <6210c44e-fd1c-4a60-83d4-d97704f47739@linaro.org> Date: Tue, 7 Nov 2023 17:56:15 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/6] crypto: rockchip: add rk3588 driver Content-Language: en-US From: Krzysztof Kozlowski To: Corentin Labbe , davem@davemloft.net, heiko@sntech.de, herbert@gondor.apana.org.au, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, p.zabel@pengutronix.de, robh+dt@kernel.org, sboyd@kernel.org Cc: ricardo@pardini.net, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org References: <20231107155532.3747113-1-clabbe@baylibre.com> <20231107155532.3747113-7-clabbe@baylibre.com> <07bbb8c3-b6c0-4e5e-8fe9-2fcbb71b7dbc@linaro.org> Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 07/11/2023 17:42, Krzysztof Kozlowski wrote: > On 07/11/2023 17:35, Krzysztof Kozlowski wrote: >> On 07/11/2023 16:55, Corentin Labbe wrote: >>> RK3588 have a new crypto IP, this patch adds basic support for it. >>> Only hashes and cipher are handled for the moment. >>> >>> Signed-off-by: Corentin Labbe >>> --- >>> drivers/crypto/Kconfig | 29 + >>> drivers/crypto/rockchip/Makefile | 5 + >>> drivers/crypto/rockchip/rk2_crypto.c | 739 ++++++++++++++++++ >>> drivers/crypto/rockchip/rk2_crypto.h | 246 ++++++ >>> drivers/crypto/rockchip/rk2_crypto_ahash.c | 344 ++++++++ >>> drivers/crypto/rockchip/rk2_crypto_skcipher.c | 576 ++++++++++++++ >>> 6 files changed, 1939 insertions(+) >>> create mode 100644 drivers/crypto/rockchip/rk2_crypto.c >>> create mode 100644 drivers/crypto/rockchip/rk2_crypto.h >>> create mode 100644 drivers/crypto/rockchip/rk2_crypto_ahash.c >>> create mode 100644 drivers/crypto/rockchip/rk2_crypto_skcipher.c >>> >>> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig >>> index 79c3bb9c99c3..b6a2027b1f9a 100644 >>> --- a/drivers/crypto/Kconfig >>> +++ b/drivers/crypto/Kconfig >>> @@ -660,6 +660,35 @@ config CRYPTO_DEV_ROCKCHIP_DEBUG >>> the number of requests per algorithm and other internal stats. >>> >>> >>> +config CRYPTO_DEV_ROCKCHIP2 >>> + tristate "Rockchip's cryptographic offloader V2" >>> + depends on OF && ARCH_ROCKCHIP >>> + depends on PM >>> + select CRYPTO_ECB >>> + select CRYPTO_CBC >>> + select CRYPTO_AES >>> + select CRYPTO_MD5 >>> + select CRYPTO_SHA1 >>> + select CRYPTO_SHA256 >>> + select CRYPTO_SHA512 >>> + select CRYPTO_SM3_GENERIC >>> + select CRYPTO_HASH >>> + select CRYPTO_SKCIPHER >>> + select CRYPTO_ENGINE >>> + >>> + help >>> + This driver interfaces with the hardware crypto offloader present >>> + on RK3566, RK3568 and RK3588. >>> + >>> +config CRYPTO_DEV_ROCKCHIP2_DEBUG >>> + bool "Enable Rockchip V2 crypto stats" >>> + depends on CRYPTO_DEV_ROCKCHIP2 >>> + depends on DEBUG_FS >>> + help >>> + Say y to enable Rockchip crypto debug stats. >>> + This will create /sys/kernel/debug/rk3588_crypto/stats for displaying >>> + the number of requests per algorithm and other internal stats. >>> + >>> config CRYPTO_DEV_ZYNQMP_AES >>> tristate "Support for Xilinx ZynqMP AES hw accelerator" >>> depends on ZYNQMP_FIRMWARE || COMPILE_TEST >>> diff --git a/drivers/crypto/rockchip/Makefile b/drivers/crypto/rockchip/Makefile >>> index 785277aca71e..452a12ff6538 100644 >>> --- a/drivers/crypto/rockchip/Makefile >>> +++ b/drivers/crypto/rockchip/Makefile >>> @@ -3,3 +3,8 @@ obj-$(CONFIG_CRYPTO_DEV_ROCKCHIP) += rk_crypto.o >>> rk_crypto-objs := rk3288_crypto.o \ >>> rk3288_crypto_skcipher.o \ >>> rk3288_crypto_ahash.o >>> + >>> +obj-$(CONFIG_CRYPTO_DEV_ROCKCHIP2) += rk_crypto2.o >>> +rk_crypto2-objs := rk2_crypto.o \ >>> + rk2_crypto_skcipher.o \ >>> + rk2_crypto_ahash.o >>> diff --git a/drivers/crypto/rockchip/rk2_crypto.c b/drivers/crypto/rockchip/rk2_crypto.c >>> new file mode 100644 >>> index 000000000000..f3b8d27924da >>> --- /dev/null >>> +++ b/drivers/crypto/rockchip/rk2_crypto.c >>> @@ -0,0 +1,739 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> +/* >>> + * hardware cryptographic offloader for RK3568/RK3588 SoC >>> + * >>> + * Copyright (c) 2022-2023, Corentin Labbe >>> + */ >>> + >>> +#include "rk2_crypto.h" >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> + >>> +static struct rockchip_ip rocklist = { >>> + .dev_list = LIST_HEAD_INIT(rocklist.dev_list), >>> + .lock = __SPIN_LOCK_UNLOCKED(rocklist.lock), >> >> Drop it, not needed. > > To clarify: I mean entire structure. ... and I think I was wrong - skcipher_engine_alg and other parts still do not handle device context, so indeed you might need global list. Best regards, Krzysztof