From: "Ceclan, Dumitru" <mitrutzceclan@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
dumitru.ceclan@analog.com
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
David Lechner <dlechner@baylibre.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 9/9] iio: adc: ad7173: Add support for AD411x devices
Date: Mon, 22 Jul 2024 10:14:34 +0300 [thread overview]
Message-ID: <6226f65a-3420-45e0-aeb9-8d31d26a070d@gmail.com> (raw)
In-Reply-To: <04be66d2-de35-4190-ba9d-011b2b639f94@linaro.org>
On 16/07/2024 09:31, Krzysztof Kozlowski wrote:
> On 15/07/2024 19:17, Ceclan, Dumitru wrote:
>>>
>>> Please run scripts/checkpatch.pl and fix reported warnings. Then please
>>> run `scripts/checkpatch.pl --strict` and (probably) fix more warnings.
>>> Some warnings can be ignored, especially from --strict run, but the code
>>> here looks like it needs a fix. Feel free to get in touch if the warning
>>> is not clear.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>> I do not get any warnings, only checks
>>
>> If you meant the checks:
>> - for the alignment check, i would only argue for struct_group(config_props that looks good
>> - for unnecessary parentheses the compiler warning appears without the parentheses:
>> warning: suggest parentheses around comparison in operand of ‘!=’ [-Wparentheses]
>
> Hm, in that case it looks like you documented some entirely different
> bindings?
>
> Best regards,
> Krzysztof
>
On which file checkpatch returned warnings for you?
next prev parent reply other threads:[~2024-07-22 7:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 14:53 [PATCH v7 0/9] Add support for AD411x Dumitru Ceclan via B4 Relay
2024-06-07 14:53 ` [PATCH v7 1/9] dt-bindings: iio: adc: Add common-mode-channel property Dumitru Ceclan via B4 Relay
2024-06-07 14:53 ` [PATCH v7 2/9] dt-bindings: adc: ad7173: add support for ad411x Dumitru Ceclan via B4 Relay
2024-06-07 14:53 ` [PATCH v7 3/9] iio: adc: ad_sigma_delta: add disable_one callback Dumitru Ceclan via B4 Relay
2024-06-07 14:53 ` [PATCH v7 4/9] iio: adc: ad7173: refactor channel configuration parsing Dumitru Ceclan via B4 Relay
2024-06-07 14:53 ` [PATCH v7 5/9] iio: adc: ad7173: refactor ain and vref selection Dumitru Ceclan via B4 Relay
2024-06-10 7:23 ` Nuno Sá
2024-06-10 14:35 ` Nuno Sá
2024-06-07 14:53 ` [PATCH v7 6/9] iio: adc: ad7173: add support for special inputs Dumitru Ceclan via B4 Relay
2024-06-10 7:24 ` Nuno Sá
2024-06-07 14:53 ` [PATCH v7 7/9] iio: adc: ad7173: refactor device info structs Dumitru Ceclan via B4 Relay
2024-06-07 14:53 ` [PATCH v7 8/9] iio: adc: ad7173: document sampling frequency behaviour Dumitru Ceclan via B4 Relay
2024-06-07 14:53 ` [PATCH v7 9/9] iio: adc: ad7173: Add support for AD411x devices Dumitru Ceclan via B4 Relay
2024-06-10 7:27 ` Nuno Sá
2024-07-12 18:23 ` Rob Herring
2024-07-13 10:12 ` Krzysztof Kozlowski
2024-07-15 17:17 ` Ceclan, Dumitru
2024-07-16 6:31 ` Krzysztof Kozlowski
2024-07-22 7:14 ` Ceclan, Dumitru [this message]
2024-06-08 16:37 ` [PATCH v7 0/9] Add support for AD411x Jonathan Cameron
2024-06-13 18:30 ` Jonathan Cameron
2024-06-17 18:02 ` Jonathan Cameron
2024-06-10 13:40 ` David Lechner
2024-07-13 10:11 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6226f65a-3420-45e0-aeb9-8d31d26a070d@gmail.com \
--to=mitrutzceclan@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=dumitru.ceclan@analog.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).