From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH 2/3] arm64: dts: rockchip: add cdn-dp node for rk3399. Date: Sat, 10 Feb 2018 17:16:45 +0100 Message-ID: <6229682.fDmaELEjz4@phil> References: <20180207163150.16332-1-enric.balletbo@collabora.com> <20180207163150.16332-2-enric.balletbo@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180207163150.16332-2-enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Enric Balletbo i Serra Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Catalin Marinas , Chris Zhong , Brian Norris , Will Deacon , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , groeck-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Enric, Am Mittwoch, 7. Februar 2018, 17:31:49 CET schrieb Enric Balletbo i Serra: > From: Chris Zhong > > Add a node for the cdn DP controller which is embedded in the rk3399 > SoC. > > Signed-off-by: Chris Zhong > Signed-off-by: Enric Balletbo i Serra > --- > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 50 ++++++++++++++++++++++++++++++++ It looks like there is no binding document at all for cdn-dp? At least I couldn't find one and the original series also didn't seem to include one. And while I don't see anything problematic right with the used properties right now, I'd think we should really have a binding and give dt-maintainers a chance to complain, before adding devicetree nodes based on it. I'd guess a mostly usable binding doc should already sit in the chromeos tree, which you could base a v2 of this series on? Thanks Heiko