From: "Yunfei Dong (董云飞)" <Yunfei.Dong@mediatek.com>
To: "robh@kernel.org" <robh@kernel.org>,
"wenst@chromium.org" <wenst@chromium.org>,
"Tiffany Lin (林慧珊)" <tiffany.lin@mediatek.com>,
"benjamin.gaignard@collabora.com"
<benjamin.gaignard@collabora.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"stevecho@chromium.org" <stevecho@chromium.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"hsinyi@chromium.org" <hsinyi@chromium.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
Subject: Re: [PATCH 2/3] media: dt-bindings: media: mediatek: vcodec: Change the max reg value to 2
Date: Thu, 10 Nov 2022 10:34:14 +0000 [thread overview]
Message-ID: <6229b2ce6f49ccad25eed3ae00390b4553cf94a3.camel@mediatek.com> (raw)
In-Reply-To: <96979d33-829a-4b38-bd8e-83b7f07a7c2c@collabora.com>
Dear AngeloGioacchino Del,
Thank for your suggestion, looks very reasonable.
Fix in v2.
Best regards,
Yunfei Dong
On Wed, 2022-11-09 at 10:29 +0100, AngeloGioacchino Del Regno wrote:
> Il 09/11/22 08:35, Yunfei Dong ha scritto:
> > Need to add racing control register base in device node for mt8195
> > support
> > inner racing mode. Changing the max reg value from 1 to 2.
> >
> > Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
> > ---
> > .../bindings/media/mediatek,vcodec-subdev-decoder.yaml |
> > 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-
> > decoder.yaml
> > b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-
> > decoder.yaml
> > index 794012853834..1697feb1f854 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > subdev-decoder.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > subdev-decoder.yaml
> > @@ -61,7 +61,7 @@ properties:
> > - mediatek,mt8195-vcodec-dec
> >
> > reg:
> > - maxItems: 1
> > + maxItems: 2
>
> What about doing, instead...
>
> - description: VDEC_SYS register space
> - description: VDEC_RACING_CTRL register space
>
> then, setting `minItems: 1` will make the racing_ctrl iospace
> optional :-)
>
> Regards,
> Angelo
>
>
next prev parent reply other threads:[~2022-11-10 10:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 7:35 [PATCH 1/3] media: dt-bindings: media: mediatek: vcodec: Fix clock num not correctly Yunfei Dong
2022-11-09 7:35 ` [PATCH 2/3] media: dt-bindings: media: mediatek: vcodec: Change the max reg value to 2 Yunfei Dong
2022-11-09 9:29 ` AngeloGioacchino Del Regno
2022-11-10 10:34 ` Yunfei Dong (董云飞) [this message]
2022-11-09 12:59 ` Rob Herring
2022-11-11 1:39 ` Yunfei Dong (董云飞)
2022-11-09 7:35 ` [PATCH 3/3] arm64: dts: mt8195: Add video decoder node Yunfei Dong
2022-11-09 9:32 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6229b2ce6f49ccad25eed3ae00390b4553cf94a3.camel@mediatek.com \
--to=yunfei.dong@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=benjamin.gaignard@collabora.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=hsinyi@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=stevecho@chromium.org \
--cc=tiffany.lin@mediatek.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).