[PATCH v9 0/3] Introduce USB DT support for SM8750

[PATCH v9 0/3] Introduce USB DT support for SM8750

[Krishna Kurapati]

Add support for the PHYs and controllers used for USB on SM8750 SoCs.

Version-6 of this series has all the binding/driver/dt patches acked.
But only the phy changes have been merged.

Version 7 was a rebase to get acked patches merged. But comments came
in to use flattened bindings.

The v8 for usb bindings patch has been split and sent out separately [1]
and it is ACKed.

Cover letter heading has been modified to remove phy context.

Defconfig patch has been resent by Jingyi on [2].

[1]: https://lore.kernel.org/all/20251021050954.3462613-1-krishna.kurapati@oss.qualcomm.com/
[2]: https://lore.kernel.org/all/20251021-knp-usb-v2-4-a2809fffcfab@oss.qualcomm.com/

---
Changes in v9:
- Updated commit tags (Removed Suggested-by of Konrad andadded his SoB)
- Confirmed with Konrad offline before adding his Signed-off-by
- Updated commit text in patch 1/3 as per suggestion from Bjorn.

Changes in v8:
- Using Flattened DT representation.
- Removed obtained RB tags since the code has changed significantly.
- Modified Author mail address from quicinc to oss.qualcomm.com
- Link to v7: https://lore.kernel.org/all/20251015105231.2819727-1-krishna.kurapati@oss.qualcomm.com/

Changes in v7:
- Rebased on top of linux next
- Split usb patch and sent out separately.
- Link to v6: https://lore.kernel.org/all/20250527-sm8750_usb_master-v6-0-d58de3b41d34@oss.qualcomm.com/

Changes in v6:
- Change readl_relaxed/writel_relaxed calls to just readl/writel in the readback function
- Updated languange in the defconfig commit to specify SM8750 as a Qualcomm SoC
- Link to v5: https://lore.kernel.org/r/20250421-sm8750_usb_master-v5-0-25c79ed01d02@oss.qualcomm.com

Changes in v5:
- Removed refclk_src from the QMP PHY driver as that is no longer used.
- The decision to move the TCSR clkref property from controller --> phy
node was made in v4, and the refclk_src was a lingering change that was
meant to be removed.  CXO is the parent clock for TCSR clkref, so CXO
clk will be voted for as well.
- Relocate the SM8750 compatible within the qcom,dwc3 bindings.  This is
to take into account the change in clock list.
- Link to v4: https://lore.kernel.org/r/20250409-sm8750_usb_master-v4-0-6ec621c98be6@oss.qualcomm.com

Changes in v4:
- Made some fixups to the M31 eUSB2 driver
- Moved TCSR refclk_en to the QMP PHY DT node
- Link to v3: https://lore.kernel.org/r/20250324-sm8750_usb_master-v3-0-13e096dc88fd@quicinc.com

Changes in v3:
- Split platform DTs into separate commits.
- Fixed up M31 eUSB2 PHY driver with feedback received.
- Reordered DT properties based on feedback.
- Rewrote commit message for enabling EUSB driver.
- Link to v2: https://lore.kernel.org/r/20250304-sm8750_usb_master-v2-0-a698a2e68e06@quicinc.com

Changes in v2:
- Added new QMP PHY register definitions for v8 based QMP phys.
- Made changes to clean up some code in the M31 eUSB2 PHY driver based
on feedback received.
- Added bulk regulator operations in M31 eUSB2 PHY, to ensure that
both the vdd and vdda12 regulators are properly voted for.
- Removed external references to other dt bindings in M31 example for
the DT bindings change.
- Split DT patches between SoC and plaform changes, as well as the
PHY subsystem Kconfig changes when introducing the M31 eUSB2 PHY.
- Added orientation switch and port definitions in the DT changes.EDITME: describe what is new in this series revision.
- Link to v1: https://lore.kernel.org/r/20250113-sm8750_usb_master-v1-0-09afe1dc2524@quicinc.com

Wesley Cheng (3):
  arm64: dts: qcom: sm8750: Add USB support to SM8750 SoCs
  arm64: dts: qcom: sm8750: Add USB support for SM8750 MTP platform
  arm64: dts: qcom: sm8750: Add USB support for SM8750 QRD platform

 arch/arm64/boot/dts/qcom/sm8750-mtp.dts |  22 ++++
 arch/arm64/boot/dts/qcom/sm8750-qrd.dts |  22 ++++
 arch/arm64/boot/dts/qcom/sm8750.dtsi    | 158 ++++++++++++++++++++++++
 3 files changed, 202 insertions(+)

-- 
2.34.1

[PATCH v9 1/3] arm64: dts: qcom: sm8750: Add USB support to SM8750 SoCs

[Krishna Kurapati]

From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>

SM8750 chipset contains a single DWC3 USB3 controller (rev. 200a), SS
QMP PHY (rev. v8) and M31 eUSB2 PHY.  The major difference for SM8750 is
the transition to using the M31 eUSB2 PHY compared to previous SoCs.

Enable USB support on SM8750 MTP and QRD variants. SM8750 has a QMP combo
PHY for the SSUSB path, and a M31 eUSB2 PHY for the HSUSB path.

Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
[Konrad: Provided diff to flattened USB node]
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sm8750.dtsi | 158 +++++++++++++++++++++++++++
 1 file changed, 158 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
index a82d9867c7cb..d933c378bd8d 100644
--- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
@@ -12,6 +12,7 @@
 #include <dt-bindings/interconnect/qcom,sm8750-rpmh.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/mailbox/qcom-ipcc.h>
+#include <dt-bindings/phy/phy-qcom-qmp.h>
 #include <dt-bindings/power/qcom,rpmhpd.h>
 #include <dt-bindings/power/qcom-rpmpd.h>
 #include <dt-bindings/soc/qcom,gpr.h>
@@ -2581,6 +2582,163 @@ data-pins {
 			};
 		};
 
+		usb_1_hsphy: phy@88e3000 {
+			compatible = "qcom,sm8750-m31-eusb2-phy";
+			reg = <0x0 0x88e3000 0x0 0x29c>;
+
+			clocks = <&tcsrcc TCSR_USB2_CLKREF_EN>;
+			clock-names = "ref";
+
+			resets = <&gcc GCC_QUSB2PHY_PRIM_BCR>;
+
+			#phy-cells = <0>;
+
+			status = "disabled";
+		};
+
+		usb_dp_qmpphy: phy@88e8000 {
+			compatible = "qcom,sm8750-qmp-usb3-dp-phy";
+			reg = <0x0 0x088e8000 0x0 0x4000>;
+
+			clocks = <&gcc GCC_USB3_PRIM_PHY_AUX_CLK>,
+				 <&tcsrcc TCSR_USB3_CLKREF_EN>,
+				 <&gcc GCC_USB3_PRIM_PHY_COM_AUX_CLK>,
+				 <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>;
+			clock-names = "aux",
+				      "ref",
+				      "com_aux",
+				      "usb3_pipe";
+
+			resets = <&gcc GCC_USB3_PHY_PRIM_BCR>,
+				 <&gcc GCC_USB3_DP_PHY_PRIM_BCR>;
+			reset-names = "phy",
+				      "common";
+
+			power-domains = <&gcc GCC_USB3_PHY_GDSC>;
+
+			#clock-cells = <1>;
+			#phy-cells = <1>;
+
+			orientation-switch;
+
+			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+
+					usb_dp_qmpphy_out: endpoint {
+					};
+				};
+
+				port@1 {
+					reg = <1>;
+
+					usb_dp_qmpphy_usb_ss_in: endpoint {
+						remote-endpoint = <&usb_1_dwc3_ss>;
+					};
+				};
+
+				port@2 {
+					reg = <2>;
+
+					usb_dp_qmpphy_dp_in: endpoint {
+					};
+				};
+			};
+		};
+
+		usb_1: usb@a600000 {
+			compatible = "qcom,sm8750-dwc3", "qcom,snps-dwc3";
+			reg = <0x0 0x0a600000 0x0 0xfc100>;
+
+			clocks = <&gcc GCC_CFG_NOC_USB3_PRIM_AXI_CLK>,
+				 <&gcc GCC_USB30_PRIM_MASTER_CLK>,
+				 <&gcc GCC_AGGRE_USB3_PRIM_AXI_CLK>,
+				 <&gcc GCC_USB30_PRIM_SLEEP_CLK>,
+				 <&gcc GCC_USB30_PRIM_MOCK_UTMI_CLK>;
+			clock-names = "cfg_noc",
+				      "core",
+				      "iface",
+				      "sleep",
+				      "mock_utmi";
+
+			assigned-clocks = <&gcc GCC_USB30_PRIM_MOCK_UTMI_CLK>,
+					  <&gcc GCC_USB30_PRIM_MASTER_CLK>;
+			assigned-clock-rates = <19200000>,
+					       <200000000>;
+
+			interrupts-extended = <&intc GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>,
+					      <&intc GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH>,
+					      <&intc GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>,
+					      <&pdc 14 IRQ_TYPE_EDGE_BOTH>,
+					      <&pdc 15 IRQ_TYPE_EDGE_BOTH>,
+					      <&pdc 17 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "dwc_usb3",
+					  "pwr_event",
+					  "hs_phy_irq",
+					  "dp_hs_phy_irq",
+					  "dm_hs_phy_irq",
+					  "ss_phy_irq";
+
+			power-domains = <&gcc GCC_USB30_PRIM_GDSC>;
+			required-opps = <&rpmhpd_opp_nom>;
+
+			resets = <&gcc GCC_USB30_PRIM_BCR>;
+
+			interconnects = <&aggre1_noc MASTER_USB3_0 QCOM_ICC_TAG_ALWAYS
+					 &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
+					<&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
+					 &config_noc SLAVE_USB3_0 QCOM_ICC_TAG_ACTIVE_ONLY>;
+			interconnect-names = "usb-ddr", "apps-usb";
+
+			iommus = <&apps_smmu 0x40 0x0>;
+
+			phys = <&usb_1_hsphy>,
+			       <&usb_dp_qmpphy QMP_USB43DP_USB3_PHY>;
+			phy-names = "usb2-phy",
+				    "usb3-phy";
+
+			snps,hird-threshold = /bits/ 8 <0x0>;
+			snps,usb2-gadget-lpm-disable;
+			snps,dis_u2_susphy_quirk;
+			snps,dis_enblslpm_quirk;
+			snps,dis-u1-entry-quirk;
+			snps,dis-u2-entry-quirk;
+			snps,is-utmi-l1-suspend;
+			snps,usb3_lpm_capable;
+			snps,usb2-lpm-disable;
+			snps,has-lpm-erratum;
+			tx-fifo-resize;
+
+			dma-coherent;
+
+			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+
+					usb_1_dwc3_hs: endpoint {
+					};
+				};
+
+				port@1 {
+					reg = <1>;
+
+					usb_1_dwc3_ss: endpoint {
+						remote-endpoint = <&usb_dp_qmpphy_usb_ss_in>;
+					};
+				};
+			};
+		};
+
 		pdc: interrupt-controller@b220000 {
 			compatible = "qcom,sm8750-pdc", "qcom,pdc";
 			reg = <0x0 0x0b220000 0x0 0x10000>, <0x0 0x164400f0 0x0 0x64>;
-- 
2.34.1

[PATCH v9 2/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 MTP platform

[Krishna Kurapati]

From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>

Enable USB support on SM8750 MTP variants.  The current definition will
start the USB controller in peripheral mode by default until
dependencies are added, such as USB role detection.

Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
[Konrad: Provided diff to flatten USB node on MTP]
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
index 3bbb53b7c71f..1b526d96fba8 100644
--- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
@@ -1200,3 +1200,25 @@ &ufs_mem_hc {
 
 	status = "okay";
 };
+
+&usb_1 {
+	dr_mode = "peripheral";
+
+	status = "okay";
+};
+
+&usb_1_hsphy {
+	vdd-supply = <&vreg_l2d_0p88>;
+	vdda12-supply = <&vreg_l3g_1p2>;
+
+	phys = <&pmih0108_eusb2_repeater>;
+
+	status = "okay";
+};
+
+&usb_dp_qmpphy {
+	vdda-phy-supply = <&vreg_l3g_1p2>;
+	vdda-pll-supply = <&vreg_l2d_0p88>;
+
+	status = "okay";
+};
-- 
2.34.1

[PATCH v9 3/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 QRD platform

[Krishna Kurapati]

From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>

Enable USB support on SM8750 QRD variant.  The current definition
will start the USB controller in peripheral mode by default until
dependencies are added, such as USB role detection.

Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
[Krishna: Flattened usb node QRD DTS]
Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
index 13c7b9664c89..fc5d12bb41a5 100644
--- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
@@ -1054,3 +1054,25 @@ &ufs_mem_hc {
 
 	status = "okay";
 };
+
+&usb_1 {
+	dr_mode = "peripheral";
+
+	status = "okay";
+};
+
+&usb_1_hsphy {
+	vdd-supply = <&vreg_l2d_0p88>;
+	vdda12-supply = <&vreg_l3g_1p2>;
+
+	phys = <&pmih0108_eusb2_repeater>;
+
+	status = "okay";
+};
+
+&usb_dp_qmpphy {
+	vdda-phy-supply = <&vreg_l3g_1p2>;
+	vdda-pll-supply = <&vreg_l2d_0p88>;
+
+	status = "okay";
+};
-- 
2.34.1

Re: [PATCH v9 1/3] arm64: dts: qcom: sm8750: Add USB support to SM8750 SoCs

[Dmitry Baryshkov]

On Fri, Oct 24, 2025 at 08:45:19PM +0530, Krishna Kurapati wrote:
> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> 
> SM8750 chipset contains a single DWC3 USB3 controller (rev. 200a), SS
> QMP PHY (rev. v8) and M31 eUSB2 PHY.  The major difference for SM8750 is
> the transition to using the M31 eUSB2 PHY compared to previous SoCs.
> 
> Enable USB support on SM8750 MTP and QRD variants. SM8750 has a QMP combo
> PHY for the SSUSB path, and a M31 eUSB2 PHY for the HSUSB path.
> 
> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> [Konrad: Provided diff to flattened USB node]
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sm8750.dtsi | 158 +++++++++++++++++++++++++++
>  1 file changed, 158 insertions(+)
> 
> +
> +		usb_dp_qmpphy: phy@88e8000 {

You also need to update gcc clocks properties.

> +			compatible = "qcom,sm8750-qmp-usb3-dp-phy";
> +			reg = <0x0 0x088e8000 0x0 0x4000>;
> +

-- 
With best wishes
Dmitry

Re: [PATCH v9 2/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 MTP platform

[Dmitry Baryshkov]

On Fri, Oct 24, 2025 at 08:45:20PM +0530, Krishna Kurapati wrote:
> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> 
> Enable USB support on SM8750 MTP variants.  The current definition will
> start the USB controller in peripheral mode by default until
> dependencies are added, such as USB role detection.

Which dependencies?

> 
> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> [Konrad: Provided diff to flatten USB node on MTP]
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 

-- 
With best wishes
Dmitry

Re: [PATCH v9 3/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 QRD platform

[Krzysztof Kozlowski]

On 24/10/2025 17:15, Krishna Kurapati wrote:
> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> 
> Enable USB support on SM8750 QRD variant.  The current definition
> will start the USB controller in peripheral mode by default until
> dependencies are added, such as USB role detection.
> 
> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> [Krishna: Flattened usb node QRD DTS]
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> index 13c7b9664c89..fc5d12bb41a5 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> @@ -1054,3 +1054,25 @@ &ufs_mem_hc {
>  
>  	status = "okay";
>  };
> +
> +&usb_1 {

Still wrongly ordered. Please follow DTS coding style.

Best regards,
Krzysztof

Re: [PATCH v9 2/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 MTP platform

[Krzysztof Kozlowski]

On 24/10/2025 17:15, Krishna Kurapati wrote:
> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> 
> Enable USB support on SM8750 MTP variants.  The current definition will
> start the USB controller in peripheral mode by default until
> dependencies are added, such as USB role detection.
> 
> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> [Konrad: Provided diff to flatten USB node on MTP]
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> index 3bbb53b7c71f..1b526d96fba8 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> @@ -1200,3 +1200,25 @@ &ufs_mem_hc {
>  
>  	status = "okay";
>  };
> +
> +&usb_1 {


Still wrongly ordered. Please follow DTS coding style.

Best regards,
Krzysztof

Re: [PATCH v9 3/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 QRD platform

[Krzysztof Kozlowski]

On 24/10/2025 17:15, Krishna Kurapati wrote:
> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> 
> Enable USB support on SM8750 QRD variant.  The current definition
> will start the USB controller in peripheral mode by default until
> dependencies are added, such as USB role detection.
> 
> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> [Krishna: Flattened usb node QRD DTS]
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>

NAK.

You ignored every previous tag - multiple reviews and tests, and then...

> ---
>  arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> index 13c7b9664c89..fc5d12bb41a5 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> @@ -1054,3 +1054,25 @@ &ufs_mem_hc {
>  
>  	status = "okay";
>  };
> +
> +&usb_1 {
> +	dr_mode = "peripheral";

You sent something different with issues.

Really, this was a correct patch. Was reviewed. Why you decided to drop
all this, drop everything which was correct?

Your explanation:
"- Removed obtained RB tags since the code has changed significantly."
is just wrong. Almost NOTHING changed, except completely unimportant two
node merging.

NAK

Best regards,
Krzysztof

Re: [PATCH v9 3/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 QRD platform

[Krzysztof Kozlowski]

On 29/10/2025 09:02, Krzysztof Kozlowski wrote:
> On 24/10/2025 17:15, Krishna Kurapati wrote:
>> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>>
>> Enable USB support on SM8750 QRD variant.  The current definition
>> will start the USB controller in peripheral mode by default until
>> dependencies are added, such as USB role detection.
>>
>> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>> [Krishna: Flattened usb node QRD DTS]
>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>> ---
>>  arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 22 ++++++++++++++++++++++
>>  1 file changed, 22 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>> index 13c7b9664c89..fc5d12bb41a5 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>> @@ -1054,3 +1054,25 @@ &ufs_mem_hc {
>>  
>>  	status = "okay";
>>  };
>> +
>> +&usb_1 {
> 
> Still wrongly ordered. Please follow DTS coding style.


My bad, this is actually correctly ordered, your previous patches were
incorrect. Nothing in the changelog explained that, though.

Best regards,
Krzysztof

Re: [PATCH v9 3/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 QRD platform

[Krishna Kurapati PSSNV]

On 10/29/2025 1:37 PM, Krzysztof Kozlowski wrote:
> On 24/10/2025 17:15, Krishna Kurapati wrote:
>> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>>
>> Enable USB support on SM8750 QRD variant.  The current definition
>> will start the USB controller in peripheral mode by default until
>> dependencies are added, such as USB role detection.
>>
>> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>> [Krishna: Flattened usb node QRD DTS]
>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> 
> NAK.
> 
> You ignored every previous tag - multiple reviews and tests, and then...
> 
>> ---
>>   arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 22 ++++++++++++++++++++++
>>   1 file changed, 22 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>> index 13c7b9664c89..fc5d12bb41a5 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>> @@ -1054,3 +1054,25 @@ &ufs_mem_hc {
>>   
>>   	status = "okay";
>>   };
>> +
>> +&usb_1 {
>> +	dr_mode = "peripheral";
> 
> You sent something different with issues.
> 
> Really, this was a correct patch. Was reviewed. Why you decided to drop
> all this, drop everything which was correct?
> 
> Your explanation:
> "- Removed obtained RB tags since the code has changed significantly."
> is just wrong. Almost NOTHING changed, except completely unimportant two
> node merging.
> 
> NAK
> 


Apologies Krzysztof,

On first patch that adds changes to base DTSI, there were changes moving 
to newer bindings and merging child node and parent node. I should've 
removed RB tags received on that patch only. But I was over cautious and 
misinterpreted the rules and removed them on the other patches as well. 
Will be careful the next time.

Also is there any issue with marking dr_mode as peripheral here in usb_1 
node ?

Regards,
Krishna,

Re: [PATCH v9 3/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 QRD platform

[Krzysztof Kozlowski]

On 29/10/2025 12:42, Krishna Kurapati PSSNV wrote:
> 
> 
> On 10/29/2025 1:37 PM, Krzysztof Kozlowski wrote:
>> On 24/10/2025 17:15, Krishna Kurapati wrote:
>>> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>>>
>>> Enable USB support on SM8750 QRD variant.  The current definition
>>> will start the USB controller in peripheral mode by default until
>>> dependencies are added, such as USB role detection.
>>>
>>> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>>> [Krishna: Flattened usb node QRD DTS]
>>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>>
>> NAK.
>>
>> You ignored every previous tag - multiple reviews and tests, and then...
>>
>>> ---
>>>   arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 22 ++++++++++++++++++++++
>>>   1 file changed, 22 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>>> index 13c7b9664c89..fc5d12bb41a5 100644
>>> --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>>> +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>>> @@ -1054,3 +1054,25 @@ &ufs_mem_hc {
>>>   
>>>   	status = "okay";
>>>   };
>>> +
>>> +&usb_1 {
>>> +	dr_mode = "peripheral";
>>
>> You sent something different with issues.
>>
>> Really, this was a correct patch. Was reviewed. Why you decided to drop
>> all this, drop everything which was correct?
>>
>> Your explanation:
>> "- Removed obtained RB tags since the code has changed significantly."
>> is just wrong. Almost NOTHING changed, except completely unimportant two
>> node merging.
>>
>> NAK
>>
> 
> 
> Apologies Krzysztof,
> 
> On first patch that adds changes to base DTSI, there were changes moving 
> to newer bindings and merging child node and parent node. I should've 
> removed RB tags received on that patch only. But I was over cautious and 
> misinterpreted the rules and removed them on the other patches as well. 
> Will be careful the next time.
> 
> Also is there any issue with marking dr_mode as peripheral here in usb_1 
> node ?

No, I think I looked at your other patch. Tthis was reviewed at v4 and
v5, which then it was changed breaking sorting order. This one looks
correct.

Best regards,
Krzysztof

Re: [PATCH v9 3/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 QRD platform

[Krishna Kurapati PSSNV]

On 10/29/2025 5:35 PM, Krzysztof Kozlowski wrote:
> On 29/10/2025 12:42, Krishna Kurapati PSSNV wrote:
>>
>>
>> On 10/29/2025 1:37 PM, Krzysztof Kozlowski wrote:
>>> On 24/10/2025 17:15, Krishna Kurapati wrote:
>>>> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>>>>
>>>> Enable USB support on SM8750 QRD variant.  The current definition
>>>> will start the USB controller in peripheral mode by default until
>>>> dependencies are added, such as USB role detection.
>>>>
>>>> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>>>> [Krishna: Flattened usb node QRD DTS]
>>>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>>>
>>> NAK.
>>>
>>> You ignored every previous tag - multiple reviews and tests, and then...
>>>
>>>> ---
>>>>    arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 22 ++++++++++++++++++++++
>>>>    1 file changed, 22 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>>>> index 13c7b9664c89..fc5d12bb41a5 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>>>> +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>>>> @@ -1054,3 +1054,25 @@ &ufs_mem_hc {
>>>>    
>>>>    	status = "okay";
>>>>    };
>>>> +
>>>> +&usb_1 {
>>>> +	dr_mode = "peripheral";
>>>
>>> You sent something different with issues.
>>>
>>> Really, this was a correct patch. Was reviewed. Why you decided to drop
>>> all this, drop everything which was correct?
>>>
>>> Your explanation:
>>> "- Removed obtained RB tags since the code has changed significantly."
>>> is just wrong. Almost NOTHING changed, except completely unimportant two
>>> node merging.
>>>
>>> NAK
>>>
>>
>>
>> Apologies Krzysztof,
>>
>> On first patch that adds changes to base DTSI, there were changes moving
>> to newer bindings and merging child node and parent node. I should've
>> removed RB tags received on that patch only. But I was over cautious and
>> misinterpreted the rules and removed them on the other patches as well.
>> Will be careful the next time.
>>
>> Also is there any issue with marking dr_mode as peripheral here in usb_1
>> node ?
> 
> No, I think I looked at your other patch. Tthis was reviewed at v4 and
> v5, which then it was changed breaking sorting order. This one looks
> correct.
> 

Ok.

I will send v10 tomorrow. Can I add yours and Dmitry's RB tag on the MTP 
and QRD patches and then send it ? I will implement feedback from Dmitry 
on SOC dtsi patch in v10.

Regards,
Krishna,

Re: [PATCH v9 3/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 QRD platform

[Dmitry Baryshkov]

On Wed, Oct 29, 2025 at 06:00:02PM +0530, Krishna Kurapati PSSNV wrote:
> 
> 
> On 10/29/2025 5:35 PM, Krzysztof Kozlowski wrote:
> > On 29/10/2025 12:42, Krishna Kurapati PSSNV wrote:
> > > 
> > > 
> > > On 10/29/2025 1:37 PM, Krzysztof Kozlowski wrote:
> > > > On 24/10/2025 17:15, Krishna Kurapati wrote:
> > > > > From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> > > > > 
> > > > > Enable USB support on SM8750 QRD variant.  The current definition
> > > > > will start the USB controller in peripheral mode by default until
> > > > > dependencies are added, such as USB role detection.
> > > > > 
> > > > > Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> > > > > [Krishna: Flattened usb node QRD DTS]
> > > > > Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> > > > 
> > > > NAK.
> > > > 
> > > > You ignored every previous tag - multiple reviews and tests, and then...
> > > > 
> > > > > ---
> > > > >    arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 22 ++++++++++++++++++++++
> > > > >    1 file changed, 22 insertions(+)
> > > > > 
> > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> > > > > index 13c7b9664c89..fc5d12bb41a5 100644
> > > > > --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> > > > > +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> > > > > @@ -1054,3 +1054,25 @@ &ufs_mem_hc {
> > > > >    	status = "okay";
> > > > >    };
> > > > > +
> > > > > +&usb_1 {
> > > > > +	dr_mode = "peripheral";
> > > > 
> > > > You sent something different with issues.
> > > > 
> > > > Really, this was a correct patch. Was reviewed. Why you decided to drop
> > > > all this, drop everything which was correct?
> > > > 
> > > > Your explanation:
> > > > "- Removed obtained RB tags since the code has changed significantly."
> > > > is just wrong. Almost NOTHING changed, except completely unimportant two
> > > > node merging.
> > > > 
> > > > NAK
> > > > 
> > > 
> > > 
> > > Apologies Krzysztof,
> > > 
> > > On first patch that adds changes to base DTSI, there were changes moving
> > > to newer bindings and merging child node and parent node. I should've
> > > removed RB tags received on that patch only. But I was over cautious and
> > > misinterpreted the rules and removed them on the other patches as well.
> > > Will be careful the next time.
> > > 
> > > Also is there any issue with marking dr_mode as peripheral here in usb_1
> > > node ?
> > 
> > No, I think I looked at your other patch. Tthis was reviewed at v4 and
> > v5, which then it was changed breaking sorting order. This one looks
> > correct.
> > 
> 
> Ok.
> 
> I will send v10 tomorrow. Can I add yours and Dmitry's RB tag on the MTP and
> QRD patches and then send it ? I will implement feedback from Dmitry on SOC
> dtsi patch in v10.

Could you please answer the questions that I asked for this series?

Also, why is there no link to v8 in your cover letter?

-- 
With best wishes
Dmitry

Re: [PATCH v9 2/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 MTP platform

[Krishna Kurapati PSSNV]

On 10/29/2025 2:45 AM, Dmitry Baryshkov wrote:
> On Fri, Oct 24, 2025 at 08:45:20PM +0530, Krishna Kurapati wrote:
>> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>>
>> Enable USB support on SM8750 MTP variants.  The current definition will
>> start the USB controller in peripheral mode by default until
>> dependencies are added, such as USB role detection.
> 
> Which dependencies?
> 

Dependencies like pmic-glink and adding remote endpoints for otg 
support. Till they are added, we can enable peripheral mode.

Regards,
Krishna,

>>
>> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>> [Konrad: Provided diff to flatten USB node on MTP]
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 22 ++++++++++++++++++++++
>>   1 file changed, 22 insertions(+)
>>
> 

Re: [PATCH v9 2/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 MTP platform

[Bjorn Andersson]

On Wed, Oct 29, 2025 at 09:20:48PM +0530, Krishna Kurapati PSSNV wrote:
> 
> 
> On 10/29/2025 2:45 AM, Dmitry Baryshkov wrote:
> > On Fri, Oct 24, 2025 at 08:45:20PM +0530, Krishna Kurapati wrote:
> > > From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> > > 
> > > Enable USB support on SM8750 MTP variants.  The current definition will
> > > start the USB controller in peripheral mode by default until
> > > dependencies are added, such as USB role detection.
> > 
> > Which dependencies?
> > 
> 
> Dependencies like pmic-glink and adding remote endpoints for otg support.
> Till they are added, we can enable peripheral mode.
> 

But this is 8750, Jishnu got qcom,sm8750-pmic-glink landed in the
binding 9 months ago, so why are we spending time discussing this?

Why not just add the whole shebang at once?

Regards,
Bjorn

> Regards,
> Krishna,
> 
> > > 
> > > Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> > > [Konrad: Provided diff to flatten USB node on MTP]
> > > Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> > > Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> > > ---
> > >   arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 22 ++++++++++++++++++++++
> > >   1 file changed, 22 insertions(+)
> > > 
> > 
> 

Re: [PATCH v9 2/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 MTP platform

[Krishna Kurapati PSSNV]

On 10/29/2025 10:04 PM, Bjorn Andersson wrote:
> On Wed, Oct 29, 2025 at 09:20:48PM +0530, Krishna Kurapati PSSNV wrote:
>>
>>
>> On 10/29/2025 2:45 AM, Dmitry Baryshkov wrote:
>>> On Fri, Oct 24, 2025 at 08:45:20PM +0530, Krishna Kurapati wrote:
>>>> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>>>>
>>>> Enable USB support on SM8750 MTP variants.  The current definition will
>>>> start the USB controller in peripheral mode by default until
>>>> dependencies are added, such as USB role detection.
>>>
>>> Which dependencies?
>>>
>>
>> Dependencies like pmic-glink and adding remote endpoints for otg support.
>> Till they are added, we can enable peripheral mode.
>>
> 
> But this is 8750, Jishnu got qcom,sm8750-pmic-glink landed in the
> binding 9 months ago, so why are we spending time discussing this?
> 
> Why not just add the whole shebang at once?
> 

Initially I didn't add those changes because the series already had 
acked patches and I didn't want to disturb them. I can add them in next 
submission and send them out.

Regards,
Krishna,

Re: [PATCH v9 2/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 MTP platform

[Bjorn Andersson]

On Wed, Oct 29, 2025 at 10:12:59PM +0530, Krishna Kurapati PSSNV wrote:
> 
> 
> On 10/29/2025 10:04 PM, Bjorn Andersson wrote:
> > On Wed, Oct 29, 2025 at 09:20:48PM +0530, Krishna Kurapati PSSNV wrote:
> > > 
> > > 
> > > On 10/29/2025 2:45 AM, Dmitry Baryshkov wrote:
> > > > On Fri, Oct 24, 2025 at 08:45:20PM +0530, Krishna Kurapati wrote:
> > > > > From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> > > > > 
> > > > > Enable USB support on SM8750 MTP variants.  The current definition will
> > > > > start the USB controller in peripheral mode by default until
> > > > > dependencies are added, such as USB role detection.
> > > > 
> > > > Which dependencies?
> > > > 
> > > 
> > > Dependencies like pmic-glink and adding remote endpoints for otg support.
> > > Till they are added, we can enable peripheral mode.
> > > 
> > 
> > But this is 8750, Jishnu got qcom,sm8750-pmic-glink landed in the
> > binding 9 months ago, so why are we spending time discussing this?
> > 
> > Why not just add the whole shebang at once?
> > 
> 
> Initially I didn't add those changes because the series already had acked
> patches and I didn't want to disturb them. I can add them in next submission
> and send them out.
> 

Now that you don't carry them anymore - and you have to resubmit this
anyways - I'd prefer that you just enable the whole thing over trying to
make up a reason suitable for encoding in the git log...

Regards,
Bjorn

> Regards,
> Krishna,

Re: [PATCH v9 1/3] arm64: dts: qcom: sm8750: Add USB support to SM8750 SoCs

[Krishna Kurapati PSSNV]

On 10/29/2025 2:44 AM, Dmitry Baryshkov wrote:
> On Fri, Oct 24, 2025 at 08:45:19PM +0530, Krishna Kurapati wrote:
>> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>>
>> SM8750 chipset contains a single DWC3 USB3 controller (rev. 200a), SS
>> QMP PHY (rev. v8) and M31 eUSB2 PHY.  The major difference for SM8750 is
>> the transition to using the M31 eUSB2 PHY compared to previous SoCs.
>>
>> Enable USB support on SM8750 MTP and QRD variants. SM8750 has a QMP combo
>> PHY for the SSUSB path, and a M31 eUSB2 PHY for the HSUSB path.
>>
>> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>> [Konrad: Provided diff to flattened USB node]
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sm8750.dtsi | 158 +++++++++++++++++++++++++++
>>   1 file changed, 158 insertions(+)
>>
>> +
>> +		usb_dp_qmpphy: phy@88e8000 {
> 
> You also need to update gcc clocks properties.

ACK.
Will add the qmp pipe clock in the last entry of gcc properties.

Regards,
Krishna,

> 
>> +			compatible = "qcom,sm8750-qmp-usb3-dp-phy";
>> +			reg = <0x0 0x088e8000 0x0 0x4000>;
>> +
> 

Re: [PATCH v9 3/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 QRD platform

[Krishna Kurapati PSSNV]

On 10/29/2025 6:36 PM, Dmitry Baryshkov wrote:
> On Wed, Oct 29, 2025 at 06:00:02PM +0530, Krishna Kurapati PSSNV wrote:
>>
>>
>> On 10/29/2025 5:35 PM, Krzysztof Kozlowski wrote:
>>> On 29/10/2025 12:42, Krishna Kurapati PSSNV wrote:
>>>>
>>>>
>>>> On 10/29/2025 1:37 PM, Krzysztof Kozlowski wrote:
>>>>> On 24/10/2025 17:15, Krishna Kurapati wrote:
>>>>>> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>>>>>>
>>>>>> Enable USB support on SM8750 QRD variant.  The current definition
>>>>>> will start the USB controller in peripheral mode by default until
>>>>>> dependencies are added, such as USB role detection.
>>>>>>
>>>>>> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>>>>>> [Krishna: Flattened usb node QRD DTS]
>>>>>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>>>>>
>>>>> NAK.
>>>>>
>>>>> You ignored every previous tag - multiple reviews and tests, and then...
>>>>>
>>>>>> ---
>>>>>>     arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 22 ++++++++++++++++++++++
>>>>>>     1 file changed, 22 insertions(+)
>>>>>>
>>>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>>>>>> index 13c7b9664c89..fc5d12bb41a5 100644
>>>>>> --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>>>>>> +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>>>>>> @@ -1054,3 +1054,25 @@ &ufs_mem_hc {
>>>>>>     	status = "okay";
>>>>>>     };
>>>>>> +
>>>>>> +&usb_1 {
>>>>>> +	dr_mode = "peripheral";
>>>>>
>>>>> You sent something different with issues.
>>>>>
>>>>> Really, this was a correct patch. Was reviewed. Why you decided to drop
>>>>> all this, drop everything which was correct?
>>>>>
>>>>> Your explanation:
>>>>> "- Removed obtained RB tags since the code has changed significantly."
>>>>> is just wrong. Almost NOTHING changed, except completely unimportant two
>>>>> node merging.
>>>>>
>>>>> NAK
>>>>>
>>>>
>>>>
>>>> Apologies Krzysztof,
>>>>
>>>> On first patch that adds changes to base DTSI, there were changes moving
>>>> to newer bindings and merging child node and parent node. I should've
>>>> removed RB tags received on that patch only. But I was over cautious and
>>>> misinterpreted the rules and removed them on the other patches as well.
>>>> Will be careful the next time.
>>>>
>>>> Also is there any issue with marking dr_mode as peripheral here in usb_1
>>>> node ?
>>>
>>> No, I think I looked at your other patch. Tthis was reviewed at v4 and
>>> v5, which then it was changed breaking sorting order. This one looks
>>> correct.
>>>
>>
>> Ok.
>>
>> I will send v10 tomorrow. Can I add yours and Dmitry's RB tag on the MTP and
>> QRD patches and then send it ? I will implement feedback from Dmitry on SOC
>> dtsi patch in v10.
> 
> Could you please answer the questions that I asked for this series?
> 

Replied to the questions and will update in v10, mentioned dependencies.
Also will add qmp pipe clock in gcc properties.

> Also, why is there no link to v8 in your cover letter?
> 

My bad. Missed adding it.

Will fix it up in next version.

Regards,
Krishna,