devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] clk: rockchip: add clock ID for usbphy480m_src
@ 2014-11-13  7:22 Kever Yang
  2014-12-16 21:02 ` Doug Anderson
       [not found] ` <1415863357-15680-1-git-send-email-kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
  0 siblings, 2 replies; 3+ messages in thread
From: Kever Yang @ 2014-11-13  7:22 UTC (permalink / raw)
  To: Heiko Stuebner, Mike Turquette
  Cc: dianders, sonnyrao, addy.ke, cf, dkl, huangtao, linux-rockchip,
	Kever Yang, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell,
	Kumar Gala, Mark yao, devicetree, linux-kernel

There are 3 different parent clock from different usbphy,
all of them are fixed 480MHz, it is not able to auto select
by clock core to the 2nd and the 3rd parent.
For different use case for different board, we may need to
select different usbphy clock out as parent manually.

Add the clock ID for it so that we can use in dts.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

 include/dt-bindings/clock/rk3288-cru.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/dt-bindings/clock/rk3288-cru.h b/include/dt-bindings/clock/rk3288-cru.h
index 100a08c..3dcc906 100644
--- a/include/dt-bindings/clock/rk3288-cru.h
+++ b/include/dt-bindings/clock/rk3288-cru.h
@@ -71,6 +71,7 @@
 #define SCLK_HDMI_CEC		110
 #define SCLK_HEVC_CABAC		111
 #define SCLK_HEVC_CORE		112
+#define SCLK_USBPHY480M_SRC	113
 
 #define DCLK_VOP0		190
 #define DCLK_VOP1		191
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] clk: rockchip: add clock ID for usbphy480m_src
  2014-11-13  7:22 [PATCH 1/2] clk: rockchip: add clock ID for usbphy480m_src Kever Yang
@ 2014-12-16 21:02 ` Doug Anderson
       [not found] ` <1415863357-15680-1-git-send-email-kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
  1 sibling, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2014-12-16 21:02 UTC (permalink / raw)
  To: Kever Yang
  Cc: Heiko Stuebner, Mike Turquette, Sonny Rao, Addy Ke, Eddie Cai,
	戴克霖 (Jack), Tao Huang,
	open list:ARM/Rockchip SoC..., Rob Herring, Pawel Moll,
	Mark Rutland, Ian Campbell, Kumar Gala, Mark yao,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org

Kever,

On Wed, Nov 12, 2014 at 11:22 PM, Kever Yang <kever.yang@rock-chips.com> wrote:
> There are 3 different parent clock from different usbphy,
> all of them are fixed 480MHz, it is not able to auto select
> by clock core to the 2nd and the 3rd parent.
> For different use case for different board, we may need to
> select different usbphy clock out as parent manually.
>
> Add the clock ID for it so that we can use in dts.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
>  include/dt-bindings/clock/rk3288-cru.h | 1 +
>  1 file changed, 1 insertion(+)

Aside from clock ID collisions that Heiko can fixup, this looks good to me.

Reviewed-by: Doug Anderson <dianders@chromium.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] clk: rockchip: add clock ID for usbphy480m_src
       [not found] ` <1415863357-15680-1-git-send-email-kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
@ 2015-01-12 20:47   ` Heiko Stübner
  0 siblings, 0 replies; 3+ messages in thread
From: Heiko Stübner @ 2015-01-12 20:47 UTC (permalink / raw)
  To: Kever Yang
  Cc: Mike Turquette, dianders-F7+t8E8rja9g9hUCZPvPmw,
	sonnyrao-F7+t8E8rja9g9hUCZPvPmw, addy.ke-TNX95d0MmH7DzftRWevZcw,
	cf-TNX95d0MmH7DzftRWevZcw, dkl-TNX95d0MmH7DzftRWevZcw,
	huangtao-TNX95d0MmH7DzftRWevZcw,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Rob Herring,
	Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Mark yao,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

Am Donnerstag, 13. November 2014, 15:22:36 schrieb Kever Yang:
> There are 3 different parent clock from different usbphy,
> all of them are fixed 480MHz, it is not able to auto select
> by clock core to the 2nd and the 3rd parent.
> For different use case for different board, we may need to
> select different usbphy clock out as parent manually.
> 
> Add the clock ID for it so that we can use in dts.
> 
> Signed-off-by: Kever Yang <kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

applied both patches to my tree

The clock-id addition is living in a separate branch, so if you have dts 
updates using this I can share the clock-id branch easily.


Heiko
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-01-12 20:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-13  7:22 [PATCH 1/2] clk: rockchip: add clock ID for usbphy480m_src Kever Yang
2014-12-16 21:02 ` Doug Anderson
     [not found] ` <1415863357-15680-1-git-send-email-kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-01-12 20:47   ` Heiko Stübner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).