From: "Jason-ch Chen (陳建豪)" <Jason-ch.Chen@mediatek.com>
To: "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"wenst@chromium.org" <wenst@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"nfraprado@collabora.com" <nfraprado@collabora.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 3/4] dt-bindings: soc: mediatek: pwrap: Add compatible for MT8188
Date: Mon, 17 Jul 2023 12:00:14 +0000 [thread overview]
Message-ID: <62399eb4be7e0f5933e991e017e9df4ded9c5eed.camel@mediatek.com> (raw)
In-Reply-To: <84847777-bad0-0aff-5279-9b80fd95c2d5@linaro.org>
Hi Krzysztof,
On Tue, 2023-07-11 at 08:07 +0200, Krzysztof Kozlowski wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On 11/07/2023 04:39, Jason-ch Chen wrote:
> > From: jason-ch chen <Jason-ch.Chen@mediatek.com>
> >
> > Add MT8188 PMIC Wrapper compatible to binding document.
> >
> > Signed-off-by: jason-ch chen <Jason-ch.Chen@mediatek.com>
> > ---
> > .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml | 5
> +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git
> a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> > index a06ac2177444..c2f22e7dbcfb 100644
> > ---
> a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> > +++
> b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> > @@ -50,6 +50,11 @@ properties:
> > - mediatek,mt8186-pwrap
> > - mediatek,mt8195-pwrap
> > - const: syscon
> > + - items:
> > + - enum:
> > + - mediatek,mt8188-pwrap
>
> Why do you add duplicated entries? Test your DTS before sending
> patches.
In the next patch, I will remove the duplicated part. Thank you.
>
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-07-17 12:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 2:39 [PATCH v2 0/4] Add basic node support for MediaTek MT8188 SoC Jason-ch Chen
2023-07-11 2:39 ` [PATCH v2 1/4] dt-bindings: arm: Add compatible for MediaTek MT8188 Jason-ch Chen
2023-07-11 2:39 ` [PATCH v2 2/4] dt-bindings: arm: mediatek: Add mt8188 pericfg compatible Jason-ch Chen
2023-07-11 2:39 ` [PATCH v2 3/4] dt-bindings: soc: mediatek: pwrap: Add compatible for MT8188 Jason-ch Chen
2023-07-11 6:07 ` Krzysztof Kozlowski
2023-07-17 12:00 ` Jason-ch Chen (陳建豪) [this message]
2023-07-11 17:57 ` Conor Dooley
2023-07-11 2:39 ` [PATCH v2 4/4] arm64: dts: Add MediaTek MT8188 dts and evaluation board and Makefile Jason-ch Chen
2023-07-11 8:45 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62399eb4be7e0f5933e991e017e9df4ded9c5eed.camel@mediatek.com \
--to=jason-ch.chen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).