From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ben Levinsky <blevinsk@amd.com>, Ben Levinsky <ben.levinsky@amd.com>
Cc: andersson@kernel.org, mathieu.poirier@linaro.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, tanmay.shah@amd.com,
michal.simek@amd.com
Subject: Re: [PATCH v4 1/2] dt-bindings: remoteproc: document AMD BRAM-based rproc
Date: Tue, 30 Jun 2026 16:27:07 +0200 [thread overview]
Message-ID: <62400796-4b88-4880-be3e-a336b1c5f863@kernel.org> (raw)
In-Reply-To: <ff690a87-1929-400f-b566-74458c3c7da5@amd.com>
On 30/06/2026 15:47, Ben Levinsky wrote:
> Hi Krzysztof,
>
> I apologize if this came off as my ignoring your emails.
>
> In the v3 you had said:
>
>> + - enum:
>> + - xlnx,versal-bram-rproc
>> + - xlnx,versal-net-bram-rproc
>> + - amd,versal2-bram-rproc
>
> If there is going to be a new version, this should be sorted by name.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>
>
> I was uncomfortable in adding the Reviewed-by if that is what you meant.
>
> In this v4 I believe your review comment to sort by name was addressed.
>
> Apologies for my misunderstanding.
Did you implement my comment? It seems yes. Did you change something
else? It seems not, at least changelog is silent. So why would me Review
tag be not appropriate if you actually implemented reviewer's feedback?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-06-30 14:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 16:40 [PATCH v4 0/2] remoteproc: add AMD BRAM-based remote processor driver Ben Levinsky
2026-06-29 16:40 ` [PATCH v4 1/2] dt-bindings: remoteproc: document AMD BRAM-based rproc Ben Levinsky
2026-06-30 6:53 ` Krzysztof Kozlowski
2026-06-30 13:47 ` Ben Levinsky
2026-06-30 14:27 ` Krzysztof Kozlowski [this message]
2026-06-30 14:38 ` Ben Levinsky
2026-06-29 16:40 ` [PATCH v4 2/2] remoteproc: add AMD BRAM-based remote processor driver Ben Levinsky
2026-06-29 18:59 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62400796-4b88-4880-be3e-a336b1c5f863@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=ben.levinsky@amd.com \
--cc=blevinsk@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=michal.simek@amd.com \
--cc=robh@kernel.org \
--cc=tanmay.shah@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox