[PATCH] arm64: dts: rockchip: enable vicap dvp on wolfvision pf5 io expander

[PATCH] arm64: dts: rockchip: enable vicap dvp on wolfvision pf5 io expander

[Michael Riesch via B4 Relay]

From: Michael Riesch <michael.riesch@collabora.com>

The Digital Video Port (DVP, the 16-bit variant) of the RK3568 VICAP
is broken out to the PF5 mainboard expansion header.
Enable it in the device tree overlay for the WolfVision PF5 IO
Expander board.

Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
Reviewed-by: Gerald Loacker <gerald.loacker@wolfvision.net>
Tested-by: Gerald Loacker <gerald.loacker@wolfvision.net>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Michael Riesch <michael.riesch@collabora.com>
---
Habidere,

This patch was skipped when the RK3568 series was applied, as the
MEDIA_PCLK_SAMPLE_DUAL_EDGE definition was introduced in the very same
series.

With the definition mainline for two kernel releases now, it should be
safe to merge this device tree modification.

Thanks in advance!
---
 .../rockchip/rk3568-wolfvision-pf5-io-expander.dtso  | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso b/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso
index 048933de2943..8cfce71dd318 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso
+++ b/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso
@@ -11,6 +11,7 @@
 #include <dt-bindings/clock/rk3568-cru.h>
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/media/video-interfaces.h>
 #include <dt-bindings/pinctrl/rockchip.h>
 
 &{/} {
@@ -134,3 +135,22 @@ &usb2phy0_host {
 	phy-supply = <&usb_host_vbus>;
 	status = "okay";
 };
+
+&vicap {
+	pinctrl-names = "default";
+	pinctrl-0 = <&cif_clk &cif_dvp_clk &cif_dvp_bus16>;
+	status = "okay";
+};
+
+&vicap_dvp {
+	vicap_dvp_input: endpoint {
+		bus-type = <MEDIA_BUS_TYPE_BT656>;
+		bus-width = <16>;
+		pclk-sample = <MEDIA_PCLK_SAMPLE_DUAL_EDGE>;
+		rockchip,dvp-clk-delay = <10>;
+	};
+};
+
+&vicap_mmu {
+	status = "okay";
+};

---
base-commit: 1f318b96cc84d7c2ab792fcc0bfd42a7ca890681
change-id: 20260313-wv-io-expander-vicap-255be2ced75c

Best regards,
-- 
Michael Riesch <michael.riesch@collabora.com>

Re: [PATCH] arm64: dts: rockchip: enable vicap dvp on wolfvision pf5 io expander

[Heiko Stuebner]

Am Freitag, 13. März 2026, 16:53:29 Mitteleuropäische Normalzeit schrieb Michael Riesch via B4 Relay:
> From: Michael Riesch <michael.riesch@collabora.com>
> 
> The Digital Video Port (DVP, the 16-bit variant) of the RK3568 VICAP
> is broken out to the PF5 mainboard expansion header.
> Enable it in the device tree overlay for the WolfVision PF5 IO
> Expander board.
> 
> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>

The From should match the first Signed-off-by line.

All later Signed-off-bys are from "other" people handling the patch,
i.e. that other Michael Riesch ;-)

> Reviewed-by: Gerald Loacker <gerald.loacker@wolfvision.net>
> Tested-by: Gerald Loacker <gerald.loacker@wolfvision.net>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Michael Riesch <michael.riesch@collabora.com>


Heiko

Re: [PATCH] arm64: dts: rockchip: enable vicap dvp on wolfvision pf5 io expander

[Michael Riesch]

Hi Heiko,

On 3/13/26 19:19, Heiko Stuebner wrote:
> Am Freitag, 13. März 2026, 16:53:29 Mitteleuropäische Normalzeit schrieb Michael Riesch via B4 Relay:
>> From: Michael Riesch <michael.riesch@collabora.com>
>>
>> The Digital Video Port (DVP, the 16-bit variant) of the RK3568 VICAP
>> is broken out to the PF5 mainboard expansion header.
>> Enable it in the device tree overlay for the WolfVision PF5 IO
>> Expander board.
>>
>> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
> 
> The From should match the first Signed-off-by line.

Hmm... First of all, the Signed-off-by line is correct, this patch stems
from my WolfVision era. But then with the .mailmap entry I created when
the era ended, I cannot set the patch author (and thus the From line)
correctly.

Let me try again without this entry...

> 
> All later Signed-off-bys are from "other" people handling the patch,
> i.e. that other Michael Riesch ;-)

Yeah that guy's pretty weird!

> 
>> Reviewed-by: Gerald Loacker <gerald.loacker@wolfvision.net>
>> Tested-by: Gerald Loacker <gerald.loacker@wolfvision.net>
>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> Signed-off-by: Michael Riesch <michael.riesch@collabora.com>
> 
> 
> Heiko
> 
> 

Best regards,
Michael

Re: [PATCH] arm64: dts: rockchip: enable vicap dvp on wolfvision pf5 io expander

[Heiko Stuebner]

On Fri, 13 Mar 2026 16:53:29 +0100, Michael Riesch wrote:
> The Digital Video Port (DVP, the 16-bit variant) of the RK3568 VICAP
> is broken out to the PF5 mainboard expansion header.
> Enable it in the device tree overlay for the WolfVision PF5 IO
> Expander board.
> 
> 

Applied, thanks!

After talking with Michael and both of us getting grey hair from
the whole mailmap thing, we agreed that I'll just adapt the author
myself.

I've applied the patch now as it's just a leaf-overlay of a single
leaf-board, so no real harm can happen here and I don't want to
have to remember all the address details in a day or two ;-) .

The git log will of course again show the @collabora.com, because
the mailmap translates the author-address again.


[1/1] arm64: dts: rockchip: enable vicap dvp on wolfvision pf5 io expander
      commit: d7787a77cf8b129304f590233032556dec10dfc6

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>