Re: [PATCH v2 1/6] dt-bindings: interrupt-controller: Add support for Realtek DHC SoCs

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 02/12/2023 17:18, James Tai [戴志峰] wrote:
> Hi Krzysztof,
> 
>>>> +
>>>> +  compatible:
>>>> +    enum:
>>>> +      - realtek,rtd1319-intc-iso
>>>> +      - realtek,rtd1319-intc-misc
>>>> +
>>>> +  "#address-cells":
>>>> +    const: 0
>>>> +
>>>> +  interrupt-controller: true
>>>> +
>>>> +  interrupts-extended:
>>>
>>> interrupts instead.
>>>
>>> Anyway, you must describe the items. Why this is not fixed but flexible?
>>> Hardware has different number of pins? That's unlikely.
>>>
>> I will replace it with 'interrupts'. Since our Interrupt controller architecture
>> doesn't involve multiple interrupt sources, using 'interrupts' should suffice.
>>
> 
> Due to changes in hardware design, some peripheral interrupts pin initially connected to the Realtek interrupt controller were redirected to the GIC. 
> However, the associated fields and statuses in the Realtek interrupt controller registers were not removed.
> As a result, these interrupts cannot be cleared by peripheral register, and their status clearing is still needing the Realtek interrupt controller driver to manage.
> 
> That's why flexibility is necessary.

This does not explain why this is not fixed per variant.

Best regards,
Krzysztof