From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DFOxKVf4" Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFE44C1 for ; Sun, 3 Dec 2023 07:05:02 -0800 (PST) Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-54c4f95e27fso2529880a12.1 for ; Sun, 03 Dec 2023 07:05:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701615901; x=1702220701; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jX9IpjfH+8GSToZOwniHDWJpuDtqbu6qE49XYEJKFo0=; b=DFOxKVf4qKVLK1Z6Sz14Rfh+wa6P6MfdOTuCvvr1bdph7DrHjRvaUz1kucHJF757eI IahQb855qxPiHOsRk3BpyjN6Kttc91V4+nVmDaWHCOFmqyeGfZj2E5/jiQQtBnINakfY rYxtq9+b5bRMGjhDJiJZZdNV7yRtJidJm0M7QtIdowtWsiL9Yv34T05F/4re59vyZ4io l8mjQ7n60PJgWwVBkgGJUpYG97pWK92SsbQ/FHSuRUVtnybelJCd4hzNSMM1iqVXFCNF 9sjw1cLEhFSCjlnBsVA9EMYBZooC1fnNb6y34iur4vgBCZMTeyD8JRdGn1EVbcXnF4+4 c9bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701615901; x=1702220701; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jX9IpjfH+8GSToZOwniHDWJpuDtqbu6qE49XYEJKFo0=; b=xRWeLEDIPlkC/zcqy5VnbfcQI89Wz3gnYq6AR95KaDFUNIXEDH3NoFI+ch/uhqtDK0 qTAVVsO7GmRU9L+u6Asp0LeuKeYgT2CZ572HX1OQ4HE2OiuM8P4mCwjlJDLwDJ6qykdD yr0+2oS5ycyix9F4nqhUPFcn40MLVySaeoO9rx6DqAN0lZzsNLjTkXSk/WXebd8+8+oc h7bUnQsAY1tK+GkYKP5fLkMr+KrRW51TCmmISMtRmzOj15mH/CMqj9KhbOeEnZmnHkMf StdAjHLFt5YidyM2UhFH9MaI0QeJTC8mOnKHFHPpHZixNRDRs5y3LnXz4oqQXW02KfBq mGFg== X-Gm-Message-State: AOJu0YzbmTqOmbX+c+T0fCpIkdA8Wx2hwe77WaBaWXtpD5W4ITC5M3jn Az72b39Wh+Uv1hqI//JQJ6YhLQ== X-Google-Smtp-Source: AGHT+IGQ1+iWj4Zm3C0MotW8aRjAqAfAjC4NQ6okmWTo+v8E+ZjrO2wEs5E0CmVkS55FxkOCg4TV7g== X-Received: by 2002:a50:cd0d:0:b0:54a:f8d9:8023 with SMTP id z13-20020a50cd0d000000b0054af8d98023mr2461518edi.37.1701615901194; Sun, 03 Dec 2023 07:05:01 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.109]) by smtp.gmail.com with ESMTPSA id n28-20020a5099dc000000b0054c9d0436a6sm1272080edb.45.2023.12.03.07.04.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 Dec 2023 07:05:00 -0800 (PST) Message-ID: <6250c57b-6d38-4085-9a79-58e4e5ed1e3d@linaro.org> Date: Sun, 3 Dec 2023 16:04:58 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/6] dt-bindings: interrupt-controller: Add support for Realtek DHC SoCs Content-Language: en-US To: =?UTF-8?B?SmFtZXMgVGFpIFvmiLTlv5fls7Bd?= , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" References: <20231117162709.1096585-1-james.tai@realtek.com> <20231117162709.1096585-2-james.tai@realtek.com> <7959920acf004f3cb8072de1e17439fa@realtek.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 02/12/2023 17:18, James Tai [戴志峰] wrote: > Hi Krzysztof, > >>>> + >>>> + compatible: >>>> + enum: >>>> + - realtek,rtd1319-intc-iso >>>> + - realtek,rtd1319-intc-misc >>>> + >>>> + "#address-cells": >>>> + const: 0 >>>> + >>>> + interrupt-controller: true >>>> + >>>> + interrupts-extended: >>> >>> interrupts instead. >>> >>> Anyway, you must describe the items. Why this is not fixed but flexible? >>> Hardware has different number of pins? That's unlikely. >>> >> I will replace it with 'interrupts'. Since our Interrupt controller architecture >> doesn't involve multiple interrupt sources, using 'interrupts' should suffice. >> > > Due to changes in hardware design, some peripheral interrupts pin initially connected to the Realtek interrupt controller were redirected to the GIC. > However, the associated fields and statuses in the Realtek interrupt controller registers were not removed. > As a result, these interrupts cannot be cleared by peripheral register, and their status clearing is still needing the Realtek interrupt controller driver to manage. > > That's why flexibility is necessary. This does not explain why this is not fixed per variant. Best regards, Krzysztof