From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Julien Panis <jpanis@baylibre.com>,
jic23@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: lars@metafoo.de, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
mranostay@ti.com
Subject: Re: [PATCH v2 1/2] dt-binding: iio: time: add capture-tiecap.yaml
Date: Thu, 28 Jul 2022 15:38:54 +0200 [thread overview]
Message-ID: <6268ec8c-73f8-6517-c7a7-a6d3ede420ab@linaro.org> (raw)
In-Reply-To: <20220728125212.76728-2-jpanis@baylibre.com>
On 28/07/2022 14:52, Julien Panis wrote:
> This commit adds a YAML binding for TI ECAP used in capture operating mode.
>
> Signed-off-by: Julien Panis <jpanis@baylibre.com>
> ---
> .../bindings/iio/time/capture-tiecap.yaml | 68 +++++++++++++++++++
> 1 file changed, 68 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/time/capture-tiecap.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/time/capture-tiecap.yaml b/Documentation/devicetree/bindings/iio/time/capture-tiecap.yaml
> new file mode 100644
> index 000000000000..5d66df90ba5d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/time/capture-tiecap.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/time/capture-tiecap.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
Still wrong file name.
Do not ignore comments you received. Either you implement them or you
keep the discussion going.
> +
> +title: Texas Instruments Enhanced Capture (eCAP) Module
> +
> +maintainers:
> + - Julien Panis <jpanis@baylibre.com>
> +
(...)
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/soc/ti,sci_pm_domain.h>
> +
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + bus@f0000 {
> + compatible = "simple-bus";
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges = <0x00 0x20000000 0x00 0x20000000 0x00 0x0a008000>;
A bit too many nodes. Just keep one, bus or soc. Look at other examples.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-28 13:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 12:52 [PATCH v2 0/2] ECAP support on TI AM62x SoC Julien Panis
2022-07-28 12:52 ` [PATCH v2 1/2] dt-binding: iio: time: add capture-tiecap.yaml Julien Panis
2022-07-28 13:38 ` Krzysztof Kozlowski [this message]
2022-07-28 17:35 ` Julien Panis
2022-07-28 12:52 ` [PATCH v2 2/2] iio: time: capture-tiecap: capture driver support for ECAP Julien Panis
2022-07-28 13:44 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6268ec8c-73f8-6517-c7a7-a6d3ede420ab@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=jpanis@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mranostay@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).