From: Heiko Stuebner <heiko@sntech.de>
To: Otavio Salvador <otavio.salvador@ossystems.com.br>
Cc: Otavio Salvador <otavio@ossystems.com.br>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Fabio Berton <fabio.berton@ossystems.com.br>,
Kernel development list <linux-kernel@vger.kernel.org>,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 08/13] ARM: dts: rv1108: Fix the PMU interrupt number
Date: Mon, 26 Nov 2018 14:46:22 +0100 [thread overview]
Message-ID: <6269571.AAM3N1jVdY@phil> (raw)
In-Reply-To: <CAP9ODKrX__KXo-XEdoaL=qwALFAxyzKV4-xu_t5baMqN1kQH4g@mail.gmail.com>
Am Montag, 26. November 2018, 14:36:01 CET schrieb Otavio Salvador:
> Hello Heiko,
>
> On Mon, Nov 26, 2018 at 3:59 AM Heiko Stuebner <heiko@sntech.de> wrote:
> > Am Sonntag, 25. November 2018, 22:19:02 CET schrieb Otavio Salvador:
> > > According to the Rockchip vendor tree the PMU interrupt number is
> > > 76, so fix it accordingly.
> > >
> > > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> > > Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
> >
> > looks ok, especially as the TRM I have doesn't list neither irqs :-)
> > But please explain the second Signed-off by Fabio?
> >
> > If Fabio is the original author, the patch From should reflect that
> > and the Signed-off-by lines should be swapped. As it is now
> > I would expect Fabio being the one sending the patches.
> > Or is it supposed to be a "Co-developed-by:"?
> > See Documentation/process/5.Posting.rst.
>
> He works with me and he applied and tested it in our internal tree for
> our customer. He reviewed and tested this with me, so I'd like to
> provide him credit as well.
Reviewed-by:
Tested-by:
perhaps then? :-)
Heiko
next prev parent reply other threads:[~2018-11-26 13:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181125211907.9895-1-otavio@ossystems.com.br>
2018-11-25 21:19 ` [PATCH 06/13] ARM: dts: rv1108: Add GMAC support Otavio Salvador
2018-11-26 9:14 ` Heiko Stuebner
2018-11-25 21:19 ` [PATCH 07/13] ARM: dts: rv1108: Fix the timer mask Otavio Salvador
2018-11-26 5:26 ` Heiko Stuebner
2018-11-26 13:45 ` Otavio Salvador
2018-11-25 21:19 ` [PATCH 08/13] ARM: dts: rv1108: Fix the PMU interrupt number Otavio Salvador
2018-11-26 5:58 ` Heiko Stuebner
2018-11-26 13:36 ` Otavio Salvador
2018-11-26 13:46 ` Heiko Stuebner [this message]
2018-11-25 21:19 ` [PATCH 09/13] ARM: dts: rv1108: Assign the proper GPIO clocks Otavio Salvador
2018-11-25 21:19 ` [PATCH 10/13] ARM: dts: rv1108: Add UART DMA support Otavio Salvador
2018-11-25 21:19 ` [PATCH 11/13] ARM: dts: rv1108: Add internal timer support Otavio Salvador
2018-11-26 8:57 ` Heiko Stuebner
2018-11-25 21:19 ` [PATCH 12/13] ARM: dts: rv1108: Pass the 'arm,cpu-registers-not-fw-configured' property Otavio Salvador
2018-11-26 9:29 ` Heiko Stuebner
2018-11-25 21:19 ` [PATCH 13/13] ARM: dts: rv1108: Pass the 'clock-latency' property Otavio Salvador
2018-11-26 9:25 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6269571.AAM3N1jVdY@phil \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=fabio.berton@ossystems.com.br \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=otavio.salvador@ossystems.com.br \
--cc=otavio@ossystems.com.br \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).